Skip to contentSkip to conversation

clocksource: mxs_timer: add missing semicolon when DEBUG is defined

PATCH Applied [email protected] 3 participants 3 messages Jan 18, 2021 – Feb 22, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 clocksource: mxs_timer: add missing semicolon when DEBUG is defined

From: Tom Rix <[email protected]>

When DEBUG is defined this error occurs

drivers/clocksource/mxs_timer.c:138:1: error:
expected ‘;’ before ‘}’ token

The preceding statement needs a semicolon.
Replace pr_info() with pr_debug() and remove the unneeded ifdef.

Fixes eb8703e2ef7c ("clockevents/drivers/mxs: Migrate to new 'set-state' interface")

---
v1: replace pr_info() with pr_debug()

---
 drivers/clocksource/mxs_timer.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/clocksource/mxs_timer.c +1 -4
index bc96a4cbf26c..e52e12d27d2a 100644
@@ -131,10 +131,7 @@ static void mxs_irq_clear(char *state)
 
 	/* Clear pending interrupt */
 	timrot_irq_acknowledge();
-
-#ifdef DEBUG
-	pr_info("%s: changing mode to %s\n", __func__, state)
-#endif /* DEBUG */
+	pr_debug("%s: changing mode to %s\n", __func__, state);
 }
 
 static int mxs_shutdown(struct clock_event_device *evt)
Signature · 7 lines
2.27.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw
Quoted 7 lines · On 18/01/2021 22:19, [email protected] wrote:

From: Tom Rix <[email protected]>

When DEBUG is defined this error occurs

drivers/clocksource/mxs_timer.c:138:1: error:
expected ‘;’ before ‘}’ token

Quoted 8 lines

The preceding statement needs a semicolon.
Replace pr_info() with pr_debug() and remove the unneeded ifdef.

Fixes eb8703e2ef7c ("clockevents/drivers/mxs: Migrate to new 'set-state' interface")

---
v1: replace pr_info() with pr_debug()
---

Applied, thanks

Signature · 10 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
merge bot Applied
#2 lore raw

[tip: timers/urgent] clocksource/drivers/mxs_timer: Add missing semicolon when DEBUG is defined

In reply to [email protected]
The following commit has been merged into the timers/urgent branch of tip:

The following commit has been merged into the timers/urgent branch of tip:

Commit-ID:     7da390694afbaed8e0f05717a541dfaf1077ba51
Gitweb:        https://git.kernel.org/tip/7da390694afbaed8e0f05717a541dfaf1077ba51
Author:        Tom Rix <[email protected]>
AuthorDate:    Mon, 18 Jan 2021 13:19:55 -08:00
Committer:     Daniel Lezcano <[email protected]>
CommitterDate: Mon, 18 Jan 2021 22:28:59 +01:00

clocksource/drivers/mxs_timer: Add missing semicolon when DEBUG is defined

When DEBUG is defined this error occurs

drivers/clocksource/mxs_timer.c:138:1: error:
expected ‘;’ before ‘}’ token

The preceding statement needs a semicolon.
Replace pr_info() with pr_debug() and remove the unneeded ifdef.

Fixes eb8703e2ef7c ("clockevents/drivers/mxs: Migrate to new 'set-state' interface")
---
 drivers/clocksource/mxs_timer.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/clocksource/mxs_timer.c +1 -4
index bc96a4c..e52e12d 100644
@@ -131,10 +131,7 @@ static void mxs_irq_clear(char *state)
 
 	/* Clear pending interrupt */
 	timrot_irq_acknowledge();
-
-#ifdef DEBUG
-	pr_info("%s: changing mode to %s\n", __func__, state)
-#endif /* DEBUG */
+	pr_debug("%s: changing mode to %s\n", __func__, state);
 }
 
 static int mxs_shutdown(struct clock_event_device *evt)