iommu/vt-d: Correctly check addr alignment in qi_flush_dev_iotlb_pasid()
Subsystems (2)
Lu Baolu
maintainerPATCH 1/1 iommu/vt-d: Correctly check addr alignment in qi_flush_dev_iotlb_pasid()
An incorrect address mask is being used in the qi_flush_dev_iotlb_pasid() to check the address alignment. This leads to a lot of spurious kernel warnings:
[ 485.837093] DMAR: Invalidate non-aligned address 7f76f47f9000, order 0 [ 485.837098] DMAR: Invalidate non-aligned address 7f76f47f9000, order 0 [ 492.494145] qi_flush_dev_iotlb_pasid: 5734 callbacks suppressed [ 492.494147] DMAR: Invalidate non-aligned address 7f7728800000, order 11 [ 492.508965] DMAR: Invalidate non-aligned address 7f7728800000, order 11
Fix it by checking the alignment in right way.
Fixes 288d08e780088 ("iommu/vt-d: Handle non-page aligned address")
Reported-and-tested-by Guo Kaijie <[email protected]>
Signed-off-by Lu Baolu <[email protected]>
Cc Liu Yi L <[email protected]>
--- drivers/iommu/intel/dmar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/intel/dmar.c +1 -1
@@ -1496,7 +1496,7 @@ void qi_flush_dev_iotlb_pasid(struct intel_iommu *iommu, u16 sid, u16 pfsid,* Max Invs Pending (MIP) is set to 0 for now until we have DIT in * ECAP. */ -if (addr &GENMASK_ULL (size_order +VTD_PAGE_SHIFT ,0 )) +if (!IS_ALIGNED (addr,VTD_PAGE_SIZE << size_order))pr_warn_ratelimited ("Invalidate non-aligned address %llx, order %d\n" , addr, size_order);
Signature · 6 lines
2.25.1 _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
Joerg Roedel
maintainerQuoted 12 lines · Lu Baolu
An incorrect address mask is being used in the
qi_flush_dev_iotlb_pasid()to check the address alignment. This leads to a lot of spurious kernel warnings:[ 485.837093] DMAR: Invalidate non-aligned address 7f76f47f9000, order 0 [ 485.837098] DMAR: Invalidate non-aligned address 7f76f47f9000, order 0 [ 492.494145] qi_flush_dev_iotlb_pasid: 5734 callbacks suppressed [ 492.494147] DMAR: Invalidate non-aligned address 7f7728800000, order 11 [ 492.508965] DMAR: Invalidate non-aligned address 7f7728800000, order 11Fix it by checking the alignment in right way.
Quoted 7 lines
Fixes 288d08e780088 ("iommu/vt-d: Handle non-page aligned address")Reported-and-tested-by Guo Kaijie <[email protected]>Signed-off-by Lu Baolu <[email protected]>Cc Liu Yi L <[email protected]>--- drivers/iommu/intel/dmar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied for 5.11, thanks.
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu