Skip to contentSkip to conversation

x86/cpu/zhaoxin: Fix wrong lowercase naming and indent

PATCH In review Isaac Chen 2 participants 3 messages Jan 18, 2021 – Jan 19, 2021

Subsystems (2)
lore
Share & tools
lore

Isaac Chen

author
#0 lore raw

PATCH 1/1 x86/cpu/zhaoxin: Fix wrong lowercase naming and indent

This is printed during kernel boot, match it with other supported x86 cpus.

    [    0.000000] KERNEL supported cpus:
    [    0.000000]   Intel GenuineIntel
    [    0.000000]   AMD AuthenticAMD
    [    0.000000]   Hygon HygonGenuine
    [    0.000000]   Centaur CentaurHauls
    [    0.000000]   zhaoxin   Shanghai
---
 arch/x86/kernel/cpu/zhaoxin.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/kernel/cpu/zhaoxin.c +2 -2
index 05fa4ef63490..f155bbd2aa97 100644
@@ -120,8 +120,8 @@ zhaoxin_size_cache(struct cpuinfo_x86 *c, unsigned int size)
 #endif
 
 static const struct cpu_dev zhaoxin_cpu_dev = {
-	.c_vendor	= "zhaoxin",
-	.c_ident	= { "  Shanghai  " },
+	.c_vendor	= "Zhaoxin",
+	.c_ident	= { "Shanghai" },
 	.c_early_init	= early_init_zhaoxin,
 	.c_init		= init_zhaoxin,
 #ifdef CONFIG_X86_32
Signature · 1 line
2.27.0
maintainer
#1 lore raw
Quoted 18 lines · Isaac Chen

This is printed during kernel boot, match it with other supported x86 cpus.

    [    0.000000] KERNEL supported cpus:
    [    0.000000]   Intel GenuineIntel
    [    0.000000]   AMD AuthenticAMD
    [    0.000000]   Hygon HygonGenuine
    [    0.000000]   Centaur CentaurHauls
    [    0.000000]   zhaoxin   Shanghai
---
 arch/x86/kernel/cpu/zhaoxin.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/kernel/cpu/zhaoxin.c +0 -0
index 05fa4ef63490..f155bbd2aa97 100644

arch/x86/kernel/cpu/zhaoxin.c zhaoxin_size_cache(struct cpuinfo_x86 *c, unsigned int size) · line 123

Quoted 6 lines
arch/x86/kernel/cpu/zhaoxin.c +1 -2
@@ -120,8 +120,8 @@ zhaoxin_size_cache(struct cpuinfo_x86 *c, unsigned int size)
 #endif
 
 static const struct cpu_dev zhaoxin_cpu_dev = {
-	.c_vendor	= "zhaoxin",
-	.c_ident	= { "  Shanghai  " },
+	.c_vendor	= "Zhaoxin",

Thanks for this patch.

arch/x86/kernel/cpu/zhaoxin.c zhaoxin_size_cache(struct cpuinfo_x86 *c, unsigned int size) · line 124

Quoted 1 line
arch/x86/kernel/cpu/zhaoxin.c +1 -0
+	.c_ident	= { "Shanghai" },

The Vendor Identification String from CPUID leaf 0x00000000 of Zhaoxin CPUs is not "Shanghai", ".c_ident = { "Shanghai" }," will cause the matching of Zhaoxin CPUs fail.
Please do not modify ".c_ident = { " Shanghai " },".

Sincerely,
Tonyw

author
#2 lore raw

PATCH 1/1 x86/cpu/zhaoxin: Fix wrong lowercase naming

This is printed during kernel boot, match it with other supported x86 cpus.

    [    0.000000] KERNEL supported cpus:
    [    0.000000]   Intel GenuineIntel
    [    0.000000]   AMD AuthenticAMD
    [    0.000000]   Hygon HygonGenuine
    [    0.000000]   Centaur CentaurHauls
    [    0.000000]   zhaoxin   Shanghai

Keep identification string match with CPUID.

---
 arch/x86/kernel/cpu/zhaoxin.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/cpu/zhaoxin.c +1 -1
index 05fa4ef63490..77c33ed80a67 100644
@@ -120,7 +120,7 @@ zhaoxin_size_cache(struct cpuinfo_x86 *c, unsigned int size)
 #endif
 
 static const struct cpu_dev zhaoxin_cpu_dev = {
-	.c_vendor	= "zhaoxin",
+	.c_vendor	= "Zhaoxin",
 	.c_ident	= { "  Shanghai  " },
 	.c_early_init	= early_init_zhaoxin,
 	.c_init		= init_zhaoxin,
Signature · 1 line
2.27.0