Skip to contentSkip to conversation

arm64: kernel: Make IPI_WAKEUP under control of CONFIG_ARM64_ACPI_PARKING_PROTOCOL

PATCH In review Chen Jun 2 participants 2 messages Jan 19, 2021 arm64

lore
Share & tools
lore

Chen Jun

author
#0 lore raw

PATCH 1/1 arm64: kernel: Make IPI_WAKEUP under control of CONFIG_ARM64_ACPI_PARKING_PROTOCOL

since commit 5e89c55e4ed81d7abb1ce8828db35fa389dc0e90 ("arm64: kernel: implement ACPI parking protocol")

On arm64, IPI 6 will be wasted without setting
CONFIG_ARM64_ACPI_PARKING_PROTOCOL.

---
 arch/arm64/kernel/smp.c | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm64/kernel/smp.c +4 -0
index ad00f99ee9b0..8b494ad1c61e 100644
@@ -73,7 +73,9 @@ enum ipi_msg_type {
 	IPI_CPU_CRASH_STOP,
 	IPI_TIMER,
 	IPI_IRQ_WORK,
+#ifdef CONFIG_ARM64_ACPI_PARKING_PROTOCOL
 	IPI_WAKEUP,
+#endif
 	NR_IPI
 };
 
@@ -795,7 +797,9 @@ static const char *ipi_types[NR_IPI] __tracepoint_string = {
 	[IPI_CPU_CRASH_STOP]	= "CPU stop (for crash dump) interrupts",
 	[IPI_TIMER]		= "Timer broadcast interrupts",
 	[IPI_IRQ_WORK]		= "IRQ work interrupts",
+#ifdef CONFIG_ARM64_ACPI_PARKING_PROTOCOL
 	[IPI_WAKEUP]		= "CPU wake-up interrupts",
+#endif
 };
 
 static void smp_cross_call(const struct cpumask *target, unsigned int ipinr);
Signature · 7 lines
2.25.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw
Quoted 16 lines · Chen Jun

since commit 5e89c55e4ed81d7abb1ce8828db35fa389dc0e90 ("arm64: kernel: implement ACPI parking protocol")

On arm64, IPI 6 will be wasted without setting
CONFIG_ARM64_ACPI_PARKING_PROTOCOL.

---
 arch/arm64/kernel/smp.c | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm64/kernel/smp.c +0 -0
index ad00f99ee9b0..8b494ad1c61e 100644

arch/arm64/kernel/smp.c enum ipi_msg_type { · line 74

Quoted 2 lines
arch/arm64/kernel/smp.c +0 -0
@@ -73,7 +73,9 @@ enum ipi_msg_type {
 	IPI_CPU_CRASH_STOP,
 	IPI_TIMER,

Going by that logic, IPI_TIMER is used only when
CONFIG_GENERIC_CLOCKEVENTS_BROADCAST=y and

arch/arm64/kernel/smp.c enum ipi_msg_type { · line 75

Quoted 1 line
arch/arm64/kernel/smp.c +0 -0
 	IPI_IRQ_WORK,

IPI_IRQ_WORK when CONFIG_IRQ_WORK=y

Not sure if we what to go down that path as it may result in confusion about IPI number and what OS is using it for. I am not against this, just want to know others opinion on this.

arch/arm64/kernel/smp.c enum ipi_msg_type { · line 78

Quoted 3 lines
arch/arm64/kernel/smp.c +2 -0
+#ifdef CONFIG_ARM64_ACPI_PARKING_PROTOCOL
 	IPI_WAKEUP,
+#endif

Just out of curiosity, are you changing this only by code inspection or or you running short of IPI with some downstream patches. It will be interesting to know how you are using then if you are as it may break if kernel decides to you them in future for its own use.

Signature · 7 lines
Regards,
Sudeep

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel