Skip to contentSkip to conversation

lib: add basic KUnit test for lib/math

PATCH Superseded Daniel Latypov 1 participant 1 message Jan 19, 2021 Kselftest

v3 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 lib: add basic KUnit test for lib/math

Add basic test coverage for files that don't require any config options:
* gcd.c
* lcm.c
* int_sqrt.c
* reciprocal_div.c
(Ignored int_pow.c since it's a simple textbook algorithm.)

These tests aren't particularly interesting, but they
* provide short and simple examples of parameterized tests
* provide a place to add tests for any new files in this dir
* are written so adding new test cases to cover edge cases should be easy

---
Changes since v2: mv math_test.c => math_kunit.c

Changes since v1:
* Rebase and rewrite to use the new parameterized testing support.
* misc: fix overflow in literal and inline int_sqrt format string.
* related: commit 1f0e943df68a ("Documentation: kunit: provide guidance for testing many inputs") was merged explaining the patterns shown here.
* there's an in-flight patch to update it for parameterized testing.

v1: https://lore.kernel.org/lkml/[email protected]/

---
 lib/math/Kconfig      |   5 ++
 lib/math/Makefile     |   2 +
 lib/math/math_kunit.c | 197 ++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 204 insertions(+)
 create mode 100644 lib/math/math_kunit.c
lib/math/Kconfig +5 -0
index f19bc9734fa7..6ba8680439c1 100644
@@ -15,3 +15,8 @@ config PRIME_NUMBERS
 
 config RATIONAL
 	bool
+
+config MATH_KUNIT_TEST
+	tristate "KUnit test for lib/math" if !KUNIT_ALL_TESTS
+	default KUNIT_ALL_TESTS
+	depends on KUNIT
lib/math/Makefile +2 -0
index be6909e943bd..30abb7a8d564 100644
@@ -4,3 +4,5 @@ obj-y += div64.o gcd.o lcm.o int_pow.o int_sqrt.o reciprocal_div.o
 obj-$(CONFIG_CORDIC)		+= cordic.o
 obj-$(CONFIG_PRIME_NUMBERS)	+= prime_numbers.o
 obj-$(CONFIG_RATIONAL)		+= rational.o
+
+obj-$(CONFIG_MATH_KUNIT_TEST)	+= math_kunit.o
lib/math/math_kunit.c new file +197 -0

197 lines not on this page · raw message

base-commit: 65f0d2414b7079556fbbcc070b3d1c9f9587606d

Signature · 1 line
2.30.0.296.g2bfb1c46d8-goog