amdgpu/ras: Fix bug disabling DF_CSTATE when injecting xgmi_wafl errors via debugfs
Subsystems (2)
PATCH 1/1 amdgpu/ras: Fix bug disabling DF_CSTATE when injecting xgmi_wafl errors via debugfs
Typo in amdgpu_ras_error_inject_xgmi() does not set df_state back to ALLOW after test this can be tested with the command
echo inject xgmi_wafl ue 0x0 0x0 0x0 > /sys/kernel/debug/dri/0/ras/ras_ctrl
Fixes patch 5c23e9e05e42b5ea56a87a17f1da9ccf9b100465
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +1 -1
@@ -846,7 +846,7 @@ static int amdgpu_ras_error_inject_xgmi(struct amdgpu_device *adev,if (amdgpu_dpm_allow_xgmi_power_down (adev, true))dev_warn (adev->dev,"Failed to allow XGMI power down" ); -if (amdgpu_dpm_set_df_cstate (adev,DF_CSTATE_DISALLOW )) +if (amdgpu_dpm_set_df_cstate (adev,DF_CSTATE_ALLOW ))dev_warn (adev->dev,"Failed to allow df cstate" );return ret;
base-commit: ed94c622f91453aaca80029b0afdd2551a12e777
Signature · 6 lines
2.25.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[AMD Public Use]
Thanks Darren. We have the fix already a few days ago.
drm/amdgpu: toggle on DF Cstate after finishing xgmi injection
Regards,
Guchun
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Darren Powell
Sent: Wednesday, January 20, 2021 12:46 PM
To: [email protected]
Cc: Powell, Darren <[email protected]>
Subject: [PATCH] amdgpu/ras: Fix bug disabling DF_CSTATE when injecting xgmi_wafl errors via debugfs
Typo in amdgpu_ras_error_inject_xgmi() does not set df_state back to ALLOW after test this can be tested with the command
echo inject xgmi_wafl ue 0x0 0x0 0x0 > /sys/kernel/debug/dri/0/ras/ras_ctrl
Fixes patch 5c23e9e05e42b5ea56a87a17f1da9ccf9b100465
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +1 -1
@@ -846,7 +846,7 @@ static int amdgpu_ras_error_inject_xgmi(struct amdgpu_device *adev,if (amdgpu_dpm_allow_xgmi_power_down (adev, true))dev_warn (adev->dev,"Failed to allow XGMI power down" ); -if (amdgpu_dpm_set_df_cstate (adev,DF_CSTATE_DISALLOW )) +if (amdgpu_dpm_set_df_cstate (adev,DF_CSTATE_ALLOW ))dev_warn (adev->dev,"Failed to allow df cstate" );return ret;
base-commit: ed94c622f91453aaca80029b0afdd2551a12e777 --
2.25.1
_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Cguchun.chen%40amd.com%7Cf1d970cd301e450a074508d8bcfe5a16%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637467147916210362%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Qp1VIuGOhTZPpfHSwnbMbHycrFqhaxIgN3AZkkiHF6g%3D&reserved=0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx