fs/affs: release old buffer head on error path
Subsystems (2)
PATCH 1/1 fs/affs: release old buffer head on error path
The reference count of the old buffer head should be decremented on path that fails to get the new buffer head.
Fixes 6b4657667ba0 ("fs/affs: add rename exchange")
Signed-off-by Pan Bian <[email protected]>
--- fs/affs/namei.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
fs/affs/namei.c +3 -1
@@ -460,8 +460,10 @@ affs_xrename(struct inode *old_dir, struct dentry *old_dentry,return -EIO ; bh_new =affs_bread (sb,d_inode (new_dentry)->i_ino); -if (!bh_new) +if (!bh_new) { +affs_brelse (bh_old);return -EIO ; + }/* Remove old header from its parent directory. */ affs_lock_dir (old_dir);
Signature · 1 line
2.17.1
Quoted 5 lines · Pan Bian
The reference count of the old buffer head should be decremented on path that fails to get the new buffer head.
Fixes 6b4657667ba0 ("fs/affs: add rename exchange")Signed-off-by Pan Bian <[email protected]>
Thanks, added to affs branch. The fix is not that urgent for 5.11 so I'll send it for the 5.12 merge window. I've added the stable tag so it'll propagate to 4.14+.