Skip to contentSkip to conversation

z3fold: Simplify the zhdr initialization code in init_z3fold_page()

PATCH Applied Miaohe Lin 1 participant 1 message Jan 20, 2021 Memory management

lore
Share & tools
lore

Miaohe Lin

author
#0 lore raw

PATCH 1/1 z3fold: Simplify the zhdr initialization code in init_z3fold_page()

We can simplify the zhdr initialization by memset() the zhdr first instead of set struct member to zero one by one. This would also make code more compact and clear.

---
 mm/z3fold.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
mm/z3fold.c +1 -7
index 8e53cdf4d190..c1ccf6bb0ffb 100644
@@ -413,16 +413,10 @@ static struct z3fold_header *init_z3fold_page(struct page *page, bool headless,
 	if (!slots)
 		return NULL;
 
+	memset(zhdr, 0, sizeof(*zhdr));
 	spin_lock_init(&zhdr->page_lock);
 	kref_init(&zhdr->refcount);
-	zhdr->first_chunks = 0;
-	zhdr->middle_chunks = 0;
-	zhdr->last_chunks = 0;
-	zhdr->first_num = 0;
-	zhdr->start_middle = 0;
 	zhdr->cpu = -1;
-	zhdr->foreign_handles = 0;
-	zhdr->mapped_count = 0;
 	zhdr->slots = slots;
 	zhdr->pool = pool;
 	INIT_LIST_HEAD(&zhdr->buddy);
Signature · 1 line
2.19.1