Skip to contentSkip to conversation

Add Google RE2 library

PATCH Superseded Clément Péron 2 participants 3 messages Jan 20, 2021

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add Google RE2 library

Add Google RE2 regular expression library.

This is used in new version of gRPC.

---

Hi,

This is my first contribution to meta-openembedded.

I would like to bump gRPC to new version but re2 library is required.

I'm not sure if i should call the package re2 or libre2.

Regards,
Clement

 .../libre2/libre2_2020.11.01.bb               | 23 +++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 meta-oe/recipes-support/libre2/libre2_2020.11.01.bb
meta-oe/recipes-support/libre2/libre2_2020.11.01.bb new file +23 -0
new file mode 100644
index 000000000000..7c07b332dfff
@@ -0,0 +1,23 @@
+DESCRIPTION = "A regular expression library"
+HOMEPAGE = "https://github.com/google/re2/"
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=3b5c31eb512bdf3cb11ffd5713963760"
+
+SRCREV = "166dbbeb3b0ab7e733b278e8f42a84f6882b8a25"
+
+SRC_URI = "git://github.com/google/re2.git;branch=master"
+
+S = "${WORKDIR}/git"
+
+inherit cmake
+
+EXTRA_OECMAKE += " \
+	-DBUILD_SHARED_LIBS=ON \
+	-DRE2_BUILD_TESTING=OFF \
+"
+
+# Don't include so files in dev package
+FILES_${PN} = "${libdir}"
+FILES_${PN}-dev = "${includedir} ${libdir}/cmake/re2/*.cmake"
+
+BBCLASSEXTEND = "native nativesdk"
Signature · 1 line
2.25.1
#1 lore raw
Quoted 8 lines · Clément Péron

Add Google RE2 regular expression library.

This is used in new version of gRPC.

---

Quoted 7 lines

Hi,

This is my first contribution to meta-openembedded.

I would like to bump gRPC to new version but re2 library is required.

I'm not sure if i should call the package re2 or libre2.

Hi Clément,

I'd use "re2" if that's the upstream name of the project.

You should also modify the commit summary to follow the format shown in https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines.
So it'd be something like "re2: Add recipe for Google RE2 library".

Thanks,

--
Paul Barker
Konsulko Group

#2 lore raw

Hi Paul,

Quoted 18 lines · Paul Barker
Quoted 8 lines · Clément Péron

Add Google RE2 regular expression library.

This is used in new version of gRPC.

---

Quoted 7 lines

Hi,

This is my first contribution to meta-openembedded.

I would like to bump gRPC to new version but re2 library is required.

I'm not sure if i should call the package re2 or libre2.

Quoted 7 lines

Hi Clément,

I'd use "re2" if that's the upstream name of the project.

You should also modify the commit summary to follow the format shown in https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines.
So it'd be something like "re2: Add recipe for Google RE2 library".

Thanks for the review, I will send a v2,
Regards,
Clement

Quoted 6 lines

Thanks,

--
Paul Barker
Konsulko Group