Skip to contentSkip to conversation

libceph: fix "Boolean result is used in bitwise operation" warning

PATCH New Ilya Dryomov 1 participant 1 message Jan 20, 2021 Ceph common code (libceph)

lore
Share & tools
lore

Ilya Dryomov

author maintainer
#0 lore raw

PATCH 1/1 libceph: fix "Boolean result is used in bitwise operation" warning

This line dates back to 2013, but cppcheck complained because commit 2f713615ddd9 ("libceph: move msgr1 protocol implementation to its own file") moved it. Add parenthesis to silence the warning.

---
 net/ceph/messenger_v1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/ceph/messenger_v1.c +1 -1
index 04f653b3c897..2cb5ffdf071a 100644
@@ -1100,7 +1100,7 @@ static int read_partial_message(struct ceph_connection *con)
 		if (ret < 0)
 			return ret;
 
-		BUG_ON(!con->in_msg ^ skip);
+		BUG_ON((!con->in_msg) ^ skip);
 		if (skip) {
 			/* skip this message */
 			dout("alloc_msg said skip message\n");
Signature · 1 line
2.19.2