Skip to contentSkip to conversation

x86/xen: Fix compilation error due to missing nopvspin declaration

PATCH In review Leon Romanovsky 2 participants 3 messages Jan 20, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/xen: Fix compilation error due to missing nopvspin declaration

From: Leon Romanovsky <[email protected]>

arch/x86/xen/smp_hvm.c: In function 'xen_hvm_smp_init':
arch/x86/xen/smp_hvm.c:77:3: error: 'nopvspin' undeclared (first use in this function)

    nopvspin = true;
    ^~~~~~~~

arch/x86/xen/smp_hvm.c:77:3: note: each undeclared identifier is reported only once for each function it appears in make[4]: *** [scripts/Makefile.build:279: arch/x86/xen/smp_hvm.o] Error 1
make[3]: *** [scripts/Makefile.build:496: arch/x86/xen] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [Makefile:1805: arch/x86] Error 2
make[2]: *** Waiting for unfinished jobs....

Fixes 3d7746bea925 ("x86/xen: Fix xen_hvm_smp_init() when vector callback not available")
---
 arch/x86/xen/smp_hvm.c | 1 +
 1 file changed, 1 insertion(+)
arch/x86/xen/smp_hvm.c +1 -0
index 056430a1080b..1656713db71c 100644
@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0
 #include <linux/thread_info.h>
 #include <asm/smp.h>
+#include <asm/qspinlock.h>
 
 #include <xen/events.h>
 

--
2.29.2

maintainer
#1 lore raw
Quoted 13 lines · Leon Romanovsky

From: Leon Romanovsky <[email protected]>

arch/x86/xen/smp_hvm.c: In function 'xen_hvm_smp_init':
arch/x86/xen/smp_hvm.c:77:3: error: 'nopvspin' undeclared (first use in this function)

     nopvspin = true;
     ^~~~~~~~

arch/x86/xen/smp_hvm.c:77:3: note: each undeclared identifier is reported only once for each function it appears in make[4]: *** [scripts/Makefile.build:279: arch/x86/xen/smp_hvm.o] Error 1
make[3]: *** [scripts/Makefile.build:496: arch/x86/xen] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [Makefile:1805: arch/x86] Error 2
make[2]: *** Waiting for unfinished jobs....

Quoted 2 lines
Fixes 3d7746bea925 ("x86/xen: Fix xen_hvm_smp_init() when vector callback not available")

There is already a fix queued in the xen tree.

Juergen

#2 lore raw
Quoted 14 lines · Jürgen Groß
Quoted 13 lines · Leon Romanovsky

From: Leon Romanovsky <[email protected]>

arch/x86/xen/smp_hvm.c: In function 'xen_hvm_smp_init':
arch/x86/xen/smp_hvm.c:77:3: error: 'nopvspin' undeclared (first use in this function)

     nopvspin = true;
     ^~~~~~~~

arch/x86/xen/smp_hvm.c:77:3: note: each undeclared identifier is reported only once for each function it appears in make[4]: *** [scripts/Makefile.build:279: arch/x86/xen/smp_hvm.o] Error 1
make[3]: *** [scripts/Makefile.build:496: arch/x86/xen] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [Makefile:1805: arch/x86] Error 2
make[2]: *** Waiting for unfinished jobs....

Quoted 4 lines
Quoted 2 lines
Fixes 3d7746bea925 ("x86/xen: Fix xen_hvm_smp_init() when vector callback not available")

There is already a fix queued in the xen tree.

Glad to hear, it is unfortunate that the problematic commit already in Linus tree.

Thanks

Quoted 3 lines

Juergen