thermal: drop reference of child node on error
Subsystems (2)
PATCH 1/1 thermal: drop reference of child node on error
Drop the reference of the child node sen_child before goto out of the loop.
Signed-off-by Pan Bian <[email protected]>
--- drivers/thermal/sprd_thermal.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/thermal/sprd_thermal.c +4 -0
@@ -387,6 +387,7 @@ static int sprd_thm_probe(struct platform_device *pdev)for_each_child_of_node (np, sen_child) { sen =devm_kzalloc (&pdev->dev,sizeof (*sen),GFP_KERNEL );if (!sen) { +of_node_put (sen_child); ret = -ENOMEM ; goto disable_clk; }
@@ -397,12 +398,14 @@ static int sprd_thm_probe(struct platform_device *pdev) ret =of_property_read_u32 (sen_child,"reg" , &sen->id);if (ret) {dev_err (&pdev->dev,"get sensor reg failed" ); +of_node_put (sen_child); goto disable_clk; } ret =sprd_thm_sensor_calibration (sen_child, thm, sen);if (ret) {dev_err (&pdev->dev,"efuse cal analysis failed" ); +of_node_put (sen_child); goto disable_clk; }
@@ -415,6 +418,7 @@ static int sprd_thm_probe(struct platform_device *pdev)if (IS_ERR (sen->tzd)) {dev_err (&pdev->dev,"register thermal zone failed %d\n" , sen->id); +of_node_put (sen_child); ret =PTR_ERR (sen->tzd); goto disable_clk; }
Signature · 1 line
2.17.1