mm,hwpoison: Differentiate Action Required error in current and non current processes
Subsystems (2)
PATCH v4 1/1 mm,hwpoison: Differentiate Action Required error in current and non current processes
When a memory uncorrected error is triggered by process A who accessed the address with error; It's Action Required Case for only current process which triggered this.this Action Required case means Action optional to other process who share the same page. Usually, kill current process will be sufficient, other process sharing the same page will get be signaled when they really touch the poisoned page.
But there is another scenario that other processes
sharing the same page want to be signaled early with PF_MCE_EARLY set, In this case, we should get them into kill list and signal BUS_MCEERR_AO to them.
So in this patch, task_early_kill will check current process if force_early is set, and if not current,check find_early_kill_thread to see if there is PF_MCE_EARLY process which cares the error.
In kill_proc, BUS_MCEERR_AR is only send to current, other process in kill list will be signaled BUS_MCEERR_AO.
--- mm/memory-failure.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-)
mm/memory-failure.c +11 -7
@@ -243,9 +243,12 @@ static int kill_proc(struct to_kill *tk, unsigned long pfn, int flags) pfn, t->comm, t->pid);if (flags &MF_ACTION_REQUIRED ) { -WARN_ON_ONCE (t != current); - ret =force_sig_mceerr (BUS_MCEERR_AR , +if (tk->tsk == current) + ret =force_sig_mceerr (BUS_MCEERR_AR , (void __user *)tk->addr, addr_lsb); +else + ret =send_sig_mceerr (BUS_MCEERR_AO , (void __user *)tk->addr, + addr_lsb, t); }else {/* * Don't use force here, it's convenient if the signal
@@ -440,10 +443,13 @@ static struct task_struct *find_early_kill_thread(struct task_struct *tsk)* Determine whether a given process is "early kill" process which expects * to be signaled when some page under the process is hwpoisoned. * Return task_struct of the dedicated thread (main thread unless explicitly -* specified) if the process is "early kill," and otherwise returns NULL. +* specified) if the process is "early kill" and otherwise returns NULL. * -* Note that the above is true for Action Optional case, but not for Action -* Required case where SIGBUS should sent only to the current thread. +* Note that the above is true for Action Optional case. For Action Required +* case, it's only meaningful to the current thread which need to be signaled +* with SIGBUS, this error is Action Optional for other non current +* processes sharing the same error page,if the process is "early kill",the +* task_struct of the dedicated thread will also be returned. */ static struct task_struct *task_early_kill (struct task_struct *tsk,int force_early)
@@ -457,8 +463,6 @@ static struct task_struct *task_early_kill(struct task_struct *tsk,*/ if (tsk->mm == current->mm)return current; -else -return NULL ; }return find_early_kill_thread (tsk); }
Signature · 8 lines
2.25.1 -- Best Regards! Aili Yao
It's desirable that $SUBJECT represents what that patch does, so
how about something like
"mm, hwpoison: send SIGBUS to PF_MCE_EARLY processes on action required events" ?
Quoted 20 lines · Aili Yao
When a memory uncorrected error is triggered by process A who accessed the address with error; It's Action Required Case for only current process which triggered this.this Action Required case means Action optional to other process who share the same page. Usually, kill current process will be sufficient, other process sharing the same page will get be signaled when they really touch the poisoned page.
But there is another scenario that other processes
sharing the same page want to be signaled early withPF_MCE_EARLYset, In this case, we should get them into kill list and signalBUS_MCEERR_AOto them.So in this patch,
task_early_killwill check current process ifforce_earlyis set, and if not current,checkfind_early_kill_threadto see if there isPF_MCE_EARLYprocess which cares the error.In
kill_proc,BUS_MCEERR_ARis only send to current, other process in kill list will be signaledBUS_MCEERR_AO.Signed-off-by Aili Yao <[email protected]>
...
mm/memory-failure.c static struct task_struct *find_early_kill_thread(struct task_struct *tsk) · line 451
Quoted 13 lines
mm/memory-failure.c +5
-3@@ -440,10 +443,13 @@ static struct task_struct *find_early_kill_thread(struct task_struct *tsk)* Determine whether a given process is "early kill" process which expects * to be signaled when some page under the process is hwpoisoned. * Return task_struct of the dedicated thread (main thread unless explicitly -* specified) if the process is "early kill," and otherwise returns NULL. +* specified) if the process is "early kill" and otherwise returns NULL. * -* Note that the above is true for Action Optional case, but not for Action -* Required case where SIGBUS should sent only to the current thread. +* Note that the above is true for Action Optional case. For Action Required +* case, it's only meaningful to the current thread which need to be signaled +* with SIGBUS, this error is Action Optional for other non current +* processes sharing the same error page,if the process is "early kill",the
Please insert a whitespace after commas (just for convention).
With these fixed, I agree with this patch.
Quoted 3 lines · On Wed, 20 Jan 2021 07:59:23 +0000 HORIGUCHI NAOYA(堀口 直也)…
It's desirable that $SUBJECT represents what that patch does, so
how about something like
"mm, hwpoison: send SIGBUS toPF_MCE_EARLYprocesses on action required events" ?
This one looks better, i will change to that. Thanks
Quoted 15 lines
...
mm/memory-failure.c static struct task_struct *find_early_kill_thread(struct task_struct *tsk) · line 451
Quoted 13 lines
mm/memory-failure.c +5
-3@@ -440,10 +443,13 @@ static struct task_struct *find_early_kill_thread(struct task_struct *tsk)* Determine whether a given process is "early kill" process which expects * to be signaled when some page under the process is hwpoisoned. * Return task_struct of the dedicated thread (main thread unless explicitly -* specified) if the process is "early kill," and otherwise returns NULL. +* specified) if the process is "early kill" and otherwise returns NULL. * -* Note that the above is true for Action Optional case, but not for Action -* Required case where SIGBUS should sent only to the current thread. +* Note that the above is true for Action Optional case. For Action Required +* case, it's only meaningful to the current thread which need to be signaled +* with SIGBUS, this error is Action Optional for other non current +* processes sharing the same error page,if the process is "early kill",the
Thanks for reminding, I will fix this in v5 patch
Thank you!
Signature · 3 lines
Best Regards! Aili Yao