Skip to contentSkip to conversation

arm64: dts: ti: k3*: Fixup PMU compatibility to be CPU specific

PATCH Applied Nishanth Menon 3 participants 4 messages Jan 20, 2021 – Jan 22, 2021

Subsystems (2)
lore
Share & tools
lore

Nishanth Menon

author maintainer
#0 lore raw

PATCH 1/1 arm64: dts: ti: k3*: Fixup PMU compatibility to be CPU specific

We can use CPU specific pmu configuration to expose the appropriate CPU specific events rather than just the basic generic pmuv3 perf events.

---

AM65: https://pastebin.ubuntu.com/p/TF2cCMySkt/
J721E: https://pastebin.ubuntu.com/p/jgGPNmNgG3/
J7200: https://pastebin.ubuntu.com/p/Kfc3VHHXNB/

Original report: https://lore.kernel.org/linux-arm-kernel/20210119172412.smsjdo2sjzqi5vcn@bogus/

I have'nt split this patch up for fixes tag primarily because the basic functionality works and this is an improvement than a critical fixup to backport for older kernels.

 arch/arm64/boot/dts/ti/k3-am65.dtsi  | 2 +-
 arch/arm64/boot/dts/ti/k3-j7200.dtsi | 2 +-
 arch/arm64/boot/dts/ti/k3-j721e.dtsi | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/ti/k3-am65.dtsi +1 -1
index d84c0bc05023..a9fc1af03f27 100644
@@ -56,7 +56,7 @@ a53_timer0: timer-cl0-cpu0 {
 	};
 
 	pmu: pmu {
-		compatible = "arm,armv8-pmuv3";
+		compatible = "arm,cortex-a53-pmu";
 		/* Recommendation from GIC500 TRM Table A.3 */
 		interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
 	};
arch/arm64/boot/dts/ti/k3-j7200.dtsi +1 -1
index 66169bcf7c9a..b7005b803149 100644
@@ -114,7 +114,7 @@ a72_timer0: timer-cl0-cpu0 {
 	};
 
 	pmu: pmu {
-		compatible = "arm,armv8-pmuv3";
+		compatible = "arm,cortex-a72-pmu";
 		interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
 	};
 
arch/arm64/boot/dts/ti/k3-j721e.dtsi +1 -1
index cc483f7344af..f0587fde147e 100644
@@ -115,7 +115,7 @@ a72_timer0: timer-cl0-cpu0 {
 	};
 
 	pmu: pmu {
-		compatible = "arm,armv8-pmuv3";
+		compatible = "arm,cortex-a72-pmu";
 		/* Recommendation from GIC500 TRM Table A.3 */
 		interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
 	};
Signature · 7 lines
2.25.1.377.g2d2118b814c1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Tested-by on v1 1/1
#1 lore raw
Quoted 6 lines · Nishanth Menon

We can use CPU specific pmu configuration to expose the appropriate CPU specific events rather than just the basic generic pmuv3 perf events.

regards
Suman

Quoted 49 lines

---

AM65: https://pastebin.ubuntu.com/p/TF2cCMySkt/
J721E: https://pastebin.ubuntu.com/p/jgGPNmNgG3/
J7200: https://pastebin.ubuntu.com/p/Kfc3VHHXNB/

Original report: https://lore.kernel.org/linux-arm-kernel/20210119172412.smsjdo2sjzqi5vcn@bogus/

I have'nt split this patch up for fixes tag primarily because the basic functionality works and this is an improvement than a critical fixup to backport for older kernels.

 arch/arm64/boot/dts/ti/k3-am65.dtsi  | 2 +-
 arch/arm64/boot/dts/ti/k3-j7200.dtsi | 2 +-
 arch/arm64/boot/dts/ti/k3-j721e.dtsi | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/ti/k3-am65.dtsi +1 -1
index d84c0bc05023..a9fc1af03f27 100644
@@ -56,7 +56,7 @@ a53_timer0: timer-cl0-cpu0 {
 	};
 
 	pmu: pmu {
-		compatible = "arm,armv8-pmuv3";
+		compatible = "arm,cortex-a53-pmu";
 		/* Recommendation from GIC500 TRM Table A.3 */
 		interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
 	};
arch/arm64/boot/dts/ti/k3-j7200.dtsi +1 -1
index 66169bcf7c9a..b7005b803149 100644
@@ -114,7 +114,7 @@ a72_timer0: timer-cl0-cpu0 {
 	};
 
 	pmu: pmu {
-		compatible = "arm,armv8-pmuv3";
+		compatible = "arm,cortex-a72-pmu";
 		interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
 	};
 
arch/arm64/boot/dts/ti/k3-j721e.dtsi +0 -0
index cc483f7344af..f0587fde147e 100644

arch/arm64/boot/dts/ti/k3-j721e.dtsi a72_timer0: timer-cl0-cpu0 { · line 121

Quoted 8 lines
arch/arm64/boot/dts/ti/k3-j721e.dtsi +1 -1
@@ -115,7 +115,7 @@ a72_timer0: timer-cl0-cpu0 {
 	};
 
 	pmu: pmu {
-		compatible = "arm,armv8-pmuv3";
+		compatible = "arm,cortex-a72-pmu";
 		/* Recommendation from GIC500 TRM Table A.3 */
 		interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
 	};

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Nishanth Menon
Quoted 6 lines · Nishanth Menon

We can use CPU specific pmu configuration to expose the appropriate CPU specific events rather than just the basic generic pmuv3 perf events.

Quoted 49 lines

---

AM65: https://pastebin.ubuntu.com/p/TF2cCMySkt/
J721E: https://pastebin.ubuntu.com/p/jgGPNmNgG3/
J7200: https://pastebin.ubuntu.com/p/Kfc3VHHXNB/

Original report: https://lore.kernel.org/linux-arm-kernel/20210119172412.smsjdo2sjzqi5vcn@bogus/

I have'nt split this patch up for fixes tag primarily because the basic functionality works and this is an improvement than a critical fixup to backport for older kernels.

  arch/arm64/boot/dts/ti/k3-am65.dtsi  | 2 +-
  arch/arm64/boot/dts/ti/k3-j7200.dtsi | 2 +-
  arch/arm64/boot/dts/ti/k3-j721e.dtsi | 2 +-
  3 files changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/ti/k3-am65.dtsi +1 -1
index d84c0bc05023..a9fc1af03f27 100644
@@ -56,7 +56,7 @@ a53_timer0: timer-cl0-cpu0 {
  	};
 
  	pmu: pmu {
-		compatible = "arm,armv8-pmuv3";
+		compatible = "arm,cortex-a53-pmu";
  		/* Recommendation from GIC500 TRM Table A.3 */
  		interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
  	};
arch/arm64/boot/dts/ti/k3-j7200.dtsi +1 -1
index 66169bcf7c9a..b7005b803149 100644
@@ -114,7 +114,7 @@ a72_timer0: timer-cl0-cpu0 {
  	};
 
  	pmu: pmu {
-		compatible = "arm,armv8-pmuv3";
+		compatible = "arm,cortex-a72-pmu";
  		interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
  	};
 
arch/arm64/boot/dts/ti/k3-j721e.dtsi +0 -0
index cc483f7344af..f0587fde147e 100644

arch/arm64/boot/dts/ti/k3-j721e.dtsi a72_timer0: timer-cl0-cpu0 { · line 121

Quoted 8 lines
arch/arm64/boot/dts/ti/k3-j721e.dtsi +1 -1
@@ -115,7 +115,7 @@ a72_timer0: timer-cl0-cpu0 {
  	};
 
  	pmu: pmu {
-		compatible = "arm,armv8-pmuv3";
+		compatible = "arm,cortex-a72-pmu";
  		/* Recommendation from GIC500 TRM Table A.3 */
  		interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
  	};

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

author maintainer Applied
#3 lore raw
In reply to Nishanth Menon
Quoted 3 lines · Nishanth Menon

We can use CPU specific pmu configuration to expose the appropriate CPU specific events rather than just the basic generic pmuv3 perf events.

Hi Nishanth Menon,

I have applied the following to branch ti-k3-dts-next on [1]. Thank you!

[1/1] arm64: dts: ti: k3*: Fixup PMU compatibility to be CPU specific

      commit: c72bf319f12803d8c8ddc3dbf54927380fc65b50

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

[1] git://git.kernel.org/pub/scm/linux/kernel/git/nmenon/linux.git

Signature · 9 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel