net/bnxt: fix to release lock in error path of stop and close op
PATCH 1/1 net/bnxt: fix to release lock in error path of stop and close op
err_recovery_lock needs to be released before returning in stop and close_op if FW_RESET flag is set.
--- drivers/net/bnxt/bnxt_ethdev.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/bnxt/bnxt_ethdev.c +2 -0
@@ -1374,6 +1374,7 @@ static int bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)if (bp->flags &BNXT_FLAG_FW_RESET ) {PMD_DRV_LOG (ERR ,"Adapter recovering from error..Please retry\n" ); +pthread_mutex_unlock (&bp->err_recovery_lock);return -EAGAIN ; }pthread_mutex_unlock (&bp->err_recovery_lock);
@@ -1476,6 +1477,7 @@ static int bnxt_dev_close_op(struct rte_eth_dev *eth_dev)if (bp->flags &BNXT_FLAG_FW_RESET ) {PMD_DRV_LOG (ERR ,"Adapter recovering from error...Please retry\n" ); +pthread_mutex_unlock (&bp->err_recovery_lock);return -EAGAIN ; }pthread_mutex_unlock (&bp->err_recovery_lock);
Signature · 1 line
2.28.0.497.g54e85e7
PATCH v2 1/1 net/bnxt: fix lock handling in stop and close
From: Somnath Kotur <[email protected]>
err_recovery_lock needs to be released before returning in stop and close_op if FW_RESET flag is set.
---v1->v2: rebased to latest dpdk-next-net and updated commit log.
--- drivers/net/bnxt/bnxt_ethdev.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/bnxt/bnxt_ethdev.c +2 -0
@@ -1374,6 +1374,7 @@ static int bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)if (bp->flags &BNXT_FLAG_FW_RESET ) {PMD_DRV_LOG (ERR ,"Adapter recovering from error..Please retry\n" ); +pthread_mutex_unlock (&bp->err_recovery_lock);return -EAGAIN ; }pthread_mutex_unlock (&bp->err_recovery_lock);
@@ -1497,6 +1498,7 @@ static int bnxt_dev_close_op(struct rte_eth_dev *eth_dev)if (bp->flags &BNXT_FLAG_FW_RESET ) {PMD_DRV_LOG (ERR ,"Adapter recovering from error...Please retry\n" ); +pthread_mutex_unlock (&bp->err_recovery_lock);return -EAGAIN ; }pthread_mutex_unlock (&bp->err_recovery_lock);
Signature · 1 line
2.21.1 (Apple Git-122.3)
PATCH v3 1/1 net/bnxt: fix lock handling in stop and close
From: Somnath Kotur <[email protected]>
err_recovery_lock needs to be released before returning in stop and close_op if FW_RESET flag is set.
---v1->v2: rebased to latest dpdk-next-net and updated commit log. v2->v3: rebased to latest dpdk-next-net.
--- drivers/net/bnxt/bnxt_ethdev.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/bnxt/bnxt_ethdev.c +2 -0
@@ -1374,6 +1374,7 @@ static int bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)if (bp->flags &BNXT_FLAG_FW_RESET ) {PMD_DRV_LOG (ERR ,"Adapter recovering from error..Please retry\n" ); +pthread_mutex_unlock (&bp->err_recovery_lock);return -EAGAIN ; }pthread_mutex_unlock (&bp->err_recovery_lock);
@@ -1497,6 +1498,7 @@ static int bnxt_dev_close_op(struct rte_eth_dev *eth_dev)if (bp->flags &BNXT_FLAG_FW_RESET ) {PMD_DRV_LOG (ERR ,"Adapter recovering from error...Please retry\n" ); +pthread_mutex_unlock (&bp->err_recovery_lock);return -EAGAIN ; }pthread_mutex_unlock (&bp->err_recovery_lock);
Signature · 1 line
2.21.1 (Apple Git-122.3)
Re: [dpdk-dev] [PATCH v3] net/bnxt: fix lock handling in stop and close
Quoted 9 lines · Ajit Khaparde
From: Somnath Kotur <[email protected]>
err_recovery_lockneeds to be released before returning in stop andclose_opifFW_RESETflag is set.Fixes dd3613560573 ("net/bnxt: check chip reset in dev stop and close")Signed-off-by Somnath Kotur <[email protected]>Reviewed-by Ajit Khaparde <[email protected]>
Patch applied to dpdk-next-net-brcm.
Quoted 30 lines
---
v1->v2: rebased to latest dpdk-next-net and updated commit log.v2->v3: rebased to latest dpdk-next-net.--- drivers/net/bnxt/bnxt_ethdev.c | 2 ++ 1 file changed, 2 insertions(+)drivers/net/bnxt/bnxt_ethdev.c +2
-1@@ -1374,6 +1374,7 @@ static int bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)if (bp->flags &BNXT_FLAG_FW_RESET ) {PMD_DRV_LOG (ERR ,"Adapter recovering from error..Please retry\n" ); +pthread_mutex_unlock (&bp->err_recovery_lock);return -EAGAIN ; }pthread_mutex_unlock (&bp->err_recovery_lock);@@ -1497,6 +1498,7 @@ static int bnxt_dev_close_op(struct rte_eth_dev *eth_dev)if (bp->flags &BNXT_FLAG_FW_RESET ) {PMD_DRV_LOG (ERR ,"Adapter recovering from error...Please retry\n" ); +pthread_mutex_unlock (&bp->err_recovery_lock);return -EAGAIN ; }pthread_mutex_unlock (&bp->err_recovery_lock); --2.21.1 (Apple Git-122.3)