X.509: Fix crash caused by NULL pointer
Subsystems (3)
PATCH 1/1 X.509: Fix crash caused by NULL pointer
From: Tianjia Zhang <[email protected]>
On the following call path, sig->pkey_algo is not assigned in asymmetric_key_verify_signature(), which causes runtime crash in public_key_verify_signature().
keyctl_pkey_verify
asymmetric_key_verify_signature
verify_signature
public_key_verify_signature
This patch simply check this situation and fixes the crash caused by NULL pointer.
Fixes 215525639631 ("X.509: support OSCCA SM2-with-SM3 certificate verification")
Reported-by Tobias Markus <[email protected]>
Signed-off-by Tianjia Zhang <[email protected]>
Signed-off-by David Howells <[email protected]>
Reviewed-and-tested-by Toke Høiland-Jørgensen <[email protected]>
Tested-by João Fonseca <[email protected]>
Acked-by Jarkko Sakkinen <[email protected]>
Cc [email protected] # v5.10+
Signed-off-by Linus Torvalds <[email protected]>
--- crypto/asymmetric_keys/public_key.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
crypto/asymmetric_keys/public_key.c +2 -1
@@ -356,7 +356,8 @@ int public_key_verify_signature(const struct public_key *pkey,if (ret) goto error_free_key; -if (strcmp (sig->pkey_algo,"sm2" ) ==0 && sig->data_size) { +if (sig->pkey_algo &&strcmp (sig->pkey_algo,"sm2" ) ==0 && + sig->data_size) { ret =cert_sig_digest_update (sig, tfm);if (ret) goto error_free_key;
Signature · 1 line
2.29.2