Skip to contentSkip to conversation

arch/Kconfig: update a broken file reference

PATCH In review Lukas Bulwahn 3 participants 3 messages Jan 19, 2021 – Jan 21, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arch/Kconfig: update a broken file reference

Commit adab66b71abf ("Revert: "ring-buffer: Remove HAVE_64BIT_ALIGNED_ACCESS"") added the config HAVE_64BIT_ALIGNED_ACCESS back into arch/Kconfig with this revert. In the meantime, commit c9b54d6f362c ("docs: move other kAPI documents to core-api") changed ./Documentation/unaligned-memory-access.txt to ./Documentation/core-api/unaligned-memory-access.rst.

Fortunately, ./scripts/documentation-file-ref-check detects this and warns about this broken reference.

Update the file reference in arch/Kconfig.

Fixes adab66b71abf ("Revert: "ring-buffer: Remove HAVE_64BIT_ALIGNED_ACCESS"")

---
applies cleanly on current master and next-20210118

Steven, could you pick this fix to your commit or, at least, ack it so that Jonathan can pick it?

 arch/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/Kconfig +2 -2
index 24862d15f3a3..dc104b8270c0 100644
@@ -156,8 +156,8 @@ config HAVE_64BIT_ALIGNED_ACCESS
 	  accesses are required to be 64 bit aligned in this way even
 	  though it is not a 64 bit architecture.
 
-	  See Documentation/unaligned-memory-access.txt for more
-	  information on the topic of unaligned memory accesses.
+	  See Documentation/core-api/unaligned-memory-access.rst for
+	  more information on the topic of unaligned memory accesses.
 
 config HAVE_EFFICIENT_UNALIGNED_ACCESS
 	bool
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 11 lines · On Tue, 19 Jan 2021 10:53:26 +0100 Lukas Bulwahn <[email protected]>…

Commit adab66b71abf ("Revert: "ring-buffer: Remove HAVE_64BIT_ALIGNED_ACCESS"") added the config HAVE_64BIT_ALIGNED_ACCESS back into arch/Kconfig with this revert. In the meantime, commit c9b54d6f362c ("docs: move other kAPI documents to core-api") changed ./Documentation/unaligned-memory-access.txt to ./Documentation/core-api/unaligned-memory-access.rst.

Fortunately, ./scripts/documentation-file-ref-check detects this and warns about this broken reference.

Update the file reference in arch/Kconfig.

Quoted 7 lines
Fixes adab66b71abf ("Revert: "ring-buffer: Remove HAVE_64BIT_ALIGNED_ACCESS"")

---
applies cleanly on current master and next-20210118

Steven, could you pick this fix to your commit or, at least, ack it so that Jonathan can pick it?

I've gone ahead and applied it, thanks.

jon

#2 lore raw
Quoted 19 lines · On Thu, 21 Jan 2021 11:44:58 -0700 Jonathan Corbet <[email protected]> wrote:
Quoted 16 lines · On Tue, 19 Jan 2021 10:53:26 +0100 Lukas Bulwahn <[email protected]>…

Commit adab66b71abf ("Revert: "ring-buffer: Remove HAVE_64BIT_ALIGNED_ACCESS"") added the config HAVE_64BIT_ALIGNED_ACCESS back into arch/Kconfig with this revert. In the meantime, commit c9b54d6f362c ("docs: move other kAPI documents to core-api") changed ./Documentation/unaligned-memory-access.txt to ./Documentation/core-api/unaligned-memory-access.rst.

Fortunately, ./scripts/documentation-file-ref-check detects this and warns about this broken reference.

Update the file reference in arch/Kconfig.

Fixes adab66b71abf ("Revert: "ring-buffer: Remove HAVE_64BIT_ALIGNED_ACCESS"")

---
applies cleanly on current master and next-20210118

Quoted 4 lines
Quoted 2 lines

Steven, could you pick this fix to your commit or, at least, ack it so that Jonathan can pick it?

I've gone ahead and applied it, thanks.

Thanks Jon!

-- Steve