Skip to contentSkip to conversation

s390: uv: small UV fixes

PATCH In review Janosch Frank 3 participants 5 messages Jan 21, 2021 – Jan 22, 2021

Subsystems (4)
lore
Share & tools
lore

Janosch Frank

author maintainer
#0 lore raw

v2 cover s390: uv: small UV fixes

Two small fixes:
* Handle 3d PGMs where the address space id is not known
* Clean up the UV query VCPU number field naming (it's N-1 not N as number in this context means ID)

v2:
* Renamed the struct member from max_guest_cpu to max_guest_cpu_id
* Improved a comment text

Janosch Frank (2):
s390: uv: Fix sysfs max number of VCPUs reporting
s390: mm: Fix secure storage access exception handling

 arch/s390/boot/uv.c        |  2 +-
 arch/s390/include/asm/uv.h |  4 ++--
 arch/s390/kernel/uv.c      |  2 +-
 arch/s390/mm/fault.c       | 14 ++++++++++++++
 4 files changed, 18 insertions(+), 4 deletions(-)
Signature · 1 line
2.25.1
author maintainer
#1 lore raw

PATCH v2 1/2 s390: uv: Fix sysfs max number of VCPUs reporting

The number reported by the query is N-1 and I think people reading the sysfs file would expect N instead. For users creating VMs there's no actual difference because KVM's limit is currently below the UV's limit.

Fixes a0f60f8431999 ("s390/protvirt: Add sysfs firmware interface for Ultravisor information")
---
 arch/s390/boot/uv.c        | 2 +-
 arch/s390/include/asm/uv.h | 4 ++--
 arch/s390/kernel/uv.c      | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)
arch/s390/boot/uv.c +1 -1
index a15c033f53ca..87641dd65ccf 100644
@@ -35,7 +35,7 @@ void uv_query_info(void)
 		uv_info.guest_cpu_stor_len = uvcb.cpu_stor_len;
 		uv_info.max_sec_stor_addr = ALIGN(uvcb.max_guest_stor_addr, PAGE_SIZE);
 		uv_info.max_num_sec_conf = uvcb.max_num_sec_conf;
-		uv_info.max_guest_cpus = uvcb.max_guest_cpus;
+		uv_info.max_guest_cpu_id = uvcb.max_guest_cpu_id;
 	}
 
 #ifdef CONFIG_PROTECTED_VIRTUALIZATION_GUEST
arch/s390/include/asm/uv.h +2 -2
index 0325fc0469b7..7b98d4caee77 100644
@@ -96,7 +96,7 @@ struct uv_cb_qui {
 	u32 max_num_sec_conf;
 	u64 max_guest_stor_addr;
 	u8  reserved88[158 - 136];
-	u16 max_guest_cpus;
+	u16 max_guest_cpu_id;
 	u8  reserveda0[200 - 160];
 } __packed __aligned(8);
 
@@ -273,7 +273,7 @@ struct uv_info {
 	unsigned long guest_cpu_stor_len;
 	unsigned long max_sec_stor_addr;
 	unsigned int max_num_sec_conf;
-	unsigned short max_guest_cpus;
+	unsigned short max_guest_cpu_id;
 };
 
 extern struct uv_info uv_info;
arch/s390/kernel/uv.c +1 -1
index 883bfed9f5c2..b2d2ad153067 100644
@@ -368,7 +368,7 @@ static ssize_t uv_query_max_guest_cpus(struct kobject *kobj,
 				       struct kobj_attribute *attr, char *page)
 {
 	return scnprintf(page, PAGE_SIZE, "%d\n",
-			uv_info.max_guest_cpus);
+			uv_info.max_guest_cpu_id + 1);
 }
 
 static struct kobj_attribute uv_query_max_guest_cpus_attr =
Signature · 1 line
2.25.1
author maintainer
#2 lore raw

PATCH v2 2/2 s390: mm: Fix secure storage access exception handling

In reply to Janosch Frank

Turns out that the bit 61 in the TEID is not always 1 and if that's the case the address space ID and the address are unpredictable. Without an address and its address space ID we can't export memory and hence we can only send a SIGSEGV to the process or panic the kernel depending on who caused the exception.

Fixes 084ea4d611a3d ("s390/mm: add (non)secure page access exceptions handlers")
---
 arch/s390/mm/fault.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/s390/mm/fault.c +14 -0
index e30c7c781172..3e8685ad938d 100644
@@ -791,6 +791,20 @@ void do_secure_storage_access(struct pt_regs *regs)
 	struct page *page;
 	int rc;
 
+	/* There are cases where we don't have a TEID. */
+	if (!(regs->int_parm_long & 0x4)) {
+		/*
+		 * When this happens, userspace did something that it
+		 * was not supposed to do, e.g. branching into secure
+		 * memory. Trigger a segmentation fault.
+		 */
+		if (user_mode(regs)) {
+			send_sig(SIGSEGV, current, 0);
+			return;
+		} else
+			panic("Unexpected PGM 0x3d with TEID bit 61=0");
+	}
+
 	switch (get_fault_type(regs)) {
 	case USER_FAULT:
 		mm = current->mm;
Signature · 1 line
2.25.1
Reviewed-by on v2 2/2
#3 lore raw

Re: [PATCH v2 2/2] s390: mm: Fix secure storage access exception handling

Quoted 9 lines · Janosch Frank

Turns out that the bit 61 in the TEID is not always 1 and if that's the case the address space ID and the address are unpredictable. Without an address and its address space ID we can't export memory and hence we can only send a SIGSEGV to the process or panic the kernel depending on who caused the exception.

Fixes 084ea4d611a3d ("s390/mm: add (non)secure page access exceptions handlers")

we should let it run in our CI for some days, though.

Quoted 30 lines
---
 arch/s390/mm/fault.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/s390/mm/fault.c +14 -0
index e30c7c781172..3e8685ad938d 100644
@@ -791,6 +791,20 @@ void do_secure_storage_access(struct pt_regs *regs)
 	struct page *page;
 	int rc;
 
+	/* There are cases where we don't have a TEID. */
+	if (!(regs->int_parm_long & 0x4)) {
+		/*
+		 * When this happens, userspace did something that it
+		 * was not supposed to do, e.g. branching into secure
+		 * memory. Trigger a segmentation fault.
+		 */
+		if (user_mode(regs)) {
+			send_sig(SIGSEGV, current, 0);
+			return;
+		} else
+			panic("Unexpected PGM 0x3d with TEID bit 61=0");
+	}
+
 	switch (get_fault_type(regs)) {
 	case USER_FAULT:
 		mm = current->mm;
maintainer Reviewed-by on v2 2/2
#4 lore raw

Re: [PATCH v2 2/2] s390: mm: Fix secure storage access exception handling

In reply to Janosch Frank
Quoted 38 lines · On Thu, 21 Jan 2021 10:14:35 -0500 Janosch Frank <[email protected]> wrote:

Turns out that the bit 61 in the TEID is not always 1 and if that's the case the address space ID and the address are unpredictable. Without an address and its address space ID we can't export memory and hence we can only send a SIGSEGV to the process or panic the kernel depending on who caused the exception.

Fixes 084ea4d611a3d ("s390/mm: add (non)secure page access

exceptions handlers") Cc: [email protected]

---
 arch/s390/mm/fault.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/s390/mm/fault.c +14 -0
index e30c7c781172..3e8685ad938d 100644
@@ -791,6 +791,20 @@ void do_secure_storage_access(struct pt_regs
 *regs) struct page *page;
 	int rc;
 
+	/* There are cases where we don't have a TEID. */
+	if (!(regs->int_parm_long & 0x4)) {
+		/*
+		 * When this happens, userspace did something that it
+		 * was not supposed to do, e.g. branching into secure
+		 * memory. Trigger a segmentation fault.
+		 */
+		if (user_mode(regs)) {
+			send_sig(SIGSEGV, current, 0);
+			return;
+		} else
+			panic("Unexpected PGM 0x3d with TEID bit
 61=0");
+	}
+
 	switch (get_fault_type(regs)) {
 	case USER_FAULT:
Quoted 1 line

mm = current->mm;