drm/i915/dp: Don't use DPCD backlights that need PWM enable/disable
Subsystems (3)
PATCH 1/1 drm/i915/dp: Don't use DPCD backlights that need PWM enable/disable
We haven't yet implemented support for backlights that need to be enabled/disabled via PWM instead of AUX, which means we'll break things if we enable DPCD backlight control on these machines. Luckily though since most of these machines work fine just using the plain PWM backlight controls anyway, there shouldn't be any issue with just leaving DPCD backlight controls disabled in such situations.
This should fix the issues with PWM being left on that were being observed on fi-bdw-samus.
Testcase: igt/gem_exec_suspend/basic-s0 # fi-bdw-samus
Cc: Lyude Paul <[email protected]>
Cc: Jani Nikula <[email protected]>
Cc: "Ville Syrjälä" <[email protected]>
--- drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +6 -1
@@ -586,9 +586,14 @@ intel_dp_aux_supports_vesa_backlight(struct intel_connector *connector)struct drm_i915_private *i915 =dp_to_i915 (intel_dp);/* Check the eDP Display control capabilities registers to determine if -* the panel can support backlight control over the aux channel +* the panel can support backlight control over the aux channel. +* +* TODO: We currently only support AUX only backlight configurations, not backlights which +* require a mix of PWM and AUX controls to work. In the mean time, these machines typically +* work just fine using normal PWM controls anyway. */ if (intel_dp->edp_dpcd[1 ] &DP_EDP_TCON_BACKLIGHT_ADJUSTMENT_CAP && + (intel_dp->edp_dpcd[1 ] &DP_EDP_BACKLIGHT_AUX_ENABLE_CAP ) && (intel_dp->edp_dpcd[2 ] &DP_EDP_BACKLIGHT_BRIGHTNESS_AUX_SET_CAP )) {drm_dbg_kms (&i915->drm,"AUX Backlight Control Supported!\n" );return true;
Signature · 6 lines
2.29.2 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dp: Don't use DPCD backlights that need PWM enable/disable
== Series Details ==
== Series Details ==
Series: drm/i915/dp: Don't use DPCD backlights that need PWM enable/disable
URL : https://patchwork.freedesktop.org/series/86152/
State : failure
== Summary ==
Applying: drm/i915/dp: Don't use DPCD backlights that need PWM enable/disable Using index info to reconstruct a base tree...
M drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx