Skip to contentSkip to conversation

iio:adc:ti-ads124s08: Fix start stop conversion command

PATCH In review Dan Murphy 2 participants 4 messages Jan 21, 2021 – Jan 28, 2021 IIO

lore
Share & tools
lore

Dan Murphy

author
#0 lore raw

PATCH 1/2 iio:adc:ti-ads124s08: Fix start stop conversion command

Fix start and stop conversion commands. The proper command is not be sent.

Fixes ("e717f8c6dfec iio: adc: Add the TI ads124s08 ADC code")
---
 drivers/iio/adc/ti-ads124s08.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iio/adc/ti-ads124s08.c +2 -2
index b4a128b19188..f05d4e0e1c9d 100644
@@ -237,7 +237,7 @@ static int ads124s_read_raw(struct iio_dev *indio_dev,
 			goto out;
 		}
 
-		ret = ads124s_write_cmd(indio_dev, ADS124S08_START_CONV);
+		ret = ads124s_write_cmd(indio_dev, ADS124S08_CMD_START);
 		if (ret) {
 			dev_err(&priv->spi->dev, "Start conversions failed\n");
 			goto out;
@@ -251,7 +251,7 @@ static int ads124s_read_raw(struct iio_dev *indio_dev,
 
 		*val = ret;
 
-		ret = ads124s_write_cmd(indio_dev, ADS124S08_STOP_CONV);
+		ret = ads124s_write_cmd(indio_dev, ADS124S08_CMD_STOP);
 		if (ret) {
 			dev_err(&priv->spi->dev, "Stop conversions failed\n");
 			goto out;
Signature · 1 line
2.29.2
author
#1 lore raw

PATCH 2/2 iio:adc:ti-ads124s08: Fix packet read from the ADC

Fix the spi_transfer array in the reading of the data from the ADC.

Fixes ("e717f8c6dfec iio: adc: Add the TI ads124s08 ADC code")
---
 drivers/iio/adc/ti-ads124s08.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/adc/ti-ads124s08.c +1 -3
index f05d4e0e1c9d..023d81c7e8da 100644
@@ -201,12 +201,10 @@ static int ads124s_read(struct iio_dev *indio_dev, unsigned int chan)
 	struct spi_transfer t[] = {
 		{
 			.tx_buf = &priv->data[0],
-			.len = 4,
-			.cs_change = 1,
 		}, {
-			.tx_buf = &priv->data[1],
 			.rx_buf = &priv->data[1],
 			.len = 4,
+			.cs_change = 1,
 		},
 	};
 
Signature · 1 line
2.29.2
maintainer
#2 lore raw

Re: [PATCH 2/2] iio:adc:ti-ads124s08: Fix packet read from the ADC

Quoted 4 lines · On Thu, 21 Jan 2021 13:14:31 -0600 Dan Murphy <[email protected]> wrote:

Fix the spi_transfer array in the reading of the data from the ADC.

Fixes ("e717f8c6dfec iio: adc: Add the TI ads124s08 ADC code")

I'm not really following the changes below..

Quoted 9 lines
---
 drivers/iio/adc/ti-ads124s08.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/adc/ti-ads124s08.c +0 -0
index f05d4e0e1c9d..023d81c7e8da 100644

drivers/iio/adc/ti-ads124s08.c static int ads124s_read(struct iio_dev *indio_dev, unsigned int chan) · line 205

Quoted 5 lines
drivers/iio/adc/ti-ads124s08.c +0 -2
@@ -201,12 +201,10 @@ static int ads124s_read(struct iio_dev *indio_dev, unsigned int chan)
 	struct spi_transfer t[] = {
 		{
 			.tx_buf = &priv->data[0],
-			.len = 4,
-			.cs_change = 1,

We should still need to provide a length for this transfer.

drivers/iio/adc/ti-ads124s08.c static int ads124s_read(struct iio_dev *indio_dev, unsigned int chan) · line 207

Quoted 5 lines
drivers/iio/adc/ti-ads124s08.c +1 -1
 		}, {
-			.tx_buf = &priv->data[1],
 			.rx_buf = &priv->data[1],
 			.len = 4,
+			.cs_change = 1,

That's unusual... cs_change being set on the last transfer means the opposite of what it does for earlier transfers.

https://elixir.bootlin.com/linux/latest/source/include/linux/spi/spi.h#L905

Or is the intent here to provide a performance hint that the device doesn't care if the cs line goes inactive before stating a new set of transfers? If so add a comment to say that perhaps.

Quoted 3 lines
drivers/iio/adc/ti-ads124s08.c +0 -0
 		},
 	};
 
author
#3 lore raw

Re: [PATCH 2/2] iio:adc:ti-ads124s08: Fix packet read from the ADC

Jonathan

Quoted 8 lines · Jonathan Cameron
Quoted 4 lines · On Thu, 21 Jan 2021 13:14:31 -0600 Dan Murphy <[email protected]> wrote:

Fix the spi_transfer array in the reading of the data from the ADC.

Fixes ("e717f8c6dfec iio: adc: Add the TI ads124s08 ADC code")

I'm not really following the changes below..

I will have to dig into it deeper our HW team reported this.

Patch 1/2 is relevant and is not dependent on this patch

Dan