Skip to contentSkip to conversation

ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it

PATCH RESEND Applied Geert Uytterhoeven 3 participants 3 messages Jan 22, 2021 – Feb 12, 2021 ext4 file system

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it

EXT4_KUNIT_TESTS selects EXT4_FS, thus enabling an optional feature the user may not want to enable. Fix this by making the test depend on EXT4_FS instead.

Fixes 1cbeab1b242d16fd ("ext4: add kunit test for decoding extended timestamps")

---
Discussion after previous submission at
https://lore.kernel.org/linux-ext4/[email protected]/

---
 fs/ext4/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
fs/ext4/Kconfig +1 -2
index 619dd35ddd48a973..86699c8cab281cbc 100644
@@ -103,8 +103,7 @@ config EXT4_DEBUG
 
 config EXT4_KUNIT_TESTS
 	tristate "KUnit tests for ext4" if !KUNIT_ALL_TESTS
-	select EXT4_FS
-	depends on KUNIT
+	depends on EXT4_FS && KUNIT
 	default KUNIT_ALL_TESTS
 	help
 	  This builds the ext4 KUnit tests.
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Geert Uytterhoeven

EXT4_KUNIT_TESTS selects EXT4_FS, thus enabling an optional feature the user may not want to enable. Fix this by making the test depend on EXT4_FS instead.

Fixes 1cbeab1b242d16fd ("ext4: add kunit test for decoding extended timestamps")

Thanks.

Quoted 22 lines

---
Discussion after previous submission at
https://lore.kernel.org/linux-ext4/[email protected]/

---
 fs/ext4/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
fs/ext4/Kconfig +1 -2
index 619dd35ddd48a973..86699c8cab281cbc 100644
@@ -103,8 +103,7 @@ config EXT4_DEBUG
 
 config EXT4_KUNIT_TESTS
 	tristate "KUnit tests for ext4" if !KUNIT_ALL_TESTS
-	select EXT4_FS
-	depends on KUNIT
+	depends on EXT4_FS && KUNIT
 	default KUNIT_ALL_TESTS
 	help
 	  This builds the ext4 KUnit tests.
Signature · 1 line
~Randy