Skip to contentSkip to conversation

tests/amdgpu/vcn: clean abundant codes

PATCH In review Sonny Jiang 3 participants 3 messages Jan 22, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/amdgpu/vcn: clean abundant codes

Remove useless codes.

---
 tests/amdgpu/vcn_tests.c | 2 --
 1 file changed, 2 deletions(-)
tests/amdgpu/vcn_tests.c +0 -2
index 0f5b4241..1ca66297 100644
@@ -102,8 +102,6 @@ CU_BOOL suite_vcn_tests_enable(void)
 		return CU_FALSE;
 
 	family_id = device_handle->info.family_id;
-	chip_rev = device_handle->info.chip_rev;
-	chip_id = device_handle->info.chip_external_rev;
 	asic_id = device_handle->info.asic_id;
 	chip_rev = device_handle->info.chip_rev;
 	chip_id = device_handle->info.chip_external_rev;
Signature · 6 lines
2.25.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Reviewed-by on v1 1/1
#1 lore raw

Am 22.01.21 um 16:04 schrieb Sonny Jiang:

Quoted 3 lines

Remove useless codes.

Quoted 9 lines
---
  tests/amdgpu/vcn_tests.c | 2 --
  1 file changed, 2 deletions(-)
tests/amdgpu/vcn_tests.c +0 -0
index 0f5b4241..1ca66297 100644

tests/amdgpu/vcn_tests.c CU_BOOL suite_vcn_tests_enable(void) · line 107

Quoted 8 lines
tests/amdgpu/vcn_tests.c +0 -2
@@ -102,8 +102,6 @@ CU_BOOL suite_vcn_tests_enable(void)
  		return CU_FALSE;
 
  	family_id = device_handle->info.family_id;
-	chip_rev = device_handle->info.chip_rev;
-	chip_id = device_handle->info.chip_external_rev;
  	asic_id = device_handle->info.asic_id;
  	chip_rev = device_handle->info.chip_rev;
  	chip_id = device_handle->info.chip_external_rev;

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#2 lore raw
In reply to Sonny Jiang

Please open a libdrm MR for libdrm updates.

Alex

Quoted 24 lines · Sonny Jiang

Remove useless codes.

---
 tests/amdgpu/vcn_tests.c | 2 --
 1 file changed, 2 deletions(-)
tests/amdgpu/vcn_tests.c +0 -3
index 0f5b4241..1ca66297 100644
@@ -102,8 +102,6 @@ CU_BOOL suite_vcn_tests_enable(void)
                return CU_FALSE;
 
        family_id = device_handle->info.family_id;
-       chip_rev = device_handle->info.chip_rev;
-       chip_id = device_handle->info.chip_external_rev;
        asic_id = device_handle->info.asic_id;
        chip_rev = device_handle->info.chip_rev;
        chip_id = device_handle->info.chip_external_rev;
--

2.25.1

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx