Skip to contentSkip to conversation

gpio-uclass: fix gpio flags save condition

PATCH New Kory Maincent 2 participants 6 messages Jan 22, 2021 – Feb 6, 2021 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpio-uclass: fix gpio flags save condition

The commit cd2faeba1a moves the location where we save the flags to the gpio descriptor but it adds a "!" character.
This breaks the condition we expect to save the flags.

---
 drivers/gpio/gpio-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpio-uclass.c +1 -1
index 0c01413b58..39db89c004 100644
@@ -650,7 +650,7 @@ static int _dm_gpio_set_dir_flags(struct gpio_desc *desc, ulong flags)
 	}
 
 	/* save the flags also in descriptor */
-	if (!ret)
+	if (ret)
 		desc->flags = flags;
 
 	return ret;
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 gpio-uclass: fix gpio flags save condition

Hi Kory,

Quoted 10 lines · Kory Maincent

The commit cd2faeba1a moves the location where we save the flags to the gpio descriptor but it adds a "!" character.
This breaks the condition we expect to save the flags.

---
 drivers/gpio/gpio-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This does indeed seem to be a bug, and the tests do not cover it. But this happens to be fixed by my GPIO series. I'm about to send out v3 so will copy you on it.

Regards,
Simon

#2 lore raw

PATCH 1/1 gpio-uclass: fix gpio flags save condition

Hello Simon,

Quoted 14 lines · On Sun, 24 Jan 2021 13:24:14 -0700 Simon Glass <[email protected]> wrote:

Hi Kory,

Quoted 10 lines · Kory Maincent

The commit cd2faeba1a moves the location where we save the flags to the gpio descriptor but it adds a "!" character.
This breaks the condition we expect to save the flags.

---
 drivers/gpio/gpio-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 3 lines

This does indeed seem to be a bug, and the tests do not cover it. But this happens to be fixed by my GPIO series. I'm about to send out v3 so will copy you on it.

Thanks.

I have tested your series of patch and it seems to have also an issue with my use case.
I am working with w1-gpio.
I got this issue:
=> w1 bus
check_dir_flags: flags 0x16 has GPIOD_IS_OUT and GPIOD_IS_IN gpio_sunxi PD: PD error: set_dir_flags for gpio PD2 has invalid dir flags 0x16 Bus 0: onewire (active)

        w1_eeprom at 0 (0) uclass w1_eeprom : family 0x0

Regards,

K?ry

#3 lore raw

PATCH 1/1 gpio-uclass: fix gpio flags save condition

Hi K?ry,

Quoted 34 lines · K?ry Maincent

Hello Simon,

Quoted 14 lines · On Sun, 24 Jan 2021 13:24:14 -0700 Simon Glass <[email protected]> wrote:

Hi Kory,

Quoted 10 lines · Kory Maincent

The commit cd2faeba1a moves the location where we save the flags to the gpio descriptor but it adds a "!" character.
This breaks the condition we expect to save the flags.

---
 drivers/gpio/gpio-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 3 lines

This does indeed seem to be a bug, and the tests do not cover it. But this happens to be fixed by my GPIO series. I'm about to send out v3 so will copy you on it.

Thanks.

I have tested your series of patch and it seems to have also an issue with my use case.
I am working with w1-gpio.
I got this issue:
=> w1 bus
check_dir_flags: flags 0x16 has GPIOD_IS_OUT and GPIOD_IS_IN gpio_sunxi PD: PD error: set_dir_flags for gpio PD2 has invalid dir flags 0x16 Bus 0: onewire (active)

Quoted 1 line
        w1_eeprom at 0 (0) uclass w1_eeprom : family 0x0

Thank you for that. I think that is because dm_gpio_set_dir_flags() does not clear the flags first. But we now do actually update desc->flags, where as before it was just supposed to happen. So I think this function needs to update to clear the direction flags, then add in the ones passed.

I have pushed this to u-boot-dm/gpio-working if you can test it again.

Regards,
Simon

#4 lore raw

PATCH 1/1 gpio-uclass: fix gpio flags save condition

Hi Simon,

Quoted 7 lines · On Thu, 4 Feb 2021 19:45:22 -0700 Simon Glass <[email protected]> wrote:

Thank you for that. I think that is because dm_gpio_set_dir_flags() does not clear the flags first. But we now do actually update desc->flags, where as before it was just supposed to happen. So I think this function needs to update to clear the direction flags, then add in the ones passed.

I have pushed this to u-boot-dm/gpio-working if you can test it again.

I have tested your v4 series of patches and all works well for my onewire on gpio.
Thanks for your update.

Regards,
K?ry

#5 lore raw

PATCH 1/1 gpio-uclass: fix gpio flags save condition

Hi K?ry,

Quoted 13 lines · K?ry Maincent

Hi Simon,

Quoted 6 lines · On Thu, 4 Feb 2021 19:45:22 -0700 Simon Glass <[email protected]> wrote:

Thank you for that. I think that is because dm_gpio_set_dir_flags() does not clear the flags first. But we now do actually update desc->flags, where as before it was just supposed to happen. So I think this function needs to update to clear the direction flags, then add in the ones passed.

Quoted 5 lines
Quoted 1 line

I have pushed this to u-boot-dm/gpio-working if you can test it again.

I have tested your v4 series of patches and all works well for my onewire on gpio.
Thanks for your update.

Thank you. You could reply to the patches with your Tested-by tag if you like.

Regards,
Simon