Skip to contentSkip to conversation

w1: mxc: fix build

PATCH New Martin Fuzzey 3 participants 3 messages Jan 13, 2021 – Jan 23, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 w1: mxc: fix build

Now that header files no longer include common.h it must be included first.

Otherwise the build fails with errors like

	include/asm/arch/clock.h:43:1: error: unknown type name 'u32'
	 u32 imx_get_uartclk(void);
Fixes c3dc39a2f85b ("arm: Don't include common.h in header files")
---
 drivers/w1/mxc_w1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/w1/mxc_w1.c +1 -1
index 8e6372f..3aeaaf5 100644
@@ -17,8 +17,8 @@
  * Martin Fuzzey <[email protected]>
  */
 
-#include <asm/arch/clock.h>
 #include <common.h>
+#include <asm/arch/clock.h>
 #include <dm.h>
 #include <dm/device_compat.h>
 #include <linux/bitops.h>
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 w1: mxc: fix build

Quoted 8 lines · Martin Fuzzey

Now that header files no longer include common.h it must be included first.

Otherwise the build fails with errors like
include/asm/arch/clock.h:43:1: error: unknown type name 'u32'
u32 imx_get_uartclk(void);

Quoted 7 lines
Fixes c3dc39a2f85b ("arm: Don't include common.h in header files")
---
 drivers/w1/mxc_w1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
#2 lore raw

PATCH 1/1 w1: mxc: fix build

In reply to Martin Fuzzey
Quoted 8 lines

Now that header files no longer include common.h it must be included first.
Otherwise the build fails with errors like

	include/asm/arch/clock.h:43:1: error: unknown type name 'u32'
	 u32 imx_get_uartclk(void);
Fixes c3dc39a2f85b ("arm: Don't include common.h in header files")

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================