Skip to contentSkip to conversation

arm: dart6ul: fix ddr size macro

PATCH New ferlandm at amotus.ca 2 participants 2 messages Jan 4, 2021 – Jan 23, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: dart6ul: fix ddr size macro

From: Marc Ferland <[email protected]>

The previous macro was off by one bit and so we were getting a ddr size which was twice the real size. This commit refactors the macro so it returns the right size in _bytes_ and modifies the printf call so the size is still printed in MiB.

---
 board/variscite/dart_6ul/dart_6ul.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
board/variscite/dart_6ul/dart_6ul.c +2 -2
index 360be758bb..12e222e96e 100644
@@ -250,7 +250,7 @@ struct dart6ul_info {
 #define DART6UL_INFO_STORAGE_GET(n) ((n) & 0x3)
 #define DART6UL_INFO_WIFI_GET(n)    ((n) >> 2 & 0x1)
 #define DART6UL_INFO_REV_GET(n)     ((n) >> 3 & 0x3)
-#define DART6UL_DDRSIZE_IN_MIB(n)   ((n) << 8)
+#define DART6UL_DDRSIZE(n)          ((n) * SZ_128M)
 #define DART6UL_INFO_MAGIC          0x32524156
 
 static const char *som_info_storage_to_str(u8 som_info)
@@ -323,7 +323,7 @@ int checkboard(void)
 	       info->date,
 	       som_info_storage_to_str(info->som_info),
 	       DART6UL_INFO_WIFI_GET(info->som_info) ? "yes" : "no",
-	       DART6UL_DDRSIZE_IN_MIB(info->ddr_size),
+	       DART6UL_DDRSIZE(info->ddr_size) / SZ_1M,
 	       som_info_rev_to_str(info->som_info));
 
 	free(info);
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 arm: dart6ul: fix ddr size macro

Quoted 6 lines

From: Marc Ferland <[email protected]>
The previous macro was off by one bit and so we were getting a ddr size which was twice the real size. This commit refactors the macro so it returns the right size in _bytes_ and modifies the printf call so the size is still printed in MiB.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================