Skip to contentSkip to conversation

mx6ul(l)evk: Enable DM_ETH_PHY

PATCH New Sean Anderson 3 participants 3 messages Dec 28, 2020 – Jan 23, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mx6ul(l)evk: Enable DM_ETH_PHY

This fixes eth0 not initializing properly. Both eth0 and eth1 use the MDIO interface on eth1 to access their PHYs. However, without DM_ETH_PHY, eth0 still tries to use its own MDIO interface to access its phy. Before this patch, a boot log might contain lines like

Net:
Warning: ethernet at 20b4000 using MAC address from ROM
eth1: ethernet at 20b4000 [PRIME]Could not get PHY for FEC0: addr 2

After this patch they now look like

Net:
Warning: ethernet at 20b4000 using MAC address from ROM
eth1: ethernet at 20b4000 [PRIME]Get shared mii bus on ethernet at 2188000

Warning: ethernet at 2188000 using MAC address from ROM , eth0: ethernet at 2188000

As an alternative to DM_ETH_PHY, FEC_MXC_SHARE_MDIO could also have been used to achieve the same effect.

---

 configs/mx6ul_14x14_evk_defconfig         | 1 +
 configs/mx6ul_9x9_evk_defconfig           | 1 +
 configs/mx6ull_14x14_evk_defconfig        | 1 +
 configs/mx6ull_14x14_evk_plugin_defconfig | 1 +
 4 files changed, 4 insertions(+)
configs/mx6ul_14x14_evk_defconfig +1 -0
index f0a155aff3..5c3440f930 100644
@@ -68,6 +68,7 @@ CONFIG_PHYLIB=y
 CONFIG_PHY_MICREL=y
 CONFIG_PHY_MICREL_KSZ8XXX=y
 CONFIG_DM_ETH=y
+CONFIG_DM_ETH_PHY=y
 CONFIG_FEC_MXC=y
 CONFIG_MII=y
 CONFIG_PINCTRL=y
configs/mx6ul_9x9_evk_defconfig +1 -0
index 40bb371a69..86027d2d49 100644
@@ -61,6 +61,7 @@ CONFIG_PHYLIB=y
 CONFIG_PHY_MICREL=y
 CONFIG_PHY_MICREL_KSZ8XXX=y
 CONFIG_DM_ETH=y
+CONFIG_DM_ETH_PHY=y
 CONFIG_MII=y
 CONFIG_PINCTRL=y
 CONFIG_PINCTRL_IMX6=y
configs/mx6ull_14x14_evk_defconfig +1 -0
index 4fdbb915d4..fd33e0a4ef 100644
@@ -47,6 +47,7 @@ CONFIG_PHYLIB=y
 CONFIG_PHY_MICREL=y
 CONFIG_PHY_MICREL_KSZ8XXX=y
 CONFIG_DM_ETH=y
+CONFIG_DM_ETH_PHY=y
 CONFIG_FEC_MXC=y
 CONFIG_MII=y
 CONFIG_PINCTRL=y
configs/mx6ull_14x14_evk_plugin_defconfig +1 -0
index f8f863411e..f3f3fac9c1 100644
@@ -48,6 +48,7 @@ CONFIG_PHYLIB=y
 CONFIG_PHY_MICREL=y
 CONFIG_PHY_MICREL_KSZ8XXX=y
 CONFIG_DM_ETH=y
+CONFIG_DM_ETH_PHY=y
 CONFIG_FEC_MXC=y
 CONFIG_MII=y
 CONFIG_PINCTRL=y
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 mx6ul(l)evk: Enable DM_ETH_PHY

Hi Sean,

Quoted 16 lines · Sean Anderson

This fixes eth0 not initializing properly. Both eth0 and eth1 use the MDIO interface on eth1 to access their PHYs. However, without DM_ETH_PHY, eth0 still tries to use its own MDIO interface to access its phy. Before this patch, a boot log might contain lines like

Net:
Warning: ethernet at 20b4000 using MAC address from ROM
eth1: ethernet at 20b4000 [PRIME]Could not get PHY for FEC0: addr 2

After this patch they now look like

Net:
Warning: ethernet at 20b4000 using MAC address from ROM
eth1: ethernet at 20b4000 [PRIME]Get shared mii bus on ethernet at 2188000

Quoted 7 lines

Warning: ethernet at 2188000 using MAC address from ROM , eth0: ethernet at 2188000

As an alternative to DM_ETH_PHY, FEC_MXC_SHARE_MDIO could also have been used to achieve the same effect.

Thanks for the fix:

#2 lore raw

PATCH 1/1 mx6ul(l)evk: Enable DM_ETH_PHY

In reply to Sean Anderson
Quoted 15 lines

This fixes eth0 not initializing properly. Both eth0 and eth1 use the MDIO interface on eth1 to access their PHYs. However, without DM_ETH_PHY, eth0 still tries to use its own MDIO interface to access its phy. Before this patch, a boot log might contain lines like Net:
Warning: ethernet at 20b4000 using MAC address from ROM
eth1: ethernet at 20b4000 [PRIME]Could not get PHY for FEC0: addr 2 After this patch they now look like
Net:
Warning: ethernet at 20b4000 using MAC address from ROM
eth1: ethernet at 20b4000 [PRIME]Get shared mii bus on ethernet at 2188000
Warning: ethernet at 2188000 using MAC address from ROM
, eth0: ethernet at 2188000
As an alternative to DM_ETH_PHY, FEC_MXC_SHARE_MDIO could also have been used to achieve the same effect.

Quoted 2 lines

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================