Skip to contentSkip to conversation

package/ssdp-responder: new package

PATCH Superseded Joachim Wiberg 2 participants 7 messages Jan 23, 2021 – Jan 24, 2021

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/ssdp-responder: new package

Small (35k), and stand-alone, SSDP responder with built-in web server (on port 1901) for serving description.xml when Windows scans for any network devices on the LAN. Also includes ssdp-scan (31k), similar to the mdns-scan tool, to probe for SSDP capable devices.

Verified with test-pkg, no-mmu builds disabled.

---
 DEVELOPERS                                 |  1 +
 package/Config.in                          |  1 +
 package/ssdp-responder/Config.in           | 20 +++++++++++
 package/ssdp-responder/S50ssdpd            | 42 ++++++++++++++++++++++
 package/ssdp-responder/ssdp-responder.hash |  3 ++
 package/ssdp-responder/ssdp-responder.mk   | 18 ++++++++++
 6 files changed, 85 insertions(+)
 create mode 100644 package/ssdp-responder/Config.in
 create mode 100755 package/ssdp-responder/S50ssdpd
 create mode 100644 package/ssdp-responder/ssdp-responder.hash
 create mode 100644 package/ssdp-responder/ssdp-responder.mk
DEVELOPERS +1 -0
index 687a9400e0..7af3081760 100644
@@ -1280,6 +1280,7 @@ F:	configs/globalscale_espressobin_defconfig
 F:	board/globalscale/espressobin/
 F:	package/mg/
 F:	package/netcalc/
+F:	package/ssdp-responder/
 
 N:	Joao Pinto <[email protected]>
 F:	board/synopsys/vdk/
package/Config.in +1 -0
index f42cc01032..12bd0608e3 100644
@@ -2268,6 +2268,7 @@ endif
 	source "package/spice/Config.in"
 	source "package/spice-protocol/Config.in"
 	source "package/squid/Config.in"
+	source "package/ssdp-responder/Config.in"
 	source "package/sshguard/Config.in"
 	source "package/sshpass/Config.in"
 	source "package/sslh/Config.in"
package/ssdp-responder/Config.in new file +20 -0
new file mode 100644
index 0000000000..d6d374256e
@@ -0,0 +1,20 @@
+config BR2_PACKAGE_SSDP_RESPONDER
+        bool "ssdp-responder"
+        depends on BR2_USE_MMU # fork()
+        help
+          Simple Service Discovery Protocol daemon (SSDP) for networked
+          Linux and UNIX devices. Useful in any setup, big or small, but
+          targeted more at embedded systems that need to announce
+          themselves to Windows systems.
+
+	  ssdpd is a stand-alone UNIX, no external dependencies but the
+	  standard C library.  It has a built-in web server for serving
+	  the UPnP XML description which Windows use to present the
+	  icon, by default an InternetGatewayDevice is announced.
+
+	  Also included is ssdp-scan, a tool similar to mdns-scan, which
+	  continuously scans for SSDP capable hosts on the network.
+	  Take care only to use for debugging since it scans the network
+	  quite aggressively.
+
+	  https://github.com/troglobit/ssdp-responder/
package/ssdp-responder/S50ssdpd new file +42 -0

42 lines not on this page · raw message

package/ssdp-responder/ssdp-responder.hash new file +3 -0
new file mode 100644
index 0000000000..e8cbbb4a1f
@@ -0,0 +1,3 @@
+# Locally calculated
+sha256  7ae49229e7c7a55fed9e36598b12e2173eecef0fffe0a386b6a10fad30f3c79f  ssdp-responder-1.8.tar.gz
+sha256  e17dc0bc91bf499d8cca5e016c22c6d2a4770e3cc1a43756a7973375a83ddb90  LICENSE
package/ssdp-responder/ssdp-responder.mk new file +18 -0
new file mode 100644
index 0000000000..ce057ee593
@@ -0,0 +1,18 @@
+################################################################################
+#
+# ssdp-responder
+#
+################################################################################
+
+SSDP_RESPONDER_VERSION = 1.8
+SSDP_RESPONDER_SITE = https://github.com/troglobit/ssdp-responder/releases/download/v$(SSDP_RESPONDER_VERSION)
+SSDP_RESPONDER_LICENSE = ISC
+SSDP_RESPONDER_LICENSE_FILES = LICENSE
+SSDP_RESPONDER_CPE_ID_VENDOR = troglobit
+
+define SSDP_RESPONDER_INSTALL_INIT_SYSV
+	$(INSTALL) -D -m 0755 package/ssdp-responder/S50ssdpd \
+		$(TARGET_DIR)/etc/init.d/S50ssdpd
+endef
+
+$(eval $(autotools-package))
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 package/ssdp-responder: new package

Joachim, All,

On 2021-01-24 00:15 +0100, Joachim Wiberg spake thusly:

Quoted 4 lines

Small (35k), and stand-alone, SSDP responder with built-in web server (on port 1901) for serving description.xml when Windows scans for any network devices on the LAN. Also includes ssdp-scan (31k), similar to the mdns-scan tool, to probe for SSDP capable devices.

This package uses pkg-config, so it should have:

SSDP_RESPONDER_DEPENDENCIES = host-pkgconf

It also has an optional dependency on systemd, so maybe it needs:

    ifeq ($(BR2_PACKAGE_SYSTEMD),y)
    SSDP_RESPONDER_DEPENDENCIES += systemd
    SSDP_RESPONDER_CONF_OPTS += --with-systemd
    else
    SSDP_RESPONDER_CONF_OPTS += --without-systemd
    endif

And since it comes with its systemd service unit, it would be nice to install it with SSDP_RESPONDER_INSTALL_INIT_SYSTEMD.

[--SNIP--]

Quoted 6 lines
package/ssdp-responder/Config.in new file +0 -0
new file mode 100644
index 0000000000..d6d374256e

package/ssdp-responder/Config.in line 8

Quoted 8 lines
package/ssdp-responder/Config.in new file +8 -0
@@ -0,0 +1,20 @@
+config BR2_PACKAGE_SSDP_RESPONDER
+        bool "ssdp-responder"
+        depends on BR2_USE_MMU # fork()
+        help
+          Simple Service Discovery Protocol daemon (SSDP) for networked
+          Linux and UNIX devices. Useful in any setup, big or small, but
+          targeted more at embedded systems that need to announce
+          themselves to Windows systems.
    $ make check-package
    package/ssdp-responder/Config.in:2: should be indented with one tab (http://nightly.buildroot.org/#_config_files)
    package/ssdp-responder/Config.in:3: should be indented with one tab (http://nightly.buildroot.org/#_config_files)
    package/ssdp-responder/Config.in:4: should be indented with one tab (http://nightly.buildroot.org/#_config_files)
    package/ssdp-responder/Config.in:5: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)
    package/ssdp-responder/Config.in:6: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)
    package/ssdp-responder/Config.in:7: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)
    package/ssdp-responder/Config.in:8: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)

Care to fixup and respin, please?

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH v2 1/1 package/ssdp-responder: new package

Quoted 8 lines · Yann E. MORIN

On 2021-01-24 00:15 +0100, Joachim Wiberg spake thusly:

Quoted 4 lines

Small (35k), and stand-alone, SSDP responder with built-in web server (on port 1901) for serving description.xml when Windows scans for any network devices on the LAN. Also includes ssdp-scan (31k), similar to the mdns-scan tool, to probe for SSDP capable devices.

This package uses pkg-config, so it should have:

SSDP_RESPONDER_DEPENDENCIES = host-pkgconf

Noted!

Quoted 7 lines

It also has an optional dependency on systemd, so maybe it needs:

    ifeq ($(BR2_PACKAGE_SYSTEMD),y)
    SSDP_RESPONDER_DEPENDENCIES += systemd
    SSDP_RESPONDER_CONF_OPTS += --with-systemd
    else
    SSDP_RESPONDER_CONF_OPTS += --without-systemd
    endif

Thanks, I'll give it a whirl.

Quoted 2 lines

And since it comes with its systemd service unit, it would be nice to install it with SSDP_RESPONDER_INSTALL_INIT_SYSTEMD.

OK

Quoted 2 lines

[--SNIP--]

    $ make check-package

(This will be my new friend)

Quoted 8 lines

package/ssdp-responder/Config.in:2: should be indented with one tab (http://nightly.buildroot.org/#_config_files)
package/ssdp-responder/Config.in:3: should be indented with one tab (http://nightly.buildroot.org/#_config_files)
package/ssdp-responder/Config.in:4: should be indented with one tab (http://nightly.buildroot.org/#_config_files)
package/ssdp-responder/Config.in:5: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)
package/ssdp-responder/Config.in:6: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)
package/ssdp-responder/Config.in:7: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)
package/ssdp-responder/Config.in:8: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)
Care to fixup and respin, please?

Yup, I'll post a v2 later tonight!

Cheers
/Joachim

#3 lore raw

v2 cover package/ssdp-responder: new package

In reply to Yann E. MORIN

Hi!

This is a respin of my first patch, with fixes to comments by Yann.

Changes v1 -> v2:
- Fix whitespace in ssdp-responder/Config.in
- Add host-pkg-config to build deps., used by package to check for systemd and create a unit file with correct paths from configure
- Package has native systemd unit file, add systemd to build deps., but only if systemd is enabled in buildroot
- Use _INSTALL_INIT_SYSTEMD to install unit file

Regards
/Joachim

Joachim Wiberg (1):
package/ssdp-responder: new package

 DEVELOPERS                                 |  1 +
 package/Config.in                          |  1 +
 package/ssdp-responder/Config.in           | 20 +++++++++++
 package/ssdp-responder/S50ssdpd            | 42 ++++++++++++++++++++++
 package/ssdp-responder/ssdp-responder.hash |  3 ++
 package/ssdp-responder/ssdp-responder.mk   | 31 ++++++++++++++++
 6 files changed, 98 insertions(+)
 create mode 100644 package/ssdp-responder/Config.in
 create mode 100755 package/ssdp-responder/S50ssdpd
 create mode 100644 package/ssdp-responder/ssdp-responder.hash
 create mode 100644 package/ssdp-responder/ssdp-responder.mk
Signature · 1 line
2.25.1
#4 lore raw

PATCH v2 1/1 package/ssdp-responder: new package

Small (35k), and stand-alone, SSDP responder with built-in web server (on port 1901) for serving description.xml when Windows scans for any network devices on the LAN. Also includes ssdp-scan (31k), similar to the mdns-scan tool, to probe for SSDP capable devices.

Verified with check-package and test-pkg, no-mmu builds disabled.

---
 DEVELOPERS                                 |  1 +
 package/Config.in                          |  1 +
 package/ssdp-responder/Config.in           | 20 +++++++++++
 package/ssdp-responder/S50ssdpd            | 42 ++++++++++++++++++++++
 package/ssdp-responder/ssdp-responder.hash |  3 ++
 package/ssdp-responder/ssdp-responder.mk   | 31 ++++++++++++++++
 6 files changed, 98 insertions(+)
 create mode 100644 package/ssdp-responder/Config.in
 create mode 100755 package/ssdp-responder/S50ssdpd
 create mode 100644 package/ssdp-responder/ssdp-responder.hash
 create mode 100644 package/ssdp-responder/ssdp-responder.mk
DEVELOPERS +1 -0
index 687a9400e0..7af3081760 100644
@@ -1280,6 +1280,7 @@ F:	configs/globalscale_espressobin_defconfig
 F:	board/globalscale/espressobin/
 F:	package/mg/
 F:	package/netcalc/
+F:	package/ssdp-responder/
 
 N:	Joao Pinto <[email protected]>
 F:	board/synopsys/vdk/
package/Config.in +1 -0
index f42cc01032..12bd0608e3 100644
@@ -2268,6 +2268,7 @@ endif
 	source "package/spice/Config.in"
 	source "package/spice-protocol/Config.in"
 	source "package/squid/Config.in"
+	source "package/ssdp-responder/Config.in"
 	source "package/sshguard/Config.in"
 	source "package/sshpass/Config.in"
 	source "package/sslh/Config.in"
package/ssdp-responder/Config.in new file +20 -0
new file mode 100644
index 0000000000..7e9cd640c7
@@ -0,0 +1,20 @@
+config BR2_PACKAGE_SSDP_RESPONDER
+	bool "ssdp-responder"
+	depends on BR2_USE_MMU # fork()
+	help
+	  Simple Service Discovery Protocol daemon (SSDP) for networked
+	  Linux and UNIX devices. Useful in any setup, big or small, but
+	  targeted more at embedded systems that need to announce
+	  themselves to Windows systems.
+
+	  ssdpd is a stand-alone UNIX, no external dependencies but the
+	  standard C library.  It has a built-in web server for serving
+	  the UPnP XML description which Windows use to present the
+	  icon, by default an InternetGatewayDevice is announced.
+
+	  Also included is ssdp-scan, a tool similar to mdns-scan, which
+	  continuously scans for SSDP capable hosts on the network.
+	  Take care only to use for debugging since it scans the network
+	  quite aggressively.
+
+	  https://github.com/troglobit/ssdp-responder/
package/ssdp-responder/S50ssdpd new file +42 -0

42 lines not on this page · raw message

package/ssdp-responder/ssdp-responder.hash new file +3 -0
new file mode 100644
index 0000000000..e8cbbb4a1f
@@ -0,0 +1,3 @@
+# Locally calculated
+sha256  7ae49229e7c7a55fed9e36598b12e2173eecef0fffe0a386b6a10fad30f3c79f  ssdp-responder-1.8.tar.gz
+sha256  e17dc0bc91bf499d8cca5e016c22c6d2a4770e3cc1a43756a7973375a83ddb90  LICENSE
package/ssdp-responder/ssdp-responder.mk new file +31 -0
new file mode 100644
index 0000000000..f2478e99b1
@@ -0,0 +1,31 @@
+################################################################################
+#
+# ssdp-responder
+#
+################################################################################
+
+SSDP_RESPONDER_VERSION = 1.8
+SSDP_RESPONDER_SITE = https://github.com/troglobit/ssdp-responder/releases/download/v$(SSDP_RESPONDER_VERSION)
+SSDP_RESPONDER_LICENSE = ISC
+SSDP_RESPONDER_LICENSE_FILES = LICENSE
+SSDP_RESPONDER_CPE_ID_VENDOR = troglobit
+SSDP_RESPONDER_DEPENDENCIES = host-pkgconf
+
+ifeq ($(BR2_PACKAGE_SYSTEMD),y)
+SSDP_RESPONDER_DEPENDENCIES += systemd
+SSDP_RESPONDER_CONF_OPTS += --with-systemd
+else
+SSDP_RESPONDER_CONF_OPTS += --without-systemd
+endif
+
+define SSDP_RESPONDER_INSTALL_INIT_SYSV
+	$(INSTALL) -D -m 0755 package/ssdp-responder/S50ssdpd \
+		$(TARGET_DIR)/etc/init.d/S50ssdpd
+endef
+
+define SSDP-RESPONDER_INSTALL_INIT_SYSTEMD
+	$(INSTALL) -D -m 644 $(@D)/ssdp-responder.service \
+		$(TARGET_DIR)/usr/lib/systemd/system/ssdp-responder.service
+endef
+
+$(eval $(autotools-package))
Signature · 1 line
2.25.1
#5 lore raw

PATCH v2 1/1 package/ssdp-responder: new package

Joachim, All,

On 2021-01-24 20:49 +0100, Joachim Wiberg spake thusly:

Quoted 6 lines

Small (35k), and stand-alone, SSDP responder with built-in web server (on port 1901) for serving description.xml when Windows scans for any network devices on the LAN. Also includes ssdp-scan (31k), similar to the mdns-scan tool, to probe for SSDP capable devices.

Verified with check-package and test-pkg, no-mmu builds disabled.

I've done a bit of research as to why noMMU builds were broken.

Initially, you stated:

package/ssdp-responder/Config.in line 3

Quoted 1 line
package/ssdp-responder/Config.in new file +1 -0
+	depends on BR2_USE_MMU # fork()

However, ssdp-responder does not use fork().

So I was a bit surprised, and spawned a test build, and indeed it fails, but for very obscur reasons. In that situation, a lot of functions, even very basic ones, like strdup(), do not get prototyped, and a lot of multicast-related structs, like struct ip_mreq, do not get defined.

I tried to dig the root cause, but I lost too much hair, so I bailed out and comitted your patch as is, just with the fork() reference dropped.

Applied to master, thanks.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#6 lore raw

PATCH v2 1/1 package/ssdp-responder: new package

Hi Yann,

Quoted 6 lines · Yann E. MORIN

On 2021-01-24 20:49 +0100, Joachim Wiberg spake thusly:

Quoted 1 line

Verified with check-package and test-pkg, no-mmu builds disabled.

I've done a bit of research as to why noMMU builds were broken. Initially, you stated:

package/ssdp-responder/Config.in line 3

Quoted 1 line
package/ssdp-responder/Config.in new file +1 -0
+	depends on BR2_USE_MMU # fork()

However, ssdp-responder does not use fork().

It's hidden in daemon(3), sneaky.

Quoted 4 lines

So I was a bit surprised, and spawned a test build, and indeed it fails, but for very obscur reasons. In that situation, a lot of functions, even very basic ones, like strdup(), do not get prototyped, and a lot of multicast-related structs, like struct ip_mreq, do not get defined.

Mmm, spent quite a bit of time myself trying to figure that one out.

Quoted 2 lines

I tried to dig the root cause, but I lost too much hair, so I bailed out and comitted your patch as is, just with the fork() reference dropped.

Heh ;)

Yeah, seeing as I'm the maintainer of the upstream project, I suspect I'll spend some time later trying to figure this one out. Because it's a quite useful little daemon to help locate your embedded device. Some replacement functions need to be implemented, of course, but nothing too hairy.

Quoted 1 line

Applied to master, thanks.

Thank you! :-)

Best regards
/Joachim