Skip to contentSkip to conversation

package/x11r7/{libxcb, xcb-proto}: use host-python3

PATCH New Titouan Christophe 2 participants 4 messages Jan 24, 2021

lore
Share & tools
lore
#0 lore raw

cover package/x11r7/{libxcb, xcb-proto}: use host-python3

Building these packages with Python3 seems to be supported upstream for a few years now, so we can remove two more host-python(2) dependencies here.

Titouan Christophe (2):
package/x11r7/xcb-proto: use host-python3 instead of host-python(2) package/x11r7/libxcb: Use host-python3 instead of host-python(2)

 package/x11r7/libxcb/libxcb.mk       | 10 +++++-----
 package/x11r7/xcb-proto/xcb-proto.mk |  8 ++++++--
 2 files changed, 11 insertions(+), 7 deletions(-)
Signature · 1 line
2.25.3
#1 lore raw

PATCH 1/2 package/x11r7/xcb-proto: use host-python3 instead of host-python(2)

---
 package/x11r7/xcb-proto/xcb-proto.mk | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
package/x11r7/xcb-proto/xcb-proto.mk +6 -2
index 8bfe24f848..15da4be915 100644
@@ -12,8 +12,12 @@ XCB_PROTO_LICENSE_FILES = COPYING
 
 XCB_PROTO_INSTALL_STAGING = YES
 
-XCB_PROTO_DEPENDENCIES = host-python
-HOST_XCB_PROTO_DEPENDENCIES = host-python
+XCB_PROTO_DEPENDENCIES = host-python3
+HOST_XCB_PROTO_DEPENDENCIES = host-python3
+
+# Force detection of Buildroot host-python3 over system python
+HOST_XCB_PROTO_CONF_OPTS += ac_cv_path_PYTHON=$(HOST_DIR)/bin/python3
+XCB_PROTO_CONF_OPTS += ac_cv_path_PYTHON=$(HOST_DIR)/bin/python3
 
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))
Signature · 1 line
2.25.3
#2 lore raw

PATCH 2/2 package/x11r7/libxcb: Use host-python3 instead of host-python(2)

In reply to Titouan Christophe
---
 package/x11r7/libxcb/libxcb.mk | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
package/x11r7/libxcb/libxcb.mk +5 -5
index fb691c2422..fc209a2a1a 100644
@@ -14,17 +14,17 @@ LIBXCB_INSTALL_STAGING = YES
 
 LIBXCB_DEPENDENCIES = \
 	host-libxslt xcb-proto xlib_libXdmcp xlib_libXau \
-	host-xcb-proto host-python host-pkgconf
+	host-xcb-proto host-python3 host-pkgconf
 HOST_LIBXCB_DEPENDENCIES = \
 	host-libxslt host-xcb-proto host-xlib_libXdmcp \
-	host-xlib_libXau host-python host-pkgconf
+	host-xlib_libXau host-python3 host-pkgconf
 
 LIBXCB_CONF_OPTS = --with-doxygen=no
 HOST_LIBXCB_CONF_OPTS = --with-doxygen=no
 
-# libxcb is not python3 friendly, so force the python interpreter
-HOST_LIBXCB_CONF_OPTS += ac_cv_path_PYTHON=$(HOST_DIR)/bin/python2
-LIBXCB_CONF_OPTS += ac_cv_path_PYTHON=$(HOST_DIR)/bin/python2
+# Force detection of Buildroot host-python3 over system python
+HOST_LIBXCB_CONF_OPTS += ac_cv_path_PYTHON=$(HOST_DIR)/bin/python3
+LIBXCB_CONF_OPTS += ac_cv_path_PYTHON=$(HOST_DIR)/bin/python3
 
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))
Signature · 1 line
2.25.3
#3 lore raw

cover package/x11r7/{libxcb, xcb-proto}: use host-python3

In reply to Titouan Christophe

Titouan, All,

On 2021-01-24 11:57 +0100, Titouan Christophe spake thusly:

Quoted 6 lines

Building these packages with Python3 seems to be supported upstream for a few years now, so we can remove two more host-python(2) dependencies here.

Titouan Christophe (2):
package/x11r7/xcb-proto: use host-python3 instead of host-python(2) package/x11r7/libxcb: Use host-python3 instead of host-python(2)

Series of two applied to master, thanks.

I jsut reversed the order of the target vs. host variables; indeed we tradiotionally define the host-related variables after the target ones. Minor detail. ;-)

Thanks!

Regards,
Yann E. MORIN.

Quoted 11 lines
 package/x11r7/libxcb/libxcb.mk       | 10 +++++-----
 package/x11r7/xcb-proto/xcb-proto.mk |  8 ++++++--
 2 files changed, 11 insertions(+), 7 deletions(-)
Signature · 6 lines
2.25.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'