can: mcba_usb: remove h from printk format specifier
Subsystems (4)
PATCH 1/1 can: mcba_usb: remove h from printk format specifier
From: Tom Rix <[email protected]>
This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of
unnecessary %h[xudi] and %hh[xudi]")
Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi] or %h[xudi].
--- drivers/net/can/usb/mcba_usb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/can/usb/mcba_usb.c +3 -3
@@ -466,7 +466,7 @@ static void mcba_usb_process_ka_usb(struct mcba_priv *priv, struct mcba_usb_msg_ka_usb *msg) {if (unlikely (priv->usb_ka_first_pass)) { -netdev_info (priv->netdev,"PIC USB version %hhu.%hhu\n" , +netdev_info (priv->netdev,"PIC USB version %u.%u\n" , msg->soft_ver_major, msg->soft_ver_minor); priv->usb_ka_first_pass = false;
@@ -492,7 +492,7 @@ static void mcba_usb_process_ka_can(struct mcba_priv *priv, struct mcba_usb_msg_ka_can *msg) {if (unlikely (priv->can_ka_first_pass)) { -netdev_info (priv->netdev,"PIC CAN version %hhu.%hhu\n" , +netdev_info (priv->netdev,"PIC CAN version %u.%u\n" , msg->soft_ver_major, msg->soft_ver_minor); priv->can_ka_first_pass = false;
@@ -554,7 +554,7 @@ static void mcba_usb_process_rx(struct mcba_priv *priv,break ;default : -netdev_warn (priv->netdev,"Unsupported msg (0x%hhX)" , +netdev_warn (priv->netdev,"Unsupported msg (0x%X)" , msg->cmd_id);break ; }
Signature · 1 line
2.27.0
Marc Kleine-Budde
maintainerQuoted 10 lines · On 21-01-24 07:09:16, [email protected] wrote:
From: Tom Rix <[email protected]>
This change fixes the checkpatch warning described in this commit commit
cbacb5ab0aa0("docs: printk-formats: Stop encouraging use of
unnecessary %h[xudi] and %hh[xudi]")Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi] or %h[xudi].
Signed-off-by Tom Rix <[email protected]>
Added to linux-can-next/testing.
Thanks,
Marc
Signature · 4 lines
Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |