Skip to contentSkip to conversation

net/bridge/br_multicast_eht.c:88 br_multicast_eht_set_entry_lookup() warn: inconsistent indenting

PATCH Applied kernel test robot 3 participants 3 messages Jan 24, 2021 – Jan 27, 2021

Subsystems (3)
lore
Share & tools
lore

kernel test robot

author build bot
#0 lore raw
tree:   https://github.com/alaahl/linux.git netdev-next
head:   692347a93178a3635da13f41e29d40e3ee1b1808
commit: baa74d39ca39f2b22eeac5c3b069b58491ecd418 [485/514] net: bridge: multicast: add EHT source set handling functions
config: x86_64-randconfig-m001-20210124 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-20) 9.3.0

If you fix the issue, kindly add following tag as appropriate

smatch warnings:
net/bridge/br_multicast_eht.c:88 br_multicast_eht_set_entry_lookup() warn: inconsistent indenting

vim +88 net/bridge/br_multicast_eht.c

    77	
    78	static struct net_bridge_group_eht_set_entry *
    79	br_multicast_eht_set_entry_lookup(struct net_bridge_group_eht_set *eht_set,
    80					  union net_bridge_eht_addr *h_addr)
    81	{
    82		struct rb_node *node = eht_set->entry_tree.rb_node;
    83	
    84		while (node) {
    85			struct net_bridge_group_eht_set_entry *this;
    86			int result;
    87	
  > 88		this = rb_entry(node, struct net_bridge_group_eht_set_entry,
    89				rb_node);
    90		result = memcmp(h_addr, &this->h_addr, sizeof(*h_addr));
    91		if (result < 0)
    92			node = node->rb_left;
    93		else if (result > 0)
    94			node = node->rb_right;
    95		else
    96			return this;
    97		}
    98	
    99		return NULL;

100 }
101

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

#1 lore raw

PATCH 1/1 net: bridge: multicast: fix br_multicast_eht_set_entry_lookup indentation

From: Nikolay Aleksandrov <[email protected]>

Fix the messed up indentation in br_multicast_eht_set_entry_lookup().

Fixes baa74d39ca39 ("net: bridge: multicast: add EHT source set handling functions")
---
 net/bridge/br_multicast_eht.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
net/bridge/br_multicast_eht.c +9 -9
index a4fa1760bc8a..ff9b3ba37cab 100644
@@ -85,15 +85,15 @@ br_multicast_eht_set_entry_lookup(struct net_bridge_group_eht_set *eht_set,
 		struct net_bridge_group_eht_set_entry *this;
 		int result;
 
-	this = rb_entry(node, struct net_bridge_group_eht_set_entry,
-			rb_node);
-	result = memcmp(h_addr, &this->h_addr, sizeof(*h_addr));
-	if (result < 0)
-		node = node->rb_left;
-	else if (result > 0)
-		node = node->rb_right;
-	else
-		return this;
+		this = rb_entry(node, struct net_bridge_group_eht_set_entry,
+				rb_node);
+		result = memcmp(h_addr, &this->h_addr, sizeof(*h_addr));
+		if (result < 0)
+			node = node->rb_left;
+		else if (result > 0)
+			node = node->rb_right;
+		else
+			return this;
 	}
 
 	return NULL;
Signature · 1 line
2.29.2
#2 lore raw

Re: [PATCH net-next] net: bridge: multicast: fix br_multicast_eht_set_entry_lookup indentation

This patch was applied to netdev/net-next.git (refs/heads/master):

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

Quoted 9 lines · On Mon, 25 Jan 2021 10:20:40 +0200 you wrote:

From: Nikolay Aleksandrov <[email protected]>

Fix the messed up indentation in br_multicast_eht_set_entry_lookup().

Fixes baa74d39ca39 ("net: bridge: multicast: add EHT source set handling functions")

[...]

Here is the summary with links:
- [net-next] net: bridge: multicast: fix br_multicast_eht_set_entry_lookup indentation

    https://git.kernel.org/netdev/net-next/c/3e841bacf72f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html