PM: remove PF_WQ_WORKER mask
Subsystems (2)
PATCH 1/1 PM: remove PF_WQ_WORKER mask
From: Zqiang <[email protected]>
Due to kworker also is kernel thread, it's already included PF_KTHREAD mask, so remove PF_WQ_WORKER mask.
--- kernel/power/process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/power/process.c +1 -1
@@ -235,7 +235,7 @@ void thaw_kernel_threads(void)read_lock (&tasklist_lock);for_each_process_thread (g, p) { -if (p->flags & (PF_KTHREAD |PF_WQ_WORKER )) +if (p->flags &PF_KTHREAD )__thaw_task (p); }read_unlock (&tasklist_lock);
Signature · 1 line
2.17.1
________________________________________
发件人: Zhang, Qiang <[email protected]> 发送时间: 2021年1月25日 12:00
收件人: [email protected]
抄送: [email protected]; [email protected] 主题: [PATCH] PM: remove PF_WQ_WORKER mask
From: Zqiang <[email protected]>
Due to kworker also is kernel thread, it's already included PF_KTHREAD mask, so remove PF_WQ_WORKER mask.
--- kernel/power/process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/power/process.c +1 -1
@@ -235,7 +235,7 @@ void thaw_kernel_threads(void)read_lock (&tasklist_lock);for_each_process_thread (g, p) { -if (p->flags & (PF_KTHREAD |PF_WQ_WORKER )) +if (p->flags &PF_KTHREAD )__thaw_task (p); }read_unlock (&tasklist_lock);
--
2.17.1
Rafael J. Wysocki
maintainerQuoted 5 lines · On Mon, Jan 25, 2021 at 5:01 AM <[email protected]> wrote:
From: Zqiang <[email protected]>
Due to kworker also is kernel thread, it's already included
PF_KTHREADmask, so removePF_WQ_WORKERmask.
So you are saying that all threads having PF_WQ_WORKER set must also have PF_KTHREAD set, right?
That sounds correct, so I'm going to rewrite the changelog and apply the patch as 5.12 material, thanks!
Quoted 21 lines
Signed-off-by Zqiang <[email protected]>--- kernel/power/process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/power/process.c +1
-2@@ -235,7 +235,7 @@ void thaw_kernel_threads(void)read_lock (&tasklist_lock);for_each_process_thread (g, p) { -if (p->flags & (PF_KTHREAD |PF_WQ_WORKER )) +if (p->flags &PF_KTHREAD )__thaw_task (p); }read_unlock (&tasklist_lock); --2.17.1
________________________________________
发件人: Rafael J. Wysocki <[email protected]> 发送时间: 2021年1月28日 2:16
收件人: Zhang, Qiang
抄送: Rafael Wysocki; Linux PM; Linux Kernel Mailing List 主题: Re: [PATCH] PM: remove PF_WQ_WORKER mask
[Please note: This e-mail is from an EXTERNAL e-mail address]
Quoted 8 lines · On Mon, Jan 25, 2021 at 5:01 AM <[email protected]> wrote:
From: Zqiang <[email protected]>
Due to kworker also is kernel thread, it's already included
PF_KTHREADmask, so removePF_WQ_WORKERmask.So you are saying that all threads having
PF_WQ_WORKERset must also havePF_KTHREADset, right?
yes #define PF_KTHREAD 0x00200000 #define PF_WQ_WORKER 0x00000020 I tracing kwoker's task->flags as follows: comm kworker/1:0, cpu 1, task->flags 0x4208060, delayed 3, func intel_fbc_work_fn
Thanks
Qiang
Quoted 24 lines
That sounds correct, so I'm going to rewrite the changelog and apply the patch as 5.12 material, thanks!
Signed-off-by Zqiang <[email protected]>--- kernel/power/process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/power/process.c +1
-2@@ -235,7 +235,7 @@ void thaw_kernel_threads(void)read_lock (&tasklist_lock);for_each_process_thread (g, p) { -if (p->flags & (PF_KTHREAD |PF_WQ_WORKER )) +if (p->flags &PF_KTHREAD )__thaw_task (p); }read_unlock (&tasklist_lock); --2.17.1