Skip to contentSkip to conversation

ALSA: hda: intel-dsp-config: add PCI id for TGL-H

PATCH In review Kai Vehmanen 3 participants 5 messages Jan 25, 2021 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: hda: intel-dsp-config: add PCI id for TGL-H

From: Bard Liao <[email protected]>

Adding PCI id for TGL-H. Like for other TGL platforms, SOF is used if Soundwire codecs or PCH-DMIC is detected.

---
 sound/hda/intel-dsp-config.c | 4 ++++
 1 file changed, 4 insertions(+)
sound/hda/intel-dsp-config.c +4 -0
index 6a0d070c60c9..c45686172517 100644
@@ -307,6 +307,10 @@ static const struct config_entry config_table[] = {
 		.flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE,
 		.device = 0xa0c8,
 	},
+	{
+		.flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE,
+		.device = 0x43c8,
+	},
 #endif
 
 /* Elkhart Lake */
Signature · 1 line
2.29.2
#1 lore raw
Quoted 10 lines · Kai Vehmanen

From: Bard Liao <[email protected]>

Adding PCI id for TGL-H. Like for other TGL platforms, SOF is used if Soundwire codecs or PCH-DMIC is detected.

Is this needed for 5.11 or only for 5.12?
(Or potentially needed for 5.11.x stable later? -- then we can take it
now, too)

thanks,

Takashi

Quoted 22 lines
---
 sound/hda/intel-dsp-config.c | 4 ++++
 1 file changed, 4 insertions(+)
sound/hda/intel-dsp-config.c +4 -0
index 6a0d070c60c9..c45686172517 100644
@@ -307,6 +307,10 @@ static const struct config_entry config_table[] = {
 		.flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE,
 		.device = 0xa0c8,
 	},
+	{
+		.flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE,
+		.device = 0x43c8,
+	},
 #endif
 
 /* Elkhart Lake */
Signature · 1 line
2.29.2
maintainer
#2 lore raw

Dne 25. 01. 21 v 9:49 Takashi Iwai napsal(a):

Quoted 8 lines
Quoted 6 lines · Kai Vehmanen

From: Bard Liao <[email protected]>

Adding PCI id for TGL-H. Like for other TGL platforms, SOF is used if Soundwire codecs or PCH-DMIC is detected.

Quoted 8 lines
Quoted 4 lines

Is this needed for 5.11 or only for 5.12?
(Or potentially needed for 5.11.x stable later? -- then we can take it
now, too)

All patches sent by Kai today are required to add support for the SoundWire device Dell TGL-H SKU 0A5E in 5.11. But I think that this standalone patch may enable the DMIC only platforms.

Jaroslav

Signature · 2 lines
Jaroslav Kysela <[email protected]>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
#3 lore raw

Hi,

Quoted 7 lines · Jaroslav Kysela

Dne 25. 01. 21 v 9:49 Takashi Iwai napsal(a):

Quoted 2 lines

Is this needed for 5.11 or only for 5.12?
(Or potentially needed for 5.11.x stable later? -- then we can take it

All patches sent by Kai today are required to add support for the SoundWire device Dell TGL-H SKU 0A5E in 5.11. But I think that this standalone patch may enable the DMIC only platforms.

ack on that. We are a bit late for 5.11 with these patches, but the more we can get to 5.11, the better. 5.11-rc already has support for snd-hda-intel and baseline SOF support, but this single patch helps system with a PCH-DMIC.

The remaining patches sent via today ASoC, enable one Soundwire SKU.

Br, Kai

#4 lore raw
Quoted 9 lines · Kai Vehmanen

Hi,

Quoted 4 lines · Jaroslav Kysela

Dne 25. 01. 21 v 9:49 Takashi Iwai napsal(a):

Quoted 2 lines

Is this needed for 5.11 or only for 5.12?
(Or potentially needed for 5.11.x stable later? -- then we can take it

Quoted 8 lines
Quoted 3 lines

All patches sent by Kai today are required to add support for the SoundWire device Dell TGL-H SKU 0A5E in 5.11. But I think that this standalone patch may enable the DMIC only platforms.

ack on that. We are a bit late for 5.11 with these patches, but the more we can get to 5.11, the better. 5.11-rc already has support for snd-hda-intel and baseline SOF support, but this single patch helps system with a PCH-DMIC.

OK, now applied. Thanks.

Takashi