Skip to contentSkip to conversation

PCI: endpoint: Select configfs dependency

PATCH In review Arnd Bergmann 3 participants 3 messages Jan 26, 2021 – Mar 7, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI: endpoint: Select configfs dependency

From: Arnd Bergmann <[email protected]>

The newly added pci-epf-ntb driver uses configfs, which causes a link failure when that is disabled at compile-time:

arm-linux-gnueabi-ld: drivers/pci/endpoint/functions/pci-epf-ntb.o: in function `epf_ntb_add_cfs':
pci-epf-ntb.c:(.text+0x954): undefined reference to `config_group_init_type_name'

Add a 'select' statement to Kconfig to ensure it's always there, which is the common way to enable it for other configfs users.

Fixes 7dc64244f9e9 ("PCI: endpoint: Add EP function driver to provide NTB functionality")
---
 drivers/pci/endpoint/functions/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/pci/endpoint/functions/Kconfig +1 -0
index 24bfb2af65a1..5d35fcd613ef 100644
@@ -16,6 +16,7 @@ config PCI_EPF_TEST
 config PCI_EPF_NTB
 	tristate "PCI Endpoint NTB driver"
 	depends on PCI_ENDPOINT
+	select CONFIGFS_FS
 	help
 	  Select this configuration option to enable the NTB driver
 	  for PCI Endpoint. NTB driver implements NTB controller
Signature · 1 line
2.29.2
#1 lore raw

Hi Arnd, Lorenzo,

Quoted 5 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The newly added pci-epf-ntb driver uses configfs, which causes a link failure when that is disabled at compile-time:

Quoted 8 lines

arm-linux-gnueabi-ld: drivers/pci/endpoint/functions/pci-epf-ntb.o: in function `epf_ntb_add_cfs':
pci-epf-ntb.c:(.text+0x954): undefined reference to `config_group_init_type_name'

Add a 'select' statement to Kconfig to ensure it's always there, which is the common way to enable it for other configfs users.

Fixes 7dc64244f9e9 ("PCI: endpoint: Add EP function driver to provide NTB functionality")

Since I'm sending a new revision of NTB driver, I'll squash this patch with the driver patch and add Arnd's sign off.

Thank You,
Kishon

Quoted 17 lines
---
 drivers/pci/endpoint/functions/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/pci/endpoint/functions/Kconfig +1 -0
index 24bfb2af65a1..5d35fcd613ef 100644
@@ -16,6 +16,7 @@ config PCI_EPF_TEST
 config PCI_EPF_NTB
 	tristate "PCI Endpoint NTB driver"
 	depends on PCI_ENDPOINT
+	select CONFIGFS_FS
 	help
 	  Select this configuration option to enable the NTB driver
 	  for PCI Endpoint. NTB driver implements NTB controller
Reviewed-by on v1 1/1
#2 lore raw
In reply to Arnd Bergmann

Hi,

[...]

Quoted 5 lines

The newly added pci-epf-ntb driver uses configfs, which causes a link failure when that is disabled at compile-time:

arm-linux-gnueabi-ld: drivers/pci/endpoint/functions/pci-epf-ntb.o: in function `epf_ntb_add_cfs':
pci-epf-ntb.c:(.text+0x954): undefined reference to `config_group_init_type_name'

[...]

Thank you for fixing this!

Krzysztof