Skip to contentSkip to conversation

libmultipath: snprint_devices(): avoid NULL dereference

PATCH In review [email protected] 2 participants 2 messages Jan 25, 2021 Device mapper

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libmultipath: snprint_devices(): avoid NULL dereference

From: Martin Wilck <[email protected]>

All libudev functions may return NULL. Watch out for it.

Fixes d041258 ("libmultipath: snprint_devices(): use udev_enumerate"
---
 libmultipath/print.c | 8 ++++++++
 1 file changed, 8 insertions(+)
libmultipath/print.c +8 -0
index 19de2c7..8151e11 100644
@@ -2055,8 +2055,16 @@ int snprint_devices(struct config *conf, char *buff, size_t len,
 		struct udev_device *u_dev;
 
 		path = udev_list_entry_get_name(item);
+		if (!path)
+			continue;
 		u_dev = udev_device_new_from_syspath(udev, path);
+		if (!u_dev)
+			continue;
 		devname = udev_device_get_sysname(u_dev);
+		if (!devname) {
+			udev_device_unref(u_dev);
+			continue;
+		}
 
 		fwd += snprintf(buff + fwd, len - fwd, "    %s", devname);
 		if (fwd >= len)
Signature · 7 lines
2.29.2


--
dm-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/dm-devel
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · On Mon, Jan 25, 2021 at 04:23:04PM +0100, [email protected] wrote:

From: Martin Wilck <[email protected]>

All libudev functions may return NULL. Watch out for it.

Fixes d041258 ("libmultipath: snprint_devices(): use udev_enumerate"
Quoted 27 lines
---
 libmultipath/print.c | 8 ++++++++
 1 file changed, 8 insertions(+)
libmultipath/print.c +8 -0
index 19de2c7..8151e11 100644
@@ -2055,8 +2055,16 @@ int snprint_devices(struct config *conf, char *buff, size_t len,
 		struct udev_device *u_dev;
 
 		path = udev_list_entry_get_name(item);
+		if (!path)
+			continue;
 		u_dev = udev_device_new_from_syspath(udev, path);
+		if (!u_dev)
+			continue;
 		devname = udev_device_get_sysname(u_dev);
+		if (!devname) {
+			udev_device_unref(u_dev);
+			continue;
+		}
 
 		fwd += snprintf(buff + fwd, len - fwd, "    %s", devname);
 		if (fwd >= len)
Signature · 1 line
2.29.2

--
dm-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/dm-devel