net: phy: remove h from printk format specifier
Subsystems (4)
PATCH 1/1 net: phy: remove h from printk format specifier
From: Tom Rix <[email protected]>
This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of
unnecessary %h[xudi] and %hh[xudi]")
Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi] or %h[xudi].
--- drivers/net/phy/dp83640.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/phy/dp83640.c +1 -1
@@ -186,7 +186,7 @@ static void dp83640_gpio_defaults(struct ptp_pin_desc *pd)for (i =0 ; i <GPIO_TABLE_SIZE ; i++) {if (gpio_tab[i] <1 || gpio_tab[i] >DP83640_N_PINS ) { -pr_err ("gpio_tab[%d]=%hu out of range" , i, gpio_tab[i]); +pr_err ("gpio_tab[%d]=%u out of range" , i, gpio_tab[i]);return ; } }
Signature · 1 line
2.27.0
Jakub Kicinski
maintainerQuoted 10 lines · On Mon, 25 Jan 2021 08:45:28 -0800 [email protected] wrote:
From: Tom Rix <[email protected]>
This change fixes the checkpatch warning described in this commit commit
cbacb5ab0aa0("docs: printk-formats: Stop encouraging use of
unnecessary %h[xudi] and %hh[xudi]")Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi] or %h[xudi].
Signed-off-by Tom Rix <[email protected]>
As I mentioned before I personally don't care much for these changes so please expect me to be tossing them out of patchwork silently if the maintainer does not ack in time. YMMV with Dave (he should be back soon)