Skip to contentSkip to conversation

mac80211: minstrel_ht: fix regression in the max_prob_rate fix

PATCH New Felix Fietkau 1 participant 1 message Jan 26, 2021 mac80211

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mac80211: minstrel_ht: fix regression in the max_prob_rate fix

Since mi->max_prob_rate is overwritten after the loop that calls minstrel_ht_set_best_prob_rate, the new best rate needs to be written to *dest

Fixes a7fca4e4037f ("mac80211: minstrel_ht: fix max probability rate selection")
---
 net/mac80211/rc80211_minstrel_ht.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/mac80211/rc80211_minstrel_ht.c +1 -1
index 8e9e30c468a6..d48798fa15cb 100644
@@ -545,7 +545,7 @@ minstrel_ht_set_best_prob_rate(struct minstrel_ht_sta *mi, u16 *dest, u16 index)
 		cur_tp_avg = minstrel_ht_get_tp_avg(mi, cur_group, cur_idx,
 						    mrs->prob_avg);
 		if (cur_tp_avg > tmp_tp_avg)
-			mi->max_prob_rate = index;
+			*dest = index;
 
 		max_gpr_tp_avg = minstrel_ht_get_tp_avg(mi, max_gpr_group,
 							max_gpr_idx,
Signature · 1 line
2.28.0