introduce UNSUPPORTED
v5 cover introduce UNSUPPORTED
Hi all,
A recent thread [1] has exposed a couple of issues with our current way of handling EXPERT.
1) It is not obvious that "Configure standard Xen features (expert users)" is actually the famous EXPERT we keep talking about on xen-devel
2) It is not obvious when we need to enable EXPERT to get a specific feature
In particular if you want to enable ACPI support so that you can boot Xen on an ACPI platform, you have to enable EXPERT first. But searching through the kconfig menu it is really not clear (type '/' and "ACPI"):
nothing in the description tells you that you need to enable EXPERT to get the option.
This series makes things easier by doing the following:
- introduce a new kconfig option UNSUPPORTED which is clearly to enable UNSUPPORTED features as defined by SUPPORT.md
- change EXPERT options to UNSUPPORTED where it makes sense: keep depending on EXPERT for features made for experts
- tag unsupported features by adding (UNSUPPORTED) to the one-line description
- clarify the EXPERT one-line description
[1] https://marc.info/?l=xen-devel&m=160333101228981
Cheers,
Stefano
Stefano Stabellini (2):
xen: EXPERT clean-up and introduce UNSUPPORTED
xen: add (EXPERT) to one-line description of XEN_SHSTK
xen/Kconfig | 11 ++++++++++- xen/arch/arm/Kconfig | 6 +++--- xen/arch/x86/Kconfig | 8 ++++---- xen/common/Kconfig | 2 +- xen/common/sched/Kconfig | 6 +++--- 5 files changed, 21 insertions(+), 12 deletions(-)
PATCH v5 1/2 xen: EXPERT clean-up and introduce UNSUPPORTED
From: Stefano Stabellini <[email protected]>
A recent thread [1] has exposed a couple of issues with our current way of handling EXPERT.
1) It is not obvious that "Configure standard Xen features (expert users)" is actually the famous EXPERT we keep talking about on xen-devel
2) It is not obvious when we need to enable EXPERT to get a specific feature
In particular if you want to enable ACPI support so that you can boot Xen on an ACPI platform, you have to enable EXPERT first. But searching through the kconfig menu it is really not clear (type '/' and "ACPI"):
nothing in the description tells you that you need to enable EXPERT to get the option.
So this patch makes things easier by doing two things:
- introduce a new kconfig option UNSUPPORTED which is clearly to enable UNSUPPORTED features as defined by SUPPORT.md
- change EXPERT options to UNSUPPORTED where it makes sense: keep depending on EXPERT for features made for experts
- tag unsupported features by adding (UNSUPPORTED) to the one-line description
- clarify the EXPERT one-line description
[1] https://marc.info/?l=xen-devel&m=160333101228981
---
Changes in v5:
- add reviwed-by
- remove changes to ARM_SSBD and HARDEN_BRANCH_PREDICTOR
Changes in v4:
- clarify support statement of UNSUPPORTED
- move UNSUPPORTED past EXPERT
- add default EXPERT to UNSUPPORTED
Changes in v3:
- improve UNSUPPORTED text description
- avoid changing XEN_SHSTK and EFI_SET_VIRTUAL_ADDRESS_MAP
- update HVM_FEP to be UNSUPPORTED
Changes in v2:
- introduce UNSUPPORTED
- don't switch all EXPERT options to UNSUPPORTED
See as reference the v2 thread here:
https://marc.info/?l=xen-devel&m=160566066013723
--- xen/Kconfig | 11 ++++++++++- xen/arch/arm/Kconfig | 6 +++--- xen/arch/x86/Kconfig | 6 +++--- xen/common/Kconfig | 2 +- xen/common/sched/Kconfig | 6 +++--- 5 files changed, 20 insertions(+), 11 deletions(-)
xen/Kconfig +10 -1
@@ -35,7 +35,7 @@ config DEFCONFIG_LIST default ARCH_DEFCONFIG config EXPERT - bool "Configure standard Xen features (expert users)" + bool "Configure EXPERT features" help This option allows certain base Xen options and settings to be disabled or tweaked. This is for specialized environments
@@ -45,6 +45,15 @@ config EXPERT supported. default n +config UNSUPPORTED + bool "Configure UNSUPPORTED features" + default EXPERT + help + This option allows certain unsupported Xen options to be changed, + which includes non-security-supported, experimental, and tech + preview features as defined by SUPPORT.md. (Note that if an option + doesn't depend on UNSUPPORTED it doesn't imply that is supported.) + config LTO bool "Link Time Optimisation" depends on BROKEN
xen/arch/arm/Kconfig +3 -3
@@ -32,7 +32,7 @@ menu "Architecture Features" source "arch/Kconfig" config ACPI - bool "ACPI (Advanced Configuration and Power Interface) Support" if EXPERT + bool "ACPI (Advanced Configuration and Power Interface) Support (UNSUPPORTED)" if UNSUPPORTED depends on ARM_64 ---help---
@@ -49,7 +49,7 @@ config GICV3 If unsure, say Y config HAS_ITS - bool "GICv3 ITS MSI controller support" if EXPERT + bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED depends on GICV3 && !NEW_VGIC config HVM
@@ -104,7 +104,7 @@ config HARDEN_BRANCH_PREDICTOR If unsure, say Y. config TEE - bool "Enable TEE mediators support" if EXPERT + bool "Enable TEE mediators support (UNSUPPORTED)" if UNSUPPORTED default n help This option enables generic TEE mediators support. It allows guests
xen/arch/x86/Kconfig +3 -3
@@ -147,7 +147,7 @@ config BIGMEM If unsure, say N. config HVM_FEP - bool "HVM Forced Emulation Prefix support" if EXPERT + bool "HVM Forced Emulation Prefix support (UNSUPPORTED)" if UNSUPPORTED default DEBUG depends on HVM ---help---
@@ -166,7 +166,7 @@ config HVM_FEP If unsure, say N. config TBOOT - bool "Xen tboot support" if EXPERT + bool "Xen tboot support (UNSUPPORTED)" if UNSUPPORTED default y if !PV_SHIM_EXCLUSIVE select CRYPTO ---help---
@@ -252,7 +252,7 @@ config HYPERV_GUEST endif config MEM_SHARING - bool "Xen memory sharing support" if EXPERT + bool "Xen memory sharing support (UNSUPPORTED)" if UNSUPPORTED depends on HVM endmenu
xen/common/Kconfig +1 -1
@@ -272,7 +272,7 @@ config LATE_HWDOM If unsure, say N. config ARGO - bool "Argo: hypervisor-mediated interdomain communication" if EXPERT + bool "Argo: hypervisor-mediated interdomain communication (UNSUPPORTED)" if UNSUPPORTED ---help--- Enables a hypercall for domains to ask the hypervisor to perform data transfer of messages between domains.
xen/common/sched/Kconfig +3 -3
@@ -15,7 +15,7 @@ config SCHED_CREDIT2 optimized for lower latency and higher VM density. config SCHED_RTDS - bool "RTDS scheduler support (EXPERIMENTAL)" + bool "RTDS scheduler support (UNSUPPORTED)" if UNSUPPORTED default y ---help--- The RTDS scheduler is a soft and firm real-time scheduler for
@@ -23,14 +23,14 @@ config SCHED_RTDS in the cloud, and general low-latency workloads. config SCHED_ARINC653 - bool "ARINC653 scheduler support (EXPERIMENTAL)" + bool "ARINC653 scheduler support (UNSUPPORTED)" if UNSUPPORTED default DEBUG ---help--- The ARINC653 scheduler is a hard real-time scheduler for single cores, targeted for avionics, drones, and medical devices. config SCHED_NULL - bool "Null scheduler support (EXPERIMENTAL)" + bool "Null scheduler support (UNSUPPORTED)" if UNSUPPORTED default y ---help--- The null scheduler is a static, zero overhead scheduler,
Signature · 1 line
2.17.1
PATCH v5 2/2 xen: add (EXPERT) to one-line description of XEN_SHSTK
In reply to Stefano StabelliniFrom: Stefano Stabellini <[email protected]>
Add an "(EXPERT)" tag to the one-line description of Kconfig options that depend on EXPERT. (Not where just the prompt depends on EXPERT.)
Today we only have one such option: XEN_SHSTK.
---
Changes in v5:
- actually, only change one-line description of options that depends on EXPERT (and not just the prompt)
Changes in v4:
- new patch
--- xen/arch/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
xen/arch/x86/Kconfig +1 -1
@@ -103,7 +103,7 @@ config HVM If unsure, say Y. config XEN_SHSTK - bool "Supervisor Shadow Stacks" + bool "Supervisor Shadow Stacks (EXPERT)" depends on HAS_AS_CET_SS && EXPERT default y ---help---
Signature · 1 line
2.17.1
Re: [PATCH v5 2/2] xen: add (EXPERT) to one-line description of XEN_SHSTK
Quoted 8 lines · Stefano Stabellini
From: Stefano Stabellini <[email protected]>
Add an "(EXPERT)" tag to the one-line description of
Kconfigoptions that depend on EXPERT. (Not where just the prompt depends on EXPERT.)Today we only have one such option:
XEN_SHSTK.Signed-off-by Stefano Stabellini <[email protected]>