platform/x86: pmt: Make PMT Kconfig options depend on INTEL_PMT_CLASS
PATCH 1/1 platform/x86: pmt: Make PMT Kconfig options depend on INTEL_PMT_CLASS
Make the PMT Kconfig options depend on INTEL_PMT_CLASS instead of selecting it. Select should only be used with hidden options and INTEL_PMT_CLASS is not hidden.
This will stop Kconfig from asking if INTEL_PMT_TELEMETRY and INTEL_PMT_CRASHLOG should be enabled after the user says no to the INTEL_PMT_CLASS prompt.
--- drivers/platform/x86/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/platform/x86/Kconfig +2 -2
@@ -1383,7 +1383,7 @@ config INTEL_PMT_CLASS config INTEL_PMT_TELEMETRY tristate "Intel Platform Monitoring Technology (PMT) Telemetry driver" - select INTEL_PMT_CLASS + depends on INTEL_PMT_CLASS help The Intel Platform Monitory Technology (PMT) Telemetry driver provides access to hardware telemetry metrics on devices that support the
@@ -1394,7 +1394,7 @@ config INTEL_PMT_TELEMETRY config INTEL_PMT_CRASHLOG tristate "Intel Platform Monitoring Technology (PMT) Crashlog driver" - select INTEL_PMT_CLASS + depends on INTEL_PMT_CLASS help The Intel Platform Monitoring Technology (PMT) crashlog driver provides access to hardware crashlog capabilities on devices that support the
Signature · 1 line
2.29.2
Hi Hans,
Sorry for missing the discussion on this. Need to fix my mail filtering. I just submitted patches that instead make INTEL_PMT_CLASS non-user-selectable, leaving the other dependencies in place. Having the class driver user-selectable was a mistake.
I also did go ahead and add a dependancy on the MFD driver since all current PMT features are only exposed through this driver. So users will only see the following options:
MFD_INTEL_PMT
INTEL_PMT_TELEMETRY (selects INTEL_PMT_CLASS) INTEL_PMT_CRASHLOG (selects INTEL_PMT_CLASS)
David
Quoted 45 lines · Hans de Goede
Make the PMT
Kconfigoptions depend onINTEL_PMT_CLASSinstead of selecting it. Select should only be used with hidden options andINTEL_PMT_CLASSis not hidden.This will stop
Kconfigfrom asking ifINTEL_PMT_TELEMETRYandINTEL_PMT_CRASHLOGshould be enabled after the user says no to theINTEL_PMT_CLASSprompt.Reported-by Linus Torvalds <[email protected]>Cc Alexander Duyck <[email protected]>Cc David E. Box <[email protected]>Signed-off-by Hans de Goede <[email protected]>---
drivers/platform/x86/Kconfig | 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)drivers/platform/x86/Kconfig +0
-0@@ -1383,7 +1383,7 @@ config INTEL_PMT_CLASS
configINTEL_PMT_TELEMETRY
tristate "Intel Platform Monitoring Technology (PMT) Telemetry driver"
- selectINTEL_PMT_CLASS
+ depends onINTEL_PMT_CLASS
help
The Intel Platform Monitory Technology (PMT) Telemetry driver provides
access to hardware telemetry metrics on devices that support thedrivers/platform/x86/Kconfig +0
-0@@ -1394,7 +1394,7 @@ config INTEL_PMT_TELEMETRY
configINTEL_PMT_CRASHLOG
tristate "Intel Platform Monitoring Technology (PMT) Crashlog driver"
- selectINTEL_PMT_CLASS
+ depends onINTEL_PMT_CLASS
help
The Intel Platform Monitoring Technology (PMT) crashlog driver provides
access to hardware crashlog capabilities on devices that support the
Hi,
Quoted 7 lines · David E. Box
Hi Hans,
Sorry for missing the discussion on this. Need to fix my mail filtering. I just submitted patches that instead make
INTEL_PMT_CLASSnon-user-selectable, leaving the other dependencies in place. Having the class driver user-selectable was a mistake.
Quoted 7 lines
I also did go ahead and add a dependancy on the MFD driver since all current PMT features are only exposed through this driver. So users will only see the following options:
MFD_INTEL_PMT
INTEL_PMT_TELEMETRY(selectsINTEL_PMT_CLASS)INTEL_PMT_CRASHLOG(selectsINTEL_PMT_CLASS)
Ok, your version looks good, so I will merge it instead of my version.
Regards,
Hans
Quoted 51 lines
David
Quoted 45 lines · Hans de Goede
Make the PMT
Kconfigoptions depend onINTEL_PMT_CLASSinstead of selecting it. Select should only be used with hidden options andINTEL_PMT_CLASSis not hidden.This will stop
Kconfigfrom asking ifINTEL_PMT_TELEMETRYandINTEL_PMT_CRASHLOGshould be enabled after the user says no to theINTEL_PMT_CLASSprompt.Reported-by Linus Torvalds <[email protected]>Cc Alexander Duyck <[email protected]>Cc David E. Box <[email protected]>Signed-off-by Hans de Goede <[email protected]>---
drivers/platform/x86/Kconfig | 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)drivers/platform/x86/Kconfig +0
-0@@ -1383,7 +1383,7 @@ config INTEL_PMT_CLASS
configINTEL_PMT_TELEMETRY
tristate "Intel Platform Monitoring Technology (PMT) Telemetry driver"
- selectINTEL_PMT_CLASS
+ depends onINTEL_PMT_CLASS
help
The Intel Platform Monitory Technology (PMT) Telemetry driver provides
access to hardware telemetry metrics on devices that support thedrivers/platform/x86/Kconfig +0
-0@@ -1394,7 +1394,7 @@ config INTEL_PMT_TELEMETRY
configINTEL_PMT_CRASHLOG
tristate "Intel Platform Monitoring Technology (PMT) Crashlog driver"
- selectINTEL_PMT_CLASS
+ depends onINTEL_PMT_CLASS
help
The Intel Platform Monitoring Technology (PMT) crashlog driver provides
access to hardware crashlog capabilities on devices that support the