PCI: xgene: Fix CRS SV comment
PATCH 1/1 PCI: xgene: Fix CRS SV comment
From: Bjorn Helgaas <[email protected]>
Configuration Request Retry Status ("CRS") must be supported by all PCIe devices. CRS Software Visibility is an optional feature that enables a Root Port to make CRS visible to software by returning a special data value to complete a config read.
Clarify a comment to say that it is "CRS SV", not "CRS", that can be enabled.
--- drivers/pci/controller/pci-xgene.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)
drivers/pci/controller/pci-xgene.c +7 -6
@@ -173,12 +173,13 @@ static int xgene_pcie_config_read32(struct pci_bus *bus, unsigned int devfn,/* * The v1 controller has a bug in its Configuration Request -* Retry Status (CRS) logic: when CRS is enabled and we read the -* Vendor and Device ID of a non-existent device, the controller -* fabricates return data of 0xFFFF0001 ("device exists but is not -* ready") instead of 0xFFFFFFFF ("device does not exist"). This -* causes the PCI core to retry the read until it times out. -* Avoid this by not claiming to support CRS. +* Retry Status (CRS) logic: when CRS Software Visibility is +* enabled and we read the Vendor and Device ID of a non-existent +* device, the controller fabricates return data of 0xFFFF0001 +* ("device exists but is not ready") instead of 0xFFFFFFFF +* ("device does not exist"). This causes the PCI core to retry +* the read until it times out. Avoid this by not claiming to +* support CRS SV. */ if (pci_is_root_bus (bus) && (port->version ==XGENE_PCIE_IP_VER_1 ) && ((where & ~0x3 ) ==XGENE_V1_PCI_EXP_CAP +PCI_EXP_RTCTL ))
Signature · 7 lines
2.25.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Lorenzo Pieralisi
AppliedQuoted 7 lines · Bjorn Helgaas
Configuration Request Retry Status ("CRS") must be supported by all PCIe devices. CRS Software Visibility is an optional feature that enables a Root Port to make CRS visible to software by returning a special data value to complete a config read.
Clarify a comment to say that it is "CRS SV", not "CRS", that can be enabled.
Applied to pci/misc, thanks!
[1/1] PCI: xgene: Fix CRS SV comment
https://git.kernel.org/lpieralisi/pci/c/cc4a08cd09
Thanks,
Lorenzo