f2fs: flush data when enabling checkpoint back
Subsystems (2)
Jaegeuk Kim
maintainerPATCH 1/1 f2fs: flush data when enabling checkpoint back
During checkpoint=disable period, f2fs bypasses all the synchronous IOs such as sync and fsync. So, when enabling it back, we must flush all of them in order to keep the data persistent. Otherwise, suddern power-cut right after enabling checkpoint will cause data loss.
--- fs/f2fs/super.c | 3 +++ 1 file changed, 3 insertions(+)
fs/f2fs/super.c +3 -0
@@ -1887,6 +1887,9 @@ static int f2fs_disable_checkpoint(struct f2fs_sb_info *sbi)static void f2fs_enable_checkpoint (struct f2fs_sb_info *sbi) { +/* we should flush all the data to keep data consistency */ +sync_inodes_sb (sbi->sb); +down_write (&sbi->gc_lock);f2fs_dirty_to_prefree (sbi);
Signature · 8 lines
2.30.0.280.ga3ce27912f-goog _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Quoted 8 lines · Jaegeuk Kim
During checkpoint=disable period, f2fs bypasses all the synchronous IOs such as sync and fsync. So, when enabling it back, we must flush all of them in order to keep the data persistent. Otherwise, suddern power-cut right after enabling checkpoint will cause data loss.
Fixes 4354994f097d ("f2fs: checkpoint disabling")Signed-off-by Jaegeuk Kim <[email protected]>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel