Final set of patches for ADLS enabling
Subsystems (3)
cover Final set of patches for ADLS enabling
These are the final set of patches required for enabling ADL-S. The patches have been tested on platform and all display outputs are working.
Aditya Swarup (2):
drm/i915/adl_s: Add display WAs for ADL-S
drm/i915/adl_s: Add GT and CTX WAs for ADL-S
Anusha Srivatsa (1):
drm/i915/adl_s: Load DMC
Caz Yokoyama (1):
drm/i915/adl_s: MCHBAR memory info registers are moved
José Roberto de Souza (1):
drm/i915/display: Add HAS_D12_PLANE_MINIMIZATION
Lucas De Marchi (1):
drm/i915/adl_s: Add power wells
Matt Roper (2):
drm/i915/adl_s: Update PHY_MISC programming
drm/i915/adl_s: Re-use TGL GuC/HuC firmware
Tejas Upadhyay (1):
drm/i915/adl_s: Update memory bandwidth parameters
drivers/gpu/drm/i915/display/intel_bw.c | 8 +++++ .../gpu/drm/i915/display/intel_combo_phy.c | 12 +++++-- drivers/gpu/drm/i915/display/intel_csr.c | 10 +++++- .../drm/i915/display/intel_display_power.c | 9 ++--- drivers/gpu/drm/i915/display/intel_sprite.c | 6 ++-- drivers/gpu/drm/i915/gt/intel_workarounds.c | 34 ++++++++++++------- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 4 ++- drivers/gpu/drm/i915/i915_drv.h | 3 ++ drivers/gpu/drm/i915/i915_irq.c | 2 +- drivers/gpu/drm/i915/i915_reg.h | 5 +++ drivers/gpu/drm/i915/intel_device_info.c | 8 +++-- drivers/gpu/drm/i915/intel_dram.c | 24 +++++++++---- 12 files changed, 91 insertions(+), 34 deletions(-)
Signature · 6 lines
2.27.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/9 drm/i915/adl_s: Update PHY_MISC programming
From: Matt Roper <[email protected]>
ADL-S switches up which PHYs are considered a master to other PHYs; PHY-C is no longer a master, but PHY-D is now.
Bspec: 49291
--- drivers/gpu/drm/i915/display/intel_combo_phy.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/display/intel_combo_phy.c +9 -3
@@ -187,10 +187,16 @@ static bool has_phy_misc(struct drm_i915_private *i915, enum phy phy)* Some platforms only expect PHY_MISC to be programmed for PHY-A and * PHY-B and may not even have instances of the register for the * other combo PHY's. +* +* ADL-S technically has three instances of PHY_MISC, but only requires +* that we program it for PHY A. */ -if (IS_JSL_EHL (i915) || -IS_ROCKETLAKE (i915) || -IS_DG1 (i915)) + +if (IS_ALDERLAKE_S (i915)) +return phy ==PHY_A ; +else if (IS_JSL_EHL (i915) || +IS_ROCKETLAKE (i915) || +IS_DG1 (i915))return phy <PHY_C ;return true;
Signature · 6 lines
2.27.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 1/9] drm/i915/adl_s: Update PHY_MISC programming
Quoted 5 lines · Aditya Swarup
From: Matt Roper <[email protected]>
ADL-S switches up which PHYs are considered a master to other PHYs; PHY-C is no longer a master, but PHY-D is now.
Quoted 7 lines
Bspec: 49291
Cc Jani Nikula <[email protected]>Cc Ville Syrjälä <[email protected]>Cc Imre Deak <[email protected]>Cc Lucas De Marchi <[email protected]>Signed-off-by Matt Roper <[email protected]>Signed-off-by Aditya Swarup <[email protected]>
Aditya
Quoted 19 lines
--- drivers/gpu/drm/i915/display/intel_combo_phy.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/display/intel_combo_phy.c +3
-2@@ -187,10 +187,16 @@ static bool has_phy_misc(struct drm_i915_private *i915, enum phy phy)* Some platforms only expect PHY_MISC to be programmed for PHY-A and * PHY-B and may not even have instances of the register for the * other combo PHY's. +* +* ADL-S technically has three instances of PHY_MISC, but only requires +* that we program it for PHY A. */ - if (IS_JSL_EHL(i915) || - IS_ROCKETLAKE(i915) ||
drivers/gpu/drm/i915/display/intel_combo_phy.c static bool has_phy_misc(struct drm_i915_private *i915, enum phy phy) · line 202
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_combo_phy.c +6
-1- IS_DG1(i915)) + +if (IS_ALDERLAKE_S (i915)) +return phy ==PHY_A ; +else if (IS_JSL_EHL (i915) || +IS_ROCKETLAKE (i915) || +IS_DG1 (i915))return phy <PHY_C ;return true;
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/9 drm/i915/adl_s: MCHBAR memory info registers are moved
In reply to Aditya SwarupFrom: Caz Yokoyama <[email protected]>
The crwebview indicates on ADL-S that some of our MCHBAR registers have moved from their traditional 0x50XX offsets to new locations. The meaning and bit layout of the registers remain same.
v2: Simplify logic to a single if else chain and fix indents.(Lucas)
--- drivers/gpu/drm/i915/i915_reg.h | 5 +++++ drivers/gpu/drm/i915/intel_dram.c | 24 ++++++++++++++++++------ 2 files changed, 23 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/i915_reg.h +5 -0
@@ -10916,6 +10916,8 @@ enum skl_power_gate {#define SKL_DRAM_DDR_TYPE_LPDDR3 (2 << 0)#define SKL_DRAM_DDR_TYPE_LPDDR4 (3 << 0) +#define ADLS_MAD_INTER_CHANNEL_0_0_0_MCHBAR _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x6048) +#define SKL_MAD_DIMM_CH0_0_0_0_MCHBAR_MCMAIN _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x500C)#define SKL_MAD_DIMM_CH1_0_0_0_MCHBAR_MCMAIN _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x5010)#define SKL_DRAM_S_SHIFT 16
@@ -10943,6 +10945,9 @@ enum skl_power_gate {#define CNL_DRAM_RANK_3 (0x2 << 9)#define CNL_DRAM_RANK_4 (0x3 << 9) +#define ADLS_MAD_DIMM_CH0_0_0_0_MCHBAR _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x6054) +#define ADLS_MAD_DIMM_CH1_0_0_0_MCHBAR _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x6058) +/* * Please see hsw_read_dcomp() and hsw_write_dcomp() before using this register, * since on HSW we can't write to it using intel_uncore_write.
drivers/gpu/drm/i915/intel_dram.c +18 -6
@@ -181,17 +181,24 @@ skl_dram_get_channels_info(struct drm_i915_private *i915) {struct dram_info *dram_info = &i915->dram_info;struct dram_channel_info ch0 = {}, ch1 = {}; +i915_reg_t ch0_reg, ch1_reg;u32 val;int ret; - val =intel_uncore_read (&i915->uncore, -SKL_MAD_DIMM_CH0_0_0_0_MCHBAR_MCMAIN ); +if (IS_ALDERLAKE_S (i915)) { + ch0_reg =ADLS_MAD_DIMM_CH0_0_0_0_MCHBAR ; + ch1_reg =ADLS_MAD_DIMM_CH1_0_0_0_MCHBAR ; + }else { + ch0_reg =ADLS_MAD_DIMM_CH0_0_0_0_MCHBAR ; + ch1_reg =ADLS_MAD_DIMM_CH1_0_0_0_MCHBAR ; + } + + val =intel_uncore_read (&i915->uncore, ch0_reg); ret =skl_dram_get_channel_info (i915, &ch0,0 , val);if (ret ==0 ) dram_info->num_channels++; - val =intel_uncore_read (&i915->uncore, -SKL_MAD_DIMM_CH1_0_0_0_MCHBAR_MCMAIN ); + val =intel_uncore_read (&i915->uncore, ch1_reg); ret =skl_dram_get_channel_info (i915, &ch1,1 , val);if (ret ==0 ) dram_info->num_channels++;
@@ -229,10 +236,15 @@ skl_dram_get_channels_info(struct drm_i915_private *i915)static enum intel_dram_type skl_get_dram_type (struct drm_i915_private *i915) { +i915_reg_t reg;u32 val; - val =intel_uncore_read (&i915->uncore, -SKL_MAD_INTER_CHANNEL_0_0_0_MCHBAR_MCMAIN ); +if (IS_ALDERLAKE_S (i915)) + reg =ADLS_MAD_INTER_CHANNEL_0_0_0_MCHBAR ; +else + reg =SKL_MAD_INTER_CHANNEL_0_0_0_MCHBAR_MCMAIN ; + + val =intel_uncore_read (&i915->uncore, reg);switch (val &SKL_DRAM_DDR_TYPE_MASK ) {case SKL_DRAM_DDR_TYPE_DDR3 :
Signature · 6 lines
2.27.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 2/9] drm/i915/adl_s: MCHBAR memory info registers are moved
Quoted 54 lines · Aditya Swarup
From: Caz Yokoyama <[email protected]>
The crwebview indicates on ADL-S that some of our MCHBAR registers have moved from their traditional 0x50XX offsets to new locations. The meaning and bit layout of the registers remain same.
v2: Simplify logic to a single if else chain and fix indents.(Lucas)
Cc Lucas De Marchi <[email protected]>Cc Jani Nikula <[email protected]>Cc Ville Syrjälä <[email protected]>Cc Imre Deak <[email protected]>Cc Matt Roper <[email protected]>Signed-off-by Caz Yokoyama <[email protected]>Signed-off-by Aditya Swarup <[email protected]>---
drivers/gpu/drm/i915/i915_reg.h| 5 +++++drivers/gpu/drm/i915/intel_dram.c| 24 ++++++++++++++++++------2 files changed, 23 insertions(+), 6 deletions(-)drivers/gpu/drm/i915/i915_reg.h +5
-0@@ -10916,6 +10916,8 @@ enum skl_power_gate {#define SKL_DRAM_DDR_TYPE_LPDDR3 (2 << 0)#define SKL_DRAM_DDR_TYPE_LPDDR4 (3 << 0) +#define ADLS_MAD_INTER_CHANNEL_0_0_0_MCHBAR _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x6048) +#define SKL_MAD_DIMM_CH0_0_0_0_MCHBAR_MCMAIN _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x500C)#define SKL_MAD_DIMM_CH1_0_0_0_MCHBAR_MCMAIN _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x5010)#define SKL_DRAM_S_SHIFT 16@@ -10943,6 +10945,9 @@ enum skl_power_gate {#define CNL_DRAM_RANK_3 (0x2 << 9)#define CNL_DRAM_RANK_4 (0x3 << 9) +#define ADLS_MAD_DIMM_CH0_0_0_0_MCHBAR _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x6054) +#define ADLS_MAD_DIMM_CH1_0_0_0_MCHBAR _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x6058) +/* * Please see hsw_read_dcomp() and hsw_write_dcomp() before using this register, * since on HSW we can't write to it using intel_uncore_write. drivers/gpu/drm/i915/intel_dram.c +1
-0@@ -181,17 +181,24 @@ skl_dram_get_channels_info(struct drm_i915_private *i915) {struct dram_info *dram_info = &i915->dram_info;struct dram_channel_info ch0 = {}, ch1 = {}; +i915_reg_t ch0_reg, ch1_reg;u32 val;
drivers/gpu/drm/i915/intel_dram.c skl_dram_get_channels_info(struct drm_i915_private *i915) · line 193
Quoted 10 lines
drivers/gpu/drm/i915/intel_dram.c +6
-2int ret; - val =intel_uncore_read (&i915->uncore, -SKL_MAD_DIMM_CH0_0_0_0_MCHBAR_MCMAIN ); +if (IS_ALDERLAKE_S (i915)) { + ch0_reg =ADLS_MAD_DIMM_CH0_0_0_0_MCHBAR ; + ch1_reg =ADLS_MAD_DIMM_CH1_0_0_0_MCHBAR ; + }else { + ch0_reg =ADLS_MAD_DIMM_CH0_0_0_0_MCHBAR ; + ch1_reg =ADLS_MAD_DIMM_CH1_0_0_0_MCHBAR ;
I commented on the wrong version of the patch, but the bug is still here. And this patch conflict with Jose's patch.
Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 2/9] drm/i915/adl_s: MCHBAR memory info registers are moved
Quoted 57 lines · Lucas De Marchi
Quoted 56 lines · Aditya Swarup
From: Caz Yokoyama <[email protected]>
The crwebview indicates on ADL-S that some of our MCHBAR registers have moved from their traditional 0x50XX offsets to new locations. The meaning and bit layout of the registers remain same.
v2: Simplify logic to a single if else chain and fix indents.(Lucas)
Cc Lucas De Marchi <[email protected]>Cc Jani Nikula <[email protected]>Cc Ville Syrjälä <[email protected]>Cc Imre Deak <[email protected]>Cc Matt Roper <[email protected]>Signed-off-by Caz Yokoyama <[email protected]>Signed-off-by Aditya Swarup <[email protected]>---
drivers/gpu/drm/i915/i915_reg.h| 5 +++++drivers/gpu/drm/i915/intel_dram.c| 24 ++++++++++++++++++------2 files changed, 23 insertions(+), 6 deletions(-)drivers/gpu/drm/i915/i915_reg.h +5
-0@@ -10916,6 +10916,8 @@ enum skl_power_gate {#define SKL_DRAM_DDR_TYPE_LPDDR3 (2 << 0)#define SKL_DRAM_DDR_TYPE_LPDDR4 (3 << 0) +#define ADLS_MAD_INTER_CHANNEL_0_0_0_MCHBAR _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x6048) +#define SKL_MAD_DIMM_CH0_0_0_0_MCHBAR_MCMAIN _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x500C)#define SKL_MAD_DIMM_CH1_0_0_0_MCHBAR_MCMAIN _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x5010)#define SKL_DRAM_S_SHIFT 16@@ -10943,6 +10945,9 @@ enum skl_power_gate {#define CNL_DRAM_RANK_3 (0x2 << 9)#define CNL_DRAM_RANK_4 (0x3 << 9) +#define ADLS_MAD_DIMM_CH0_0_0_0_MCHBAR _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x6054) +#define ADLS_MAD_DIMM_CH1_0_0_0_MCHBAR _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x6058) +/* * Please see hsw_read_dcomp() and hsw_write_dcomp() before using this register, * since on HSW we can't write to it using intel_uncore_write. drivers/gpu/drm/i915/intel_dram.c +1
-0@@ -181,17 +181,24 @@ skl_dram_get_channels_info(struct drm_i915_private *i915) {struct dram_info *dram_info = &i915->dram_info;struct dram_channel_info ch0 = {}, ch1 = {}; +i915_reg_t ch0_reg, ch1_reg;u32 val;int ret;
Quoted 11 lines
drivers/gpu/drm/i915/intel_dram.c skl_dram_get_channels_info(struct drm_i915_private *i915) · line 193
Quoted 8 lines
drivers/gpu/drm/i915/intel_dram.c +6
-2- val =intel_uncore_read (&i915->uncore, -SKL_MAD_DIMM_CH0_0_0_0_MCHBAR_MCMAIN ); +if (IS_ALDERLAKE_S (i915)) { + ch0_reg =ADLS_MAD_DIMM_CH0_0_0_0_MCHBAR ; + ch1_reg =ADLS_MAD_DIMM_CH1_0_0_0_MCHBAR ; + }else { + ch0_reg =ADLS_MAD_DIMM_CH0_0_0_0_MCHBAR ; + ch1_reg =ADLS_MAD_DIMM_CH1_0_0_0_MCHBAR ;I commented on the wrong version of the patch, but the bug is still here. And this patch conflict with Jose's patch.
Yep, for GEN12+ we should use PCODE to read DRAM information.
Lucas left some comments, working in the fixes and soon another version will be send. It already takes care of all GEN12 platforms.
https://patchwork.freedesktop.org/series/86092/
Quoted 6 lines
Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 2/9] drm/i915/adl_s: MCHBAR memory info registers are moved
Quoted 70 lines · Jose
Quoted 57 lines · Lucas De Marchi
Quoted 56 lines · Aditya Swarup
From: Caz Yokoyama <[email protected]>
The crwebview indicates on ADL-S that some of our MCHBAR registers have moved from their traditional 0x50XX offsets to new locations. The meaning and bit layout of the registers remain same.
v2: Simplify logic to a single if else chain and fix indents.(Lucas)
Cc Lucas De Marchi <[email protected]>Cc Jani Nikula <[email protected]>Cc Ville Syrjälä <[email protected]>Cc Imre Deak <[email protected]>Cc Matt Roper <[email protected]>Signed-off-by Caz Yokoyama <[email protected]>Signed-off-by Aditya Swarup <[email protected]>---
drivers/gpu/drm/i915/i915_reg.h| 5 +++++drivers/gpu/drm/i915/intel_dram.c| 24 ++++++++++++++++++------2 files changed, 23 insertions(+), 6 deletions(-)drivers/gpu/drm/i915/i915_reg.h +5
-0@@ -10916,6 +10916,8 @@ enum skl_power_gate {#define SKL_DRAM_DDR_TYPE_LPDDR3 (2 << 0)#define SKL_DRAM_DDR_TYPE_LPDDR4 (3 << 0) +#define ADLS_MAD_INTER_CHANNEL_0_0_0_MCHBAR _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x6048) +#define SKL_MAD_DIMM_CH0_0_0_0_MCHBAR_MCMAIN _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x500C)#define SKL_MAD_DIMM_CH1_0_0_0_MCHBAR_MCMAIN _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x5010)#define SKL_DRAM_S_SHIFT 16@@ -10943,6 +10945,9 @@ enum skl_power_gate {#define CNL_DRAM_RANK_3 (0x2 << 9)#define CNL_DRAM_RANK_4 (0x3 << 9) +#define ADLS_MAD_DIMM_CH0_0_0_0_MCHBAR _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x6054) +#define ADLS_MAD_DIMM_CH1_0_0_0_MCHBAR _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x6058) +/* * Please see hsw_read_dcomp() and hsw_write_dcomp() before using this register, * since on HSW we can't write to it using intel_uncore_write. drivers/gpu/drm/i915/intel_dram.c +1
-0@@ -181,17 +181,24 @@ skl_dram_get_channels_info(struct drm_i915_private *i915) {struct dram_info *dram_info = &i915->dram_info;struct dram_channel_info ch0 = {}, ch1 = {}; +i915_reg_t ch0_reg, ch1_reg;u32 val;int ret;Quoted 11 lines
drivers/gpu/drm/i915/intel_dram.c skl_dram_get_channels_info(struct drm_i915_private *i915) · line 193
Quoted 8 lines
drivers/gpu/drm/i915/intel_dram.c +6
-2- val =intel_uncore_read (&i915->uncore, -SKL_MAD_DIMM_CH0_0_0_0_MCHBAR_MCMAIN ); +if (IS_ALDERLAKE_S (i915)) { + ch0_reg =ADLS_MAD_DIMM_CH0_0_0_0_MCHBAR ; + ch1_reg =ADLS_MAD_DIMM_CH1_0_0_0_MCHBAR ; + }else { + ch0_reg =ADLS_MAD_DIMM_CH0_0_0_0_MCHBAR ; + ch1_reg =ADLS_MAD_DIMM_CH1_0_0_0_MCHBAR ;I commented on the wrong version of the patch, but the bug is still here. And this patch conflict with Jose's patch.
Quoted 5 lines
Yep, for GEN12+ we should use PCODE to read DRAM information.
Lucas left some comments, working in the fixes and soon another version will be send. It already takes care of all GEN12 platforms.
Since I didn't see the removal of code
skl_dram_get_channels_info/get_dram_type, I have corrected this patch and submitted as part of rev2 just in case to please CI not to report errors with the next revision. Please ignore/drop the MCHBAR patch if your patch series has been merged.
Aditya
Quoted 8 lines
Quoted 7 lines
Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/9 drm/i915/adl_s: Add power wells
In reply to Aditya SwarupFrom: Lucas De Marchi <[email protected]>
TGL power wells can be re-used for ADL-S with the exception of the fake power well for TC_COLD, just like DG-1.
Bspec: 53597
--- drivers/gpu/drm/i915/display/intel_display_power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_display_power.c +1 -1
@@ -4689,7 +4689,7 @@ int intel_power_domains_init(struct drm_i915_private *dev_priv)* The enabling order will be from lower to higher indexed wells, * the disabling order is reversed. */ -if (IS_DG1 (dev_priv)) { +if (IS_ALDERLAKE_S (dev_priv) ||IS_DG1 (dev_priv)) { err =set_power_wells_mask (power_domains, tgl_power_wells,BIT_ULL (TGL_DISP_PW_TC_COLD_OFF )); }else if (IS_ROCKETLAKE (dev_priv)) {
Signature · 6 lines
2.27.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 3/9] drm/i915/adl_s: Add power wells
Quoted 5 lines · Aditya Swarup
From: Lucas De Marchi <[email protected]>
TGL power wells can be re-used for ADL-S with the exception of the fake power well for
TC_COLD, just like DG-1.
Quoted 7 lines
Bspec: 53597
Cc Imre Deak <[email protected]>Cc Matt Roper <[email protected]>Cc Aditya Swarup <[email protected]>Signed-off-by Lucas De Marchi <[email protected]>Signed-off-by Aditya Swarup <[email protected]>
Aditya
Quoted 10 lines
--- drivers/gpu/drm/i915/display/intel_display_power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_display_power.c +0
-0
drivers/gpu/drm/i915/display/intel_display_power.c int intel_power_domains_init(struct drm_i915_private *dev_priv) · line 4695
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_display_power.c +1
-1@@ -4689,7 +4689,7 @@ int intel_power_domains_init(struct drm_i915_private *dev_priv)* The enabling order will be from lower to higher indexed wells, * the disabling order is reversed. */ -if (IS_DG1 (dev_priv)) { +if (IS_ALDERLAKE_S (dev_priv) ||IS_DG1 (dev_priv)) { err =set_power_wells_mask (power_domains, tgl_power_wells,BIT_ULL (TGL_DISP_PW_TC_COLD_OFF )); }else if (IS_ROCKETLAKE (dev_priv)) {
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 3/9] drm/i915/adl_s: Add power wells
In reply to Aditya SwarupQuoted 6 lines · Aditya Swarup
From: Lucas De Marchi <[email protected]>
TGL power wells can be re-used for ADL-S with the exception of the fake power well for
TC_COLD, just like DG-1.Bspec: 53597
I think the bspec reference should actually be page 49231. But aside from that,
Quoted 26 lines
Cc Imre Deak <[email protected]>Cc Matt Roper <[email protected]>Cc Aditya Swarup <[email protected]>Signed-off-by Lucas De Marchi <[email protected]>Signed-off-by Aditya Swarup <[email protected]>--- drivers/gpu/drm/i915/display/intel_display_power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_display_power.c +1
-1@@ -4689,7 +4689,7 @@ int intel_power_domains_init(struct drm_i915_private *dev_priv)* The enabling order will be from lower to higher indexed wells, * the disabling order is reversed. */ -if (IS_DG1 (dev_priv)) { +if (IS_ALDERLAKE_S (dev_priv) ||IS_DG1 (dev_priv)) { err =set_power_wells_mask (power_domains, tgl_power_wells,BIT_ULL (TGL_DISP_PW_TC_COLD_OFF )); }else if (IS_ROCKETLAKE (dev_priv)) {Signature · 1 line
2.27.0
Signature · 9 lines
Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 4/9 drm/i915/adl_s: Re-use TGL GuC/HuC firmware
In reply to Aditya SwarupFrom: Matt Roper <[email protected]>
ADL-S, like RKL, uses the same internal device ID for the GuC and HuC as TGL did, making them all firmware-compatible. Let's re-use TGL's firmware for ADL-S.
Bspec: 50668
--- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c +3 -1
@@ -44,9 +44,11 @@ void intel_uc_fw_change_status(struct intel_uc_fw *uc_fw,* List of required GuC and HuC binaries per-platform. * Must be ordered based on platform + revid, from newer to older. * -* Note that RKL uses the same firmware as TGL. +* Note that RKL and ADL-S have the same GuC/HuC device ID's and use the same +* firmware as TGL. */ #define INTEL_UC_FIRMWARE_DEFS (fw_def, guc_def, huc_def) \ + fw_def(ALDERLAKE_S, 0, guc_def(tgl, 49, 0, 1), huc_def(tgl, 7, 5, 0)) \ fw_def(ROCKETLAKE, 0, guc_def(tgl, 49, 0, 1), huc_def(tgl, 7, 5, 0)) \ fw_def(TIGERLAKE, 0, guc_def(tgl, 49, 0, 1), huc_def(tgl, 7, 5, 0)) \ fw_def(JASPERLAKE, 0, guc_def(ehl, 49, 0, 1), huc_def(ehl, 9, 0, 0)) \
Signature · 6 lines
2.27.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 5/9 drm/i915/display: Add HAS_D12_PLANE_MINIMIZATION
In reply to Aditya SwarupFrom: José Roberto de Souza <[email protected]>
- As RKL and ADL-S only have 5 planes, primary and 4 sprites and the cursor plane, let's group the handling together under HAS_D12_PLANE_MINIMIZATION.
- Also use macro to select pipe irq fault error mask.
BSpec: 49251
--- drivers/gpu/drm/i915/display/intel_sprite.c | 2 +- drivers/gpu/drm/i915/i915_drv.h | 3 +++ drivers/gpu/drm/i915/i915_irq.c | 2 +- drivers/gpu/drm/i915/intel_device_info.c | 2 +- 4 files changed, 6 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/display/intel_sprite.c +1 -1
@@ -382,7 +382,7 @@ int intel_plane_check_src_coordinates(struct intel_plane_state *plane_state)static u8 icl_nv12_y_plane_mask (struct drm_i915_private *i915) { -if (IS_ROCKETLAKE (i915)) +if (HAS_D12_PLANE_MINIMIZATION (i915))return BIT (PLANE_SPRITE2 ) |BIT (PLANE_SPRITE3 );else return BIT (PLANE_SPRITE4 ) |BIT (PLANE_SPRITE5 );
drivers/gpu/drm/i915/i915_drv.h +3 -0
@@ -1785,6 +1785,9 @@ tgl_stepping_get(struct drm_i915_private *dev_priv)#define INTEL_DISPLAY_ENABLED (dev_priv) \ (drm_WARN_ON(&(dev_priv)->drm, !HAS_DISPLAY(dev_priv)), !(dev_priv)->params.disable_display) +#define HAS_D12_PLANE_MINIMIZATION (dev_priv) (IS_ROCKETLAKE(dev_priv) || \ + IS_ALDERLAKE_S(dev_priv)) +static inline bool run_as_guest (void ) {return !hypervisor_is_type (X86_HYPER_NATIVE );
drivers/gpu/drm/i915/i915_irq.c +1 -1
@@ -2280,7 +2280,7 @@ static u32 gen8_de_port_aux_mask(struct drm_i915_private *dev_priv)static u32 gen8_de_pipe_fault_mask (struct drm_i915_private *dev_priv) { -if (IS_ROCKETLAKE (dev_priv)) +if (HAS_D12_PLANE_MINIMIZATION (dev_priv))return RKL_DE_PIPE_IRQ_FAULT_ERRORS ;else if (INTEL_GEN (dev_priv) >=11 )return GEN11_DE_PIPE_IRQ_FAULT_ERRORS ;
drivers/gpu/drm/i915/intel_device_info.c +1 -1
@@ -261,7 +261,7 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)BUILD_BUG_ON (BITS_PER_TYPE (intel_engine_mask_t) <I915_NUM_ENGINES ); -if (IS_ROCKETLAKE (dev_priv)) +if (HAS_D12_PLANE_MINIMIZATION (dev_priv))for_each_pipe (dev_priv, pipe) runtime->num_sprites[pipe] =4 ;else if (INTEL_GEN (dev_priv) >=11 )
Signature · 6 lines
2.27.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 6/9 drm/i915/adl_s: Load DMC
In reply to Aditya SwarupFrom: Anusha Srivatsa <[email protected]>
Load DMC on ADL_S v2.01. This is the first offcial release of DMC for ADL_S.
--- drivers/gpu/drm/i915/display/intel_csr.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_csr.c +9 -1
@@ -40,6 +40,10 @@#define GEN12_CSR_MAX_FW_SIZE ICL_CSR_MAX_FW_SIZE +#define ADLS_CSR_PATH "i915/adls_dmc_ver2_01.bin" +#define ADLS_CSR_VERSION_REQUIRED CSR_VERSION(2, 1) +MODULE_FIRMWARE (ADLS_CSR_PATH ); +#define DG1_CSR_PATH "i915/dg1_dmc_ver2_02.bin"#define DG1_CSR_VERSION_REQUIRED CSR_VERSION(2, 2)MODULE_FIRMWARE (DG1_CSR_PATH );
@@ -689,7 +693,11 @@ void intel_csr_ucode_init(struct drm_i915_private *dev_priv)*/ intel_csr_runtime_pm_get (dev_priv); -if (IS_DG1 (dev_priv)) { +if (IS_ALDERLAKE_S (dev_priv)) { + csr->fw_path =ADLS_CSR_PATH ; + csr->required_version =ADLS_CSR_VERSION_REQUIRED ; + csr->max_fw_size =GEN12_CSR_MAX_FW_SIZE ; + }else if (IS_DG1 (dev_priv)) { csr->fw_path =DG1_CSR_PATH ; csr->required_version =DG1_CSR_VERSION_REQUIRED ; csr->max_fw_size =GEN12_CSR_MAX_FW_SIZE ;
Signature · 6 lines
2.27.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 6/9] drm/i915/adl_s: Load DMC
Quoted 5 lines · Aditya Swarup
From: Anusha Srivatsa <[email protected]>
Load DMC on
ADL_Sv2.01. This is the first offcial release of DMC forADL_S.
Quoted 7 lines
Cc Jani Nikula <[email protected]>Cc Imre Deak <[email protected]>Cc Matt Roper <[email protected]>Cc Lucas De Marchi <[email protected]>Cc Aditya Swarup <[email protected]>Signed-off-by Anusha Srivatsa <[email protected]>Signed-off-by Aditya Swarup <[email protected]>
Aditya
Quoted 23 lines
--- drivers/gpu/drm/i915/display/intel_csr.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_csr.c +4
-0@@ -40,6 +40,10 @@#define GEN12_CSR_MAX_FW_SIZE ICL_CSR_MAX_FW_SIZE +#define ADLS_CSR_PATH "i915/adls_dmc_ver2_01.bin" +#define ADLS_CSR_VERSION_REQUIRED CSR_VERSION(2, 1) +MODULE_FIRMWARE (ADLS_CSR_PATH ); +#define DG1_CSR_PATH "i915/dg1_dmc_ver2_02.bin"#define DG1_CSR_VERSION_REQUIRED CSR_VERSION(2, 2)MODULE_FIRMWARE (DG1_CSR_PATH );@@ -689,7 +693,11 @@ void intel_csr_ucode_init(struct drm_i915_private *dev_priv)*/ intel_csr_runtime_pm_get (dev_priv);
drivers/gpu/drm/i915/display/intel_csr.c void intel_csr_ucode_init(struct drm_i915_private *dev_priv) · line 703
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_csr.c +5
-1-if (IS_DG1 (dev_priv)) { +if (IS_ALDERLAKE_S (dev_priv)) { + csr->fw_path =ADLS_CSR_PATH ; + csr->required_version =ADLS_CSR_VERSION_REQUIRED ; + csr->max_fw_size =GEN12_CSR_MAX_FW_SIZE ; + }else if (IS_DG1 (dev_priv)) { csr->fw_path =DG1_CSR_PATH ; csr->required_version =DG1_CSR_VERSION_REQUIRED ; csr->max_fw_size =GEN12_CSR_MAX_FW_SIZE ;
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 6/9] drm/i915/adl_s: Load DMC
In reply to Aditya SwarupQuoted 21 lines · Aditya Swarup
From: Anusha Srivatsa <[email protected]>
Load DMC on
ADL_Sv2.01. This is the first offcial release of DMC forADL_S.Cc Jani Nikula <[email protected]>Cc Imre Deak <[email protected]>Cc Matt Roper <[email protected]>Cc Lucas De Marchi <[email protected]>Cc Aditya Swarup <[email protected]>Signed-off-by Anusha Srivatsa <[email protected]>Signed-off-by Aditya Swarup <[email protected]>---
drivers/gpu/drm/i915/display/intel_csr.c| 10 +++++++++-1 file changed, 9 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_csr.c +0
-0
drivers/gpu/drm/i915/display/intel_csr.c line 43
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_csr.c +1
-0@@ -40,6 +40,10 @@#define GEN12_CSR_MAX_FW_SIZE ICL_CSR_MAX_FW_SIZE +#define ADLS_CSR_PATH "i915/adls_dmc_ver2_01.bin"
Anusha, did you send this firmware to linux-firmware repo? I don't see it there.
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/i915
Lucas De Marchi
Quoted 26 lines
drivers/gpu/drm/i915/display/intel_csr.c +8
-1+#define ADLS_CSR_VERSION_REQUIRED CSR_VERSION(2, 1) +MODULE_FIRMWARE (ADLS_CSR_PATH ); +#define DG1_CSR_PATH "i915/dg1_dmc_ver2_02.bin"#define DG1_CSR_VERSION_REQUIRED CSR_VERSION(2, 2)MODULE_FIRMWARE (DG1_CSR_PATH );@@ -689,7 +693,11 @@ void intel_csr_ucode_init(struct drm_i915_private *dev_priv)*/ intel_csr_runtime_pm_get (dev_priv); -if (IS_DG1 (dev_priv)) { +if (IS_ALDERLAKE_S (dev_priv)) { + csr->fw_path =ADLS_CSR_PATH ; + csr->required_version =ADLS_CSR_VERSION_REQUIRED ; + csr->max_fw_size =GEN12_CSR_MAX_FW_SIZE ; + }else if (IS_DG1 (dev_priv)) { csr->fw_path =DG1_CSR_PATH ; csr->required_version =DG1_CSR_VERSION_REQUIRED ; csr->max_fw_size =GEN12_CSR_MAX_FW_SIZE ;Signature · 6 lines
2.27.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 7/9 drm/i915/adl_s: Update memory bandwidth parameters
In reply to Aditya SwarupFrom: Tejas Upadhyay <[email protected]>
Just like RKL, the ADL_S platform also has different memory characteristics from past platforms. Update the values used by our memory bandwidth calculations accordingly.
Bspec: 64631
--- drivers/gpu/drm/i915/display/intel_bw.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/gpu/drm/i915/display/intel_bw.c +8 -0
@@ -205,6 +205,12 @@ static const struct intel_sa_info rkl_sa_info = { .displayrtids = 128, }; +static const struct intel_sa_info adls_sa_info = { + .deburst =16 , + .deprogbwlimit =38 ,/* GB/s */ + .displayrtids =256 , +}; +static int icl_get_bw_info (struct drm_i915_private *dev_priv,const struct intel_sa_info *sa) {struct intel_qgv_info qi = {};
@@ -317,6 +323,8 @@ void intel_bw_init_hw(struct drm_i915_private *dev_priv)if (IS_ROCKETLAKE (dev_priv))icl_get_bw_info (dev_priv, &rkl_sa_info); +else if (IS_ALDERLAKE_S (dev_priv)) +icl_get_bw_info (dev_priv, &adls_sa_info);else if (IS_GEN (dev_priv,12 ))icl_get_bw_info (dev_priv, &tgl_sa_info);else if (IS_GEN (dev_priv,11 ))
Signature · 6 lines
2.27.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 7/9] drm/i915/adl_s: Update memory bandwidth parameters
Quoted 37 lines · Aditya Swarup
From: Tejas Upadhyay <[email protected]>
Just like RKL, the
ADL_Splatform also has different memory characteristics from past platforms. Update the values used by our memory bandwidth calculations accordingly.Bspec: 64631
Cc Matt Roper <[email protected]>Cc Lucas De Marchi <[email protected]>Cc Jani Nikula <[email protected]>Cc Ville Syrjälä <[email protected]>Cc Imre Deak <[email protected]>Signed-off-by Tejas Upadhyay <[email protected]>Signed-off-by Aditya Swarup <[email protected]>Reviewed-by Anusha Srivatsa <[email protected]>--- drivers/gpu/drm/i915/display/intel_bw.c | 8 ++++++++ 1 file changed, 8 insertions(+)drivers/gpu/drm/i915/display/intel_bw.c +6
-0@@ -205,6 +205,12 @@ static const struct intel_sa_info rkl_sa_info = { .displayrtids = 128, }; +static const struct intel_sa_info adls_sa_info = { + .deburst =16 , + .deprogbwlimit =38 ,/* GB/s */ + .displayrtids =256 , +}; +static int icl_get_bw_info (struct drm_i915_private *dev_priv,const struct intel_sa_info *sa) {struct intel_qgv_info qi = {};
drivers/gpu/drm/i915/display/intel_bw.c void intel_bw_init_hw(struct drm_i915_private *dev_priv) · line 327
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_bw.c +2
-0@@ -317,6 +323,8 @@ void intel_bw_init_hw(struct drm_i915_private *dev_priv)if (IS_ROCKETLAKE (dev_priv))icl_get_bw_info (dev_priv, &rkl_sa_info); +else if (IS_ALDERLAKE_S (dev_priv)) +icl_get_bw_info (dev_priv, &adls_sa_info);
Minor nitpick: i915 convention is to always put the newest platform / generation at the top of the if/else tree for consistency.
Matt
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_bw.c +0
-0else if (IS_GEN (dev_priv,12 ))icl_get_bw_info (dev_priv, &tgl_sa_info);else if (IS_GEN (dev_priv,11 ))Signature · 1 line
2.27.0
Signature · 9 lines
Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 8/9 drm/i915/adl_s: Add display WAs for ADL-S
In reply to Aditya Swarup- Extend permanent driver WA Wa_1409767108, Wa_14010685332 and Wa_14011294188 to adl-s.
- Extend permanent driver WA Wa_1606054188 to adl-s.
- Add Wa_14011765242 for adl-s A0 stepping.
--- drivers/gpu/drm/i915/display/intel_display_power.c | 7 ++++--- drivers/gpu/drm/i915/display/intel_sprite.c | 4 ++-- drivers/gpu/drm/i915/intel_device_info.c | 6 +++++- 3 files changed, 11 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power.c +4 -3
@@ -5339,9 +5339,10 @@ static void tgl_bw_buddy_init(struct drm_i915_private *dev_priv)unsigned long abox_mask =INTEL_INFO (dev_priv)->abox_mask;int config, i; -if (IS_DG1_REVID (dev_priv,DG1_REVID_A0 ,DG1_REVID_A0 ) || +if (IS_ALDERLAKE_S (dev_priv) || +IS_DG1_REVID (dev_priv,DG1_REVID_A0 ,DG1_REVID_A0 ) ||IS_TGL_DISP_STEPPING (dev_priv,STEP_A0 ,STEP_B0 )) -/* Wa_1409767108:tgl,dg1 */ +/* Wa_1409767108:tgl,dg1,adl-s */ table = wa_1409767108_buddy_page_masks;else table = tgl_buddy_page_masks;
@@ -5379,7 +5380,7 @@ static void icl_display_core_init(struct drm_i915_private *dev_priv,gen9_set_dc_state (dev_priv,DC_STATE_DISABLE ); -/* Wa_14011294188:ehl,jsl,tgl,rkl */ +/* Wa_14011294188:ehl,jsl,tgl,rkl,adl-s */ if (INTEL_PCH_TYPE (dev_priv) >=PCH_JSP &&INTEL_PCH_TYPE (dev_priv) <PCH_DG1 ) intel_de_rmw(dev_priv, SOUTH_DSPCLK_GATE_D, 0,
drivers/gpu/drm/i915/display/intel_sprite.c +2 -2
@@ -2418,8 +2418,8 @@ static int skl_plane_check_fb(const struct intel_crtc_state *crtc_state,return -EINVAL ; } -/* Wa_1606054188:tgl */ -if (IS_TIGERLAKE (dev_priv) && +/* Wa_1606054188:tgl,adl-s */ +if ((IS_ALDERLAKE_S (dev_priv) ||IS_TIGERLAKE (dev_priv)) && plane_state->ckey.flags &I915_SET_COLORKEY_SOURCE &&intel_format_is_p01x (fb->format->format)) { drm_dbg_kms(&dev_priv->drm,
drivers/gpu/drm/i915/intel_device_info.c +5 -1
@@ -250,7 +250,11 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)struct intel_runtime_info *runtime =RUNTIME_INFO (dev_priv);enum pipe pipe; -if (INTEL_GEN (dev_priv) >=10 ) { +/* Wa_14011765242: adl-s A0 */ +if (IS_ADLS_DISP_STEPPING (dev_priv,STEP_A0 ,STEP_A0 )) +for_each_pipe (dev_priv, pipe) + runtime->num_scalers[pipe] =0 ; +else if (INTEL_GEN (dev_priv) >=10 ) {for_each_pipe (dev_priv, pipe) runtime->num_scalers[pipe] =2 ; }else if (IS_GEN (dev_priv,9 )) {
Signature · 6 lines
2.27.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 8/9] drm/i915/adl_s: Add display WAs for ADL-S
Quoted 63 lines · Aditya Swarup
- Extend permanent driver WA
Wa_1409767108,Wa_14010685332andWa_14011294188to adl-s.
- Extend permanent driver WAWa_1606054188to adl-s.
- AddWa_14011765242for adl-s A0 stepping.Cc Jani Nikula <[email protected]>Cc Ville Syrjälä <[email protected]>Cc Imre Deak <[email protected]>Cc Matt Roper <[email protected]>Cc Lucas De Marchi <[email protected]>Signed-off-by Aditya Swarup <[email protected]>--- drivers/gpu/drm/i915/display/intel_display_power.c | 7 ++++--- drivers/gpu/drm/i915/display/intel_sprite.c | 4 ++-- drivers/gpu/drm/i915/intel_device_info.c | 6 +++++- 3 files changed, 11 insertions(+), 6 deletions(-)drivers/gpu/drm/i915/display/intel_display_power.c +4
-3@@ -5339,9 +5339,10 @@ static void tgl_bw_buddy_init(struct drm_i915_private *dev_priv)unsigned long abox_mask =INTEL_INFO (dev_priv)->abox_mask;int config, i; -if (IS_DG1_REVID (dev_priv,DG1_REVID_A0 ,DG1_REVID_A0 ) || +if (IS_ALDERLAKE_S (dev_priv) || +IS_DG1_REVID (dev_priv,DG1_REVID_A0 ,DG1_REVID_A0 ) ||IS_TGL_DISP_STEPPING (dev_priv,STEP_A0 ,STEP_B0 )) -/* Wa_1409767108:tgl,dg1 */ +/* Wa_1409767108:tgl,dg1,adl-s */ table = wa_1409767108_buddy_page_masks;else table = tgl_buddy_page_masks;@@ -5379,7 +5380,7 @@ static void icl_display_core_init(struct drm_i915_private *dev_priv,gen9_set_dc_state (dev_priv,DC_STATE_DISABLE ); -/* Wa_14011294188:ehl,jsl,tgl,rkl */ +/* Wa_14011294188:ehl,jsl,tgl,rkl,adl-s */ if (INTEL_PCH_TYPE (dev_priv) >=PCH_JSP &&INTEL_PCH_TYPE (dev_priv) <PCH_DG1 ) intel_de_rmw(dev_priv, SOUTH_DSPCLK_GATE_D, 0,drivers/gpu/drm/i915/display/intel_sprite.c +2
-2@@ -2418,8 +2418,8 @@ static int skl_plane_check_fb(const struct intel_crtc_state *crtc_state,return -EINVAL ; } -/* Wa_1606054188:tgl */ -if (IS_TIGERLAKE (dev_priv) && +/* Wa_1606054188:tgl,adl-s */ +if ((IS_ALDERLAKE_S (dev_priv) ||IS_TIGERLAKE (dev_priv)) && plane_state->ckey.flags &I915_SET_COLORKEY_SOURCE &&intel_format_is_p01x (fb->format->format)) { drm_dbg_kms(&dev_priv->drm,drivers/gpu/drm/i915/intel_device_info.c +0
-0
drivers/gpu/drm/i915/intel_device_info.c void intel_device_info_runtime_init(struct drm_i915_private *dev_priv) · line 254
Quoted 6 lines
drivers/gpu/drm/i915/intel_device_info.c +2
-1@@ -250,7 +250,11 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)struct intel_runtime_info *runtime =RUNTIME_INFO (dev_priv);enum pipe pipe; -if (INTEL_GEN (dev_priv) >=10 ) { +/* Wa_14011765242: adl-s A0 */ +if (IS_ADLS_DISP_STEPPING (dev_priv,STEP_A0 ,STEP_A0 ))
I think this workaround is also needed on A1 stepping now and should only be removed on A2.
Matt
Quoted 9 lines
drivers/gpu/drm/i915/intel_device_info.c +3
-0+for_each_pipe (dev_priv, pipe) + runtime->num_scalers[pipe] =0 ; + else if (INTEL_GEN(dev_priv) >= 10) {for_each_pipe (dev_priv, pipe) runtime->num_scalers[pipe] =2 ; } else if (IS_GEN(dev_priv, 9)) {Signature · 1 line
2.27.0
Signature · 9 lines
Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 8/9] drm/i915/adl_s: Add display WAs for ADL-S
Quoted 67 lines · Matt Roper
Quoted 66 lines · Aditya Swarup
- Extend permanent driver WA
Wa_1409767108,Wa_14010685332andWa_14011294188to adl-s.
- Extend permanent driver WAWa_1606054188to adl-s.
- AddWa_14011765242for adl-s A0 stepping.Cc Jani Nikula <[email protected]>Cc Ville Syrjälä <[email protected]>Cc Imre Deak <[email protected]>Cc Matt Roper <[email protected]>Cc Lucas De Marchi <[email protected]>Signed-off-by Aditya Swarup <[email protected]>--- drivers/gpu/drm/i915/display/intel_display_power.c | 7 ++++--- drivers/gpu/drm/i915/display/intel_sprite.c | 4 ++-- drivers/gpu/drm/i915/intel_device_info.c | 6 +++++- 3 files changed, 11 insertions(+), 6 deletions(-)drivers/gpu/drm/i915/display/intel_display_power.c +4
-3@@ -5339,9 +5339,10 @@ static void tgl_bw_buddy_init(struct drm_i915_private *dev_priv)unsigned long abox_mask =INTEL_INFO (dev_priv)->abox_mask;int config, i; -if (IS_DG1_REVID (dev_priv,DG1_REVID_A0 ,DG1_REVID_A0 ) || +if (IS_ALDERLAKE_S (dev_priv) || +IS_DG1_REVID (dev_priv,DG1_REVID_A0 ,DG1_REVID_A0 ) ||IS_TGL_DISP_STEPPING (dev_priv,STEP_A0 ,STEP_B0 )) -/* Wa_1409767108:tgl,dg1 */ +/* Wa_1409767108:tgl,dg1,adl-s */ table = wa_1409767108_buddy_page_masks;else table = tgl_buddy_page_masks;@@ -5379,7 +5380,7 @@ static void icl_display_core_init(struct drm_i915_private *dev_priv,gen9_set_dc_state (dev_priv,DC_STATE_DISABLE ); -/* Wa_14011294188:ehl,jsl,tgl,rkl */ +/* Wa_14011294188:ehl,jsl,tgl,rkl,adl-s */ if (INTEL_PCH_TYPE (dev_priv) >=PCH_JSP &&INTEL_PCH_TYPE (dev_priv) <PCH_DG1 ) intel_de_rmw(dev_priv, SOUTH_DSPCLK_GATE_D, 0,drivers/gpu/drm/i915/display/intel_sprite.c +2
-2@@ -2418,8 +2418,8 @@ static int skl_plane_check_fb(const struct intel_crtc_state *crtc_state,return -EINVAL ; } -/* Wa_1606054188:tgl */ -if (IS_TIGERLAKE (dev_priv) && +/* Wa_1606054188:tgl,adl-s */ +if ((IS_ALDERLAKE_S (dev_priv) ||IS_TIGERLAKE (dev_priv)) && plane_state->ckey.flags &I915_SET_COLORKEY_SOURCE &&intel_format_is_p01x (fb->format->format)) { drm_dbg_kms(&dev_priv->drm,drivers/gpu/drm/i915/intel_device_info.c +0
-0@@ -250,7 +250,11 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)struct intel_runtime_info *runtime =RUNTIME_INFO (dev_priv);enum pipe pipe;
Quoted 6 lines
drivers/gpu/drm/i915/intel_device_info.c void intel_device_info_runtime_init(struct drm_i915_private *dev_priv) · line 254
Quoted 3 lines
drivers/gpu/drm/i915/intel_device_info.c +2
-1-if (INTEL_GEN (dev_priv) >=10 ) { +/* Wa_14011765242: adl-s A0 */ +if (IS_ADLS_DISP_STEPPING (dev_priv,STEP_A0 ,STEP_A0 ))I think this workaround is also needed on A1 stepping now and should only be removed on A2.
There is no A1 stepping for ADLS. We directly have stepping A2 after A0. But I have made the change that you have suggested in rev2.
Aditya
Quoted 4 lines
Matt
Quoted 10 lines
Quoted 9 lines
drivers/gpu/drm/i915/intel_device_info.c +3
-0+for_each_pipe (dev_priv, pipe) + runtime->num_scalers[pipe] =0 ; + else if (INTEL_GEN(dev_priv) >= 10) {for_each_pipe (dev_priv, pipe) runtime->num_scalers[pipe] =2 ; } else if (IS_GEN(dev_priv, 9)) {Signature · 1 line
2.27.0
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 8/9] drm/i915/adl_s: Add display WAs for ADL-S
Quoted 90 lines · Aditya Swarup
Quoted 82 lines · Matt Roper
Quoted 81 lines · Aditya Swarup
- Extend permanent driver WA
Wa_1409767108,Wa_14010685332andWa_14011294188to adl-s.
- Extend permanent driver WAWa_1606054188to adl-s.
- AddWa_14011765242for adl-s A0 stepping.Cc Jani Nikula <[email protected]>Cc Ville Syrjälä <[email protected]>Cc Imre Deak <[email protected]>Cc Matt Roper <[email protected]>Cc Lucas De Marchi <[email protected]>Signed-off-by Aditya Swarup <[email protected]>---
drivers/gpu/drm/i915/display/intel_display_power.c | 7 ++++--- drivers/gpu/drm/i915/display/intel_sprite.c | 4 ++-- drivers/gpu/drm/i915/intel_device_info.c | 6 +++++- 3 files changed, 11 insertions(+), 6 deletions(-)drivers/gpu/drm/i915/display/intel_display_power.c +0
-0@@ -5339,9 +5339,10 @@ static void tgl_bw_buddy_init(struct drm_i915_private *dev_priv) unsigned long abox_mask = INTEL_INFO(dev_priv)->abox_mask; int config, i;drivers/gpu/drm/i915/display/intel_display_power.c +2
-1- if (IS_DG1_REVID(dev_priv, DG1_REVID_A0, DG1_REVID_A0) || + if (IS_ALDERLAKE_S(dev_priv) || + IS_DG1_REVID(dev_priv, DG1_REVID_A0, DG1_REVID_A0) ||
IS_TGL_DISP_STEPPING(dev_priv, STEP_A0, STEP_B0))drivers/gpu/drm/i915/display/intel_display_power.c +1
-1-/* Wa_1409767108:tgl,dg1 */ +/* Wa_1409767108:tgl,dg1,adl-s */ table =
wa_1409767108_buddy_page_masks; else
table =tgl_buddy_page_masks;drivers/gpu/drm/i915/display/intel_display_power.c +0
-0@@ -5379,7 +5380,7 @@ static void icl_display_core_init(struct drm_i915_private *dev_priv,
gen9_set_dc_state(dev_priv, DC_STATE_DISABLE);drivers/gpu/drm/i915/display/intel_display_power.c +1
-1-/* Wa_14011294188:ehl,jsl,tgl,rkl */ +/* Wa_14011294188:ehl,jsl,tgl,rkl,adl-s */ if (
INTEL_PCH_TYPE(dev_priv)>=PCH_JSP&&INTEL_PCH_TYPE(dev_priv)<PCH_DG1) intel_de_rmw(dev_priv,SOUTH_DSPCLK_GATE_D, 0,drivers/gpu/drm/i915/display/intel_sprite.c +0
-0@@ -2418,8 +2418,8 @@ static int skl_plane_check_fb(const struct intel_crtc_state *crtc_state, return -EINVAL; }drivers/gpu/drm/i915/display/intel_sprite.c +2
-2-/* Wa_1606054188:tgl */ - if (IS_TIGERLAKE(dev_priv) && +/* Wa_1606054188:tgl,adl-s */ + if ((IS_ALDERLAKE_S(dev_priv) || IS_TIGERLAKE(dev_priv)) &&
plane_state->ckey.flags&I915_SET_COLORKEY_SOURCE&&intel_format_is_p01x(fb->format->format)) { drm_dbg_kms(&dev_priv->drm,drivers/gpu/drm/i915/intel_device_info.c +0
-0@@ -250,7 +250,11 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv) struct intel_runtime_info *runtime = RUNTIME_INFO(dev_priv); enum pipe pipe;Quoted 6 lines
drivers/gpu/drm/i915/intel_device_info.c void intel_device_info_runtime_init(struct drm_i915_private *dev_priv) · line 254
Quoted 3 lines
drivers/gpu/drm/i915/intel_device_info.c +2
-1-if (INTEL_GEN (dev_priv) >=10 ) { +/* Wa_14011765242: adl-s A0 */ +if (IS_ADLS_DISP_STEPPING (dev_priv,STEP_A0 ,STEP_A0 ))I think this workaround is also needed on A1 stepping now and should only be removed on A2.
Quoted 2 lines
There is no A1 stepping for ADLS. We directly have stepping A2 after A0. But I have made the change that you have suggested in rev2.
In my opinion "if (IS_ADLS_DISP_STEPPING(dev_priv, STEP_A0, STEP_A0))" is the right approach here, there no stepping with display A1 so just checking STEP_A0 will be enough.
Quoted 18 lines
Aditya
Quoted 4 lines
Matt
Quoted 10 lines
Quoted 9 lines
drivers/gpu/drm/i915/intel_device_info.c +3
-0+for_each_pipe (dev_priv, pipe) + runtime->num_scalers[pipe] =0 ; + else if (INTEL_GEN(dev_priv) >= 10) {
for_each_pipe(dev_priv, pipe)runtime->num_scalers[pipe] = 2; } else if (IS_GEN(dev_priv, 9)) {Signature · 1 line
2.27.0
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 9/9 drm/i915/adl_s: Add GT and CTX WAs for ADL-S
In reply to Aditya Swarup- Extend Wa_1606931601 and Wa_1409804808 to ADL-S.
- Extend Wa_14010919138 and Wa_14010229206 to ADL-S (Madhumitha)
- Extend Wa_22010271021 to ADLS (cyokoyam)
v2:
- Extend Wa_1409804808 and remove unnecessary branching/redundant adls workaround placeholder functions.
- Split WAs properly based on previous platforms and applicable ADLS WA.
--- drivers/gpu/drm/i915/gt/intel_workarounds.c | 34 +++++++++++++-------- 1 file changed, 21 insertions(+), 13 deletions(-)
drivers/gpu/drm/i915/gt/intel_workarounds.c +21 -13
@@ -729,7 +729,8 @@ __intel_engine_init_ctx_wa(struct intel_engine_cs *engine,if (IS_DG1 (i915))dg1_ctx_workarounds_init (engine, wal); -else if (IS_ROCKETLAKE (i915) ||IS_TIGERLAKE (i915)) +else if (IS_ALDERLAKE_S (i915) ||IS_ROCKETLAKE (i915) || +IS_TIGERLAKE (i915))tgl_ctx_workarounds_init (engine, wal);else if (IS_GEN (i915,12 ))gen12_ctx_workarounds_init (engine, wal);
@@ -1639,45 +1640,45 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal) GEN7_DISABLE_SAMPLER_PREFETCH); } -if (IS_DG1 (i915) ||IS_ROCKETLAKE (i915) ||IS_TIGERLAKE (i915)) { -/* Wa_1606931601:tgl,rkl,dg1 */ +if (IS_ALDERLAKE_S (i915) ||IS_DG1 (i915) || +IS_ROCKETLAKE (i915) ||IS_TIGERLAKE (i915)) { +/* Wa_1606931601:tgl,rkl,dg1,adl-s */ wa_masked_en (wal,GEN7_ROW_CHICKEN2 ,GEN12_DISABLE_EARLY_READ );/* * Wa_1407928979:tgl A* * Wa_18011464164:tgl[B0+],dg1[B0+] * Wa_22010931296:tgl[B0+],dg1[B0+] -* Wa_14010919138:rkl, dg1 +* Wa_14010919138:rkl,dg1,adl-s */ wa_write_or (wal,GEN7_FF_THREAD_MODE ,GEN12_FF_TESSELATION_DOP_GATE_DISABLE );/* * Wa_1606700617:tgl,dg1 -* Wa_22010271021:tgl,rkl,dg1 +* Wa_22010271021:tgl,rkl,dg1, adl-s */ wa_masked_en (wal,GEN9_CS_DEBUG_MODE1 ,FF_DOP_CLOCK_GATE_DISABLE ); - -/* Wa_1406941453:tgl,rkl,dg1 */ -wa_masked_en (wal, -GEN10_SAMPLER_MODE , -ENABLE_SMALLPL ); } -if (IS_DG1_REVID (i915,DG1_REVID_A0 ,DG1_REVID_A0 ) || +if (IS_ALDERLAKE_S (i915) ||IS_DG1_REVID (i915,DG1_REVID_A0 ,DG1_REVID_A0 ) ||IS_ROCKETLAKE (i915) ||IS_TIGERLAKE (i915)) { -/* Wa_1409804808:tgl,rkl,dg1[a0] */ +/* Wa_1409804808:tgl,rkl,dg1[a0],adl-s */ wa_masked_en (wal,GEN7_ROW_CHICKEN2 ,GEN12_PUSH_CONST_DEREF_HOLD_DIS );/* * Wa_1409085225:tgl -* Wa_14010229206:tgl,rkl,dg1[a0] +* Wa_14010229206:tgl,rkl,dg1[a0],adl-s */ wa_masked_en (wal,GEN9_ROW_CHICKEN4 ,GEN12_DISABLE_TDL_PUSH ); + } + +if (IS_DG1_REVID (i915,DG1_REVID_A0 ,DG1_REVID_A0 ) || +IS_ROCKETLAKE (i915) ||IS_TIGERLAKE (i915)) {/* * Wa_1607030317:tgl * Wa_1607186500:tgl
@@ -1694,6 +1695,13 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal) GEN8_RC_SEMA_IDLE_MSG_DISABLE); } +if (IS_DG1 (i915) ||IS_ROCKETLAKE (i915) ||IS_TIGERLAKE (i915)) { +/* Wa_1406941453:tgl,rkl,dg1 */ +wa_masked_en (wal, +GEN10_SAMPLER_MODE , +ENABLE_SMALLPL ); + } +if (IS_GEN (i915,11 )) {/* This is not an Wa. Enable for better image quality */ wa_masked_en(wal,
Signature · 6 lines
2.27.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 9/9] drm/i915/adl_s: Add GT and CTX WAs for ADL-S
Quoted 10 lines · Aditya Swarup
- Extend
Wa_1606931601andWa_1409804808to ADL-S.
- ExtendWa_14010919138andWa_14010229206to ADL-S (Madhumitha)
- ExtendWa_22010271021to ADLS (cyokoyam)v2:
- ExtendWa_1409804808and remove unnecessary branching/redundant adls workaround placeholder functions.
- Split WAs properly based on previous platforms and applicable ADLS WA.
Quoted 7 lines
Cc Jani Nikula <[email protected]>Cc Ville Syrjälä <[email protected]>Cc Imre Deak <[email protected]>Cc Matt Roper <[email protected]>Cc Lucas De Marchi <[email protected]>Signed-off-by Madhumitha Tolakanahalli Pradeep <[email protected]>Signed-off-by Aditya Swarup <[email protected]>
Matches the current WA database.
Quoted 93 lines
--- drivers/gpu/drm/i915/gt/intel_workarounds.c | 34 +++++++++++++-------- 1 file changed, 21 insertions(+), 13 deletions(-)drivers/gpu/drm/i915/gt/intel_workarounds.c +21
-13@@ -729,7 +729,8 @@ __intel_engine_init_ctx_wa(struct intel_engine_cs *engine,if (IS_DG1 (i915))dg1_ctx_workarounds_init (engine, wal); -else if (IS_ROCKETLAKE (i915) ||IS_TIGERLAKE (i915)) +else if (IS_ALDERLAKE_S (i915) ||IS_ROCKETLAKE (i915) || +IS_TIGERLAKE (i915))tgl_ctx_workarounds_init (engine, wal);else if (IS_GEN (i915,12 ))gen12_ctx_workarounds_init (engine, wal);@@ -1639,45 +1640,45 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal) GEN7_DISABLE_SAMPLER_PREFETCH); } -if (IS_DG1 (i915) ||IS_ROCKETLAKE (i915) ||IS_TIGERLAKE (i915)) { -/* Wa_1606931601:tgl,rkl,dg1 */ +if (IS_ALDERLAKE_S (i915) ||IS_DG1 (i915) || +IS_ROCKETLAKE (i915) ||IS_TIGERLAKE (i915)) { +/* Wa_1606931601:tgl,rkl,dg1,adl-s */ wa_masked_en (wal,GEN7_ROW_CHICKEN2 ,GEN12_DISABLE_EARLY_READ );/* * Wa_1407928979:tgl A* * Wa_18011464164:tgl[B0+],dg1[B0+] * Wa_22010931296:tgl[B0+],dg1[B0+] -* Wa_14010919138:rkl, dg1 +* Wa_14010919138:rkl,dg1,adl-s */ wa_write_or (wal,GEN7_FF_THREAD_MODE ,GEN12_FF_TESSELATION_DOP_GATE_DISABLE );/* * Wa_1606700617:tgl,dg1 -* Wa_22010271021:tgl,rkl,dg1 +* Wa_22010271021:tgl,rkl,dg1, adl-s */ wa_masked_en (wal,GEN9_CS_DEBUG_MODE1 ,FF_DOP_CLOCK_GATE_DISABLE ); - -/* Wa_1406941453:tgl,rkl,dg1 */ -wa_masked_en (wal, -GEN10_SAMPLER_MODE , -ENABLE_SMALLPL ); } -if (IS_DG1_REVID (i915,DG1_REVID_A0 ,DG1_REVID_A0 ) || +if (IS_ALDERLAKE_S (i915) ||IS_DG1_REVID (i915,DG1_REVID_A0 ,DG1_REVID_A0 ) ||IS_ROCKETLAKE (i915) ||IS_TIGERLAKE (i915)) { -/* Wa_1409804808:tgl,rkl,dg1[a0] */ +/* Wa_1409804808:tgl,rkl,dg1[a0],adl-s */ wa_masked_en (wal,GEN7_ROW_CHICKEN2 ,GEN12_PUSH_CONST_DEREF_HOLD_DIS );/* * Wa_1409085225:tgl -* Wa_14010229206:tgl,rkl,dg1[a0] +* Wa_14010229206:tgl,rkl,dg1[a0],adl-s */ wa_masked_en (wal,GEN9_ROW_CHICKEN4 ,GEN12_DISABLE_TDL_PUSH ); + } + +if (IS_DG1_REVID (i915,DG1_REVID_A0 ,DG1_REVID_A0 ) || +IS_ROCKETLAKE (i915) ||IS_TIGERLAKE (i915)) {/* * Wa_1607030317:tgl * Wa_1607186500:tgl @@ -1694,6 +1695,13 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal) GEN8_RC_SEMA_IDLE_MSG_DISABLE); } +if (IS_DG1 (i915) ||IS_ROCKETLAKE (i915) ||IS_TIGERLAKE (i915)) { +/* Wa_1406941453:tgl,rkl,dg1 */ +wa_masked_en (wal, +GEN10_SAMPLER_MODE , +ENABLE_SMALLPL ); + } +if (IS_GEN (i915,11 )) {/* This is not an Wa. Enable for better image quality */ wa_masked_en(wal,Signature · 1 line
2.27.0
Signature · 9 lines
Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Final set of patches for ADLS enabling
In reply to Aditya Swarup== Series Details ==
== Series Details ==
Series: Final set of patches for ADLS enabling
URL : https://patchwork.freedesktop.org/series/86322/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip 244ac6e1eab7 drm/i915/adl_s: Update PHY_MISC programming fe66bf899d58 drm/i915/adl_s: MCHBAR memory info registers are moved 32ae4d0747f2 drm/i915/adl_s: Add power wells 9d236ff1ca29 drm/i915/adl_s: Re-use TGL GuC/HuC firmware 2490f8422994 drm/i915/display: Add HAS_D12_PLANE_MINIMIZATION -:45: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects? #45: FILE: drivers/gpu/drm/i915/i915_drv.h:1788: +#define HAS_D12_PLANE_MINIMIZATION(dev_priv) (IS_ROCKETLAKE(dev_priv) || \ + IS_ALDERLAKE_S(dev_priv))
total: 0 errors, 0 warnings, 1 checks, 33 lines checked e2673158258c drm/i915/adl_s: Load DMC1e05edf12b40 drm/i915/adl_s: Update memory bandwidth parameters b8b8e62c273d drm/i915/adl_s: Add display WAs for ADL-S 11dca653436d drm/i915/adl_s: Add GT and CTX WAs for ADL-S
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Final set of patches for ADLS enabling
In reply to Aditya Swarup== Series Details ==
== Series Details ==
Series: Final set of patches for ADLS enabling
URL : https://patchwork.freedesktop.org/series/86322/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_reset.c:1327:5: warning: context imbalance in 'intel_gt_reset_trylock' - different lock contexts for basic block +drivers/gpu/drm/i915/gvt/mmio.c:295:23: warning: memcpy with byte count of 279040 +drivers/gpu/drm/i915/i915_perf.c:1450:15: warning: memset with byte count of 16777216 +drivers/gpu/drm/i915/i915_perf.c:1504:15: warning: memset with byte count of 16777216 +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write8' - different lock contexts for basic block
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for Final set of patches for ADLS enabling
In reply to Aditya Swarup== Series Details ==
== Series Details ==
Series: Final set of patches for ADLS enabling
URL : https://patchwork.freedesktop.org/series/86322/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9686 -> Patchwork_19512
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/index.html
Known issues
------------
Here are the changes found in Patchwork_19512 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_sync@basic-each:
- fi-tgl-y: [PASS][1] -> [DMESG-WARN][2] ([i915#402])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/fi-tgl-y/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/fi-tgl-y/igt@[email protected]
* igt@i915_pm_rpm@module-reload:
- fi-byt-j1900: [PASS][3] -> [INCOMPLETE][4] ([i915#142] / [i915#2405])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/fi-byt-j1900/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/fi-byt-j1900/igt@[email protected]
* igt@runner@aborted:
- fi-byt-j1900: NOTRUN -> [FAIL][5] ([i915#1814] / [i915#2505])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/fi-byt-j1900/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_create@basic:
- fi-tgl-y: [DMESG-WARN][6] ([i915#402]) -> [PASS][7] +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/fi-tgl-y/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/fi-tgl-y/igt@[email protected]
[i915#142]: https://gitlab.freedesktop.org/drm/intel/issues/142
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#2405]: https://gitlab.freedesktop.org/drm/intel/issues/2405
[i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
Participating hosts (44 -> 39)
------------------------------
Missing (5): fi-jsl-1 fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan bat-jsl-2
Build changes
-------------
* Linux: CI_DRM_9686 -> Patchwork_19512
CI-20190529: 20190529
CI_DRM_9686: 8de0436dc0e777bbd5490d56134a838da4c19121 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5973: 7ae3d0d68e6bf4c5e404c87b570773d1b3173d47 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19512: 11dca653436d8211406641e04a27f8a828d10391 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
11dca653436d drm/i915/adl_s: Add GT and CTX WAs for ADL-S b8b8e62c273d drm/i915/adl_s: Add display WAs for ADL-S 1e05edf12b40 drm/i915/adl_s: Update memory bandwidth parameters e2673158258c drm/i915/adl_s: Load DMC2490f8422994 drm/i915/display: Add HAS_D12_PLANE_MINIMIZATION 9d236ff1ca29 drm/i915/adl_s: Re-use TGL GuC/HuC firmware 32ae4d0747f2 drm/i915/adl_s: Add power wells fe66bf899d58 drm/i915/adl_s: MCHBAR memory info registers are moved 244ac6e1eab7 drm/i915/adl_s: Update PHY_MISC programming
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for Final set of patches for ADLS enabling
In reply to Aditya Swarup== Series Details ==
== Series Details ==
Series: Final set of patches for ADLS enabling
URL : https://patchwork.freedesktop.org/series/86322/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9686_full -> Patchwork_19512_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_19512_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_19512_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_19512_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@mman:
- shard-skl: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-skl9/igt@i915_selftest@[email protected]
Known issues
------------
Here are the changes found in Patchwork_19512_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][2] -> [FAIL][3] ([i915#2842]) +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-tglb1/igt@gem_exec_fair@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-tglb6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: [PASS][4] -> [FAIL][5] ([i915#2842]) +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-glk7/igt@gem_exec_fair@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-glk5/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@bcs0:
- shard-iclb: [PASS][6] -> [FAIL][7] ([i915#2842])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-iclb8/igt@gem_exec_fair@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-iclb1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][8] ([i915#2842]) +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-iclb1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [PASS][9] -> [FAIL][10] ([i915#2842])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-kbl1/igt@gem_exec_fair@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-kbl2/igt@gem_exec_fair@[email protected]
* igt@gem_mmap_gtt@hang:
- shard-glk: [PASS][11] -> [DMESG-WARN][12] ([i915#118] / [i915#95])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-glk6/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-glk7/igt@[email protected]
* igt@gem_render_copy@y-tiled-to-vebox-x-tiled:
- shard-glk: NOTRUN -> [SKIP][13] ([fdo#109271]) +12 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-glk5/igt@[email protected]
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][14] -> [FAIL][15] ([i915#454])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-iclb1/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-iclb4/igt@[email protected]
* igt@i915_selftest@live@gt_pm:
- shard-skl: NOTRUN -> [DMESG-FAIL][16] ([i915#1886] / [i915#2291])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-skl9/igt@i915_selftest@live@gt_pm.html
* igt@i915_suspend@forcewake:
- shard-kbl: [PASS][17] -> [DMESG-WARN][18] ([i915#180])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-kbl6/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-kbl1/igt@[email protected]
* igt@kms_async_flips@test-time-stamp:
- shard-tglb: [PASS][19] -> [FAIL][20] ([i915#2597])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-tglb5/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-tglb2/igt@[email protected]
* igt@kms_chamelium@hdmi-cmp-planar-formats:
- shard-iclb: NOTRUN -> [SKIP][21] ([fdo#109284] / [fdo#111827])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-iclb5/igt@[email protected]
* igt@kms_chamelium@vga-hpd-after-suspend:
- shard-glk: NOTRUN -> [SKIP][22] ([fdo#109271] / [fdo#111827])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-glk7/igt@[email protected]
* igt@kms_color@pipe-d-ctm-max:
- shard-skl: NOTRUN -> [SKIP][23] ([fdo#109271]) +45 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-skl5/igt@[email protected]
* igt@kms_color_chamelium@pipe-a-ctm-green-to-red:
- shard-skl: NOTRUN -> [SKIP][24] ([fdo#109271] / [fdo#111827]) +2 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-skl5/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-128x42-random:
- shard-skl: [PASS][25] -> [FAIL][26] ([i915#54]) +4 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-skl10/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-skl4/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-128x42-random:
- shard-skl: NOTRUN -> [FAIL][27] ([i915#54]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-skl5/igt@[email protected]
* igt@kms_cursor_legacy@pipe-d-torture-bo:
- shard-skl: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#533])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-skl5/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-tglb: [PASS][29] -> [FAIL][30] ([i915#2598]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-tglb6/igt@kms_flip@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-tglb2/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2:
- shard-glk: [PASS][31] -> [FAIL][32] ([i915#79])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-glk7/igt@kms_flip@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-glk1/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1:
- shard-skl: [PASS][33] -> [FAIL][34] ([i915#2122]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-skl4/igt@kms_flip@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-skl10/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile:
- shard-glk: NOTRUN -> [SKIP][35] ([fdo#109271] / [i915#2642])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-glk7/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-gtt:
- shard-iclb: NOTRUN -> [SKIP][36] ([fdo#109280])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-gtt.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [PASS][37] -> [FAIL][38] ([i915#1188])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-skl9/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-skl6/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:
- shard-skl: NOTRUN -> [FAIL][39] ([i915#265])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-skl5/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][40] -> [FAIL][41] ([fdo#108145] / [i915#265])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-skl7/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-skl1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
- shard-skl: NOTRUN -> [FAIL][42] ([fdo#108145] / [i915#265])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-skl9/igt@[email protected]
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4:
- shard-skl: NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#658]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-skl3/igt@[email protected]
* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-iclb: [PASS][44] -> [SKIP][45] ([fdo#109441])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-iclb3/igt@kms_psr@psr2_sprite_mmap_cpu.html
* igt@prime_vgem@sync@vcs1:
- shard-tglb: [PASS][46] -> [INCOMPLETE][47] ([i915#409])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-tglb8/igt@prime_vgem@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-tglb8/igt@prime_vgem@[email protected]
#### Possible fixes ####
* igt@gem_exec_fair@basic-none@vecs0:
- shard-kbl: [FAIL][48] ([i915#2842]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-kbl1/igt@gem_exec_fair@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-kbl4/igt@gem_exec_fair@[email protected]
- shard-apl: [FAIL][50] ([i915#2842]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-apl1/igt@gem_exec_fair@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-apl8/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][52] ([i915#2849]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-iclb7/igt@gem_exec_fair@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-iclb7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_schedule@u-fairslice@rcs0:
- shard-glk: [DMESG-WARN][54] -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-glk6/igt@gem_exec_schedule@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-glk7/igt@gem_exec_schedule@[email protected]
* igt@gen9_exec_parse@allowed-all:
- shard-glk: [DMESG-WARN][56] ([i915#1436] / [i915#716]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-glk9/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-glk5/igt@[email protected]
* igt@gen9_exec_parse@allowed-single:
- shard-skl: [DMESG-WARN][58] ([i915#1436] / [i915#716]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-skl8/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-skl8/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-skl: [FAIL][60] ([i915#54]) -> [PASS][61] +7 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-skl4/igt@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-skl9/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-skl: [FAIL][62] ([i915#2346]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-skl9/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-skl6/igt@[email protected]
* igt@kms_flip@blocking-absolute-wf_vblank@a-edp1:
- shard-skl: [DMESG-WARN][64] ([i915#1982]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-skl2/igt@kms_flip@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-skl8/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-blt:
- shard-skl: [FAIL][66] ([i915#49]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-skl2/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-skl3/igt@[email protected]
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][68] ([i915#1188]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-skl2/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-skl8/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [FAIL][70] ([fdo#108145] / [i915#265]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-skl2/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-skl3/igt@[email protected]
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [SKIP][72] ([fdo#109441]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-iclb5/igt@kms_psr@psr2_sprite_mmap_gtt.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@perf@short-reads:
- shard-skl: [FAIL][74] ([i915#51]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-skl4/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-skl10/igt@[email protected]
* {igt@sysfs_clients@pidname}:
- shard-glk: [FAIL][76] -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-glk4/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-glk9/igt@[email protected]
* {igt@sysfs_clients@sema-10@rcs0}:
- shard-kbl: [SKIP][78] ([fdo#109271]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-kbl1/igt@sysfs_clients@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-kbl2/igt@sysfs_clients@[email protected]
* {igt@sysfs_clients@split-10@vcs0}:
- shard-skl: [SKIP][80] ([fdo#109271]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-skl7/igt@sysfs_clients@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-skl1/igt@sysfs_clients@[email protected]
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][82] ([i915#2681] / [i915#2684]) -> [WARN][83] ([i915#1804] / [i915#2684])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-iclb8/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-iclb6/igt@[email protected]
* igt@runner@aborted:
- shard-kbl: ([FAIL][84], [FAIL][85], [FAIL][86]) ([i915#2295] / [i915#2505]) -> ([FAIL][87], [FAIL][88], [FAIL][89], [FAIL][90]) ([i915#2295])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-kbl4/igt@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-kbl6/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-kbl1/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-kbl1/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-kbl1/igt@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-kbl4/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-kbl4/igt@[email protected]
- shard-iclb: ([FAIL][91], [FAIL][92], [FAIL][93], [FAIL][94]) ([i915#2295] / [i915#2426] / [i915#2724]) -> ([FAIL][95], [FAIL][96], [FAIL][97]) ([i915#2295] / [i915#2724])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-iclb5/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-iclb5/igt@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-iclb3/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-iclb4/igt@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-iclb4/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-iclb8/igt@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-iclb8/igt@[email protected]
- shard-glk: ([FAIL][98], [FAIL][99], [FAIL][100], [FAIL][101], [FAIL][102]) ([i915#2295] / [i915#2426] / [k.org#202321]) -> ([FAIL][103], [FAIL][104], [FAIL][105]) ([i915#2295] / [k.org#202321])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-glk6/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-glk5/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-glk1/igt@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-glk2/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-glk9/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-glk2/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-glk8/igt@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-glk3/igt@[email protected]
- shard-tglb: ([FAIL][106], [FAIL][107], [FAIL][108]) ([i915#2295] / [i915#2667]) -> ([FAIL][109], [FAIL][110], [FAIL][111], [FAIL][112]) ([i915#2295] / [i915#2426] / [i915#2667] / [i915#409])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-tglb1/igt@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-tglb8/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-tglb2/igt@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-tglb8/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-tglb1/igt@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-tglb5/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-tglb3/igt@[email protected]
- shard-skl: ([FAIL][113], [FAIL][114], [FAIL][115], [FAIL][116]) ([i915#1436] / [i915#2295]) -> ([FAIL][117], [FAIL][118], [FAIL][119]) ([i915#2295])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-skl4/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-skl9/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-skl8/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9686/shard-skl6/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-skl5/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-skl9/igt@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/shard-skl6/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505
[i915#2597]: https://gitlab.freedesktop.org/drm/intel/issues/2597
[i915#2598]: https://gitlab.freedesktop.org/drm/intel/issues/2598
[i915#2642]: https://gitlab.freedesktop.org/drm/intel/issues/2642
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2667]: https://gitlab.freedesktop.org/drm/intel/issues/2667
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2724]: https://gitlab.freedesktop.org/drm/intel/issues/2724
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849
[i915#409]: https://gitlab.freedesktop.org/drm/intel/issues/409
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#51]: https://gitlab.freedesktop.org/drm/intel/issues/51
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9686 -> Patchwork_19512
CI-20190529: 20190529
CI_DRM_9686: 8de0436dc0e777bbd5490d56134a838da4c19121 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5973: 7ae3d0d68e6bf4c5e404c87b570773d1b3173d47 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19512: 11dca653436d8211406641e04a27f8a828d10391 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19512/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx