ACPI: Test for ACPI_SUCCESS rather than !ACPI_FAILURE
Subsystems (8)
PATCH 1/1 ACPI: Test for ACPI_SUCCESS rather than !ACPI_FAILURE
From: Bjorn Helgaas <[email protected]>
The double negative makes it hard to read "if (!ACPI_FAILURE(status))". Replace it with "if (ACPI_SUCCESS(status))".
---
This isn't really an ACPI patch, but I'm sending it to you, Rafael, since it seems easier to just apply these all at once. But I'd be happy to split them up into individual patches if you'd rather.
drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 4 ++-- drivers/gpu/drm/radeon/radeon_bios.c | 4 ++-- drivers/hwmon/acpi_power_meter.c | 4 ++-- drivers/platform/x86/asus-laptop.c | 6 +++--- drivers/spi/spi.c | 2 +- sound/pci/hda/hda_intel.c | 4 ++-- 6 files changed, 12 insertions(+), 12 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c +2 -2
@@ -291,7 +291,7 @@ static bool amdgpu_atrm_get_bios(struct amdgpu_device *adev)continue ; status =acpi_get_handle (dhandle,"ATRM" , &atrm_handle); -if (!ACPI_FAILURE (status)) { +if (ACPI_SUCCESS (status)) { found = true;break ; }
@@ -304,7 +304,7 @@ static bool amdgpu_atrm_get_bios(struct amdgpu_device *adev)continue ; status =acpi_get_handle (dhandle,"ATRM" , &atrm_handle); -if (!ACPI_FAILURE (status)) { +if (ACPI_SUCCESS (status)) { found = true;break ; }
drivers/gpu/drm/radeon/radeon_bios.c +2 -2
@@ -205,7 +205,7 @@ static bool radeon_atrm_get_bios(struct radeon_device *rdev)continue ; status =acpi_get_handle (dhandle,"ATRM" , &atrm_handle); -if (!ACPI_FAILURE (status)) { +if (ACPI_SUCCESS (status)) { found = true;break ; }
@@ -218,7 +218,7 @@ static bool radeon_atrm_get_bios(struct radeon_device *rdev)continue ; status =acpi_get_handle (dhandle,"ATRM" , &atrm_handle); -if (!ACPI_FAILURE (status)) { +if (ACPI_SUCCESS (status)) { found = true;break ; }
drivers/hwmon/acpi_power_meter.c +2 -2
@@ -161,7 +161,7 @@ static ssize_t set_avg_interval(struct device *dev,mutex_lock (&resource->lock); status =acpi_evaluate_integer (resource->acpi_dev->handle,"_PAI" , &args, &data); -if (!ACPI_FAILURE (status)) +if (ACPI_SUCCESS (status)) resource->avg_interval = temp;mutex_unlock (&resource->lock);
@@ -232,7 +232,7 @@ static ssize_t set_cap(struct device *dev, struct device_attribute *devattr,mutex_lock (&resource->lock); status =acpi_evaluate_integer (resource->acpi_dev->handle,"_SHL" , &args, &data); -if (!ACPI_FAILURE (status)) +if (ACPI_SUCCESS (status)) resource->cap = temp;mutex_unlock (&resource->lock);
drivers/platform/x86/asus-laptop.c +3 -3
@@ -861,7 +861,7 @@ static ssize_t infos_show(struct device *dev, struct device_attribute *attr,* The significance of others is yet to be found. */ rv =acpi_evaluate_integer (asus->handle,"SFUN" ,NULL , &temp); -if (!ACPI_FAILURE (rv)) +if (ACPI_SUCCESS (rv)) len +=sprintf (page + len,"SFUN value : %#x\n" , (uint ) temp);/*
@@ -873,7 +873,7 @@ static ssize_t infos_show(struct device *dev, struct device_attribute *attr,* takes several seconds to run on some systems. */ rv =acpi_evaluate_integer (asus->handle,"HWRS" ,NULL , &temp); -if (!ACPI_FAILURE (rv)) +if (ACPI_SUCCESS (rv)) len +=sprintf (page + len,"HWRS value : %#x\n" , (uint ) temp);/*
@@ -884,7 +884,7 @@ static ssize_t infos_show(struct device *dev, struct device_attribute *attr,* silently ignored. */ rv =acpi_evaluate_integer (asus->handle,"ASYM" ,NULL , &temp); -if (!ACPI_FAILURE (rv)) +if (ACPI_SUCCESS (rv)) len +=sprintf (page + len,"ASYM value : %#x\n" , (uint ) temp);if (asus->dsdt_info) {
drivers/spi/spi.c +1 -1
@@ -2210,7 +2210,7 @@ static acpi_status acpi_register_spi_device(struct spi_controller *ctlr,return AE_OK ;if (!lookup.max_speed_hz && - !ACPI_FAILURE (acpi_get_parent (adev->handle, &parent_handle)) && +ACPI_SUCCESS (acpi_get_parent (adev->handle, &parent_handle)) &&ACPI_HANDLE (ctlr->dev.parent) == parent_handle) {/* Apple does not use _CRS but nested devices for SPI slaves */ acpi_spi_parse_apple_properties (adev, &lookup);
sound/pci/hda/hda_intel.c +2 -2
@@ -1444,7 +1444,7 @@ static bool atpx_present(void) dhandle =ACPI_HANDLE (&pdev->dev);if (dhandle) { status =acpi_get_handle (dhandle,"ATPX" , &atpx_handle); -if (!ACPI_FAILURE (status)) { +if (ACPI_SUCCESS (status)) {pci_dev_put (pdev);return true; }
@@ -1454,7 +1454,7 @@ static bool atpx_present(void) dhandle =ACPI_HANDLE (&pdev->dev);if (dhandle) { status =acpi_get_handle (dhandle,"ATPX" , &atpx_handle); -if (!ACPI_FAILURE (status)) { +if (ACPI_SUCCESS (status)) {pci_dev_put (pdev);return true; }
Signature · 6 lines
2.25.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 8 lines · Bjorn Helgaas
From: Bjorn Helgaas <[email protected]>
The double negative makes it hard to read "if (!ACPI_FAILURE(status))". Replace it with "if (
ACPI_SUCCESS(status))".Signed-off-by Bjorn Helgaas <[email protected]>---
Quoted 8 lines
This isn't really an ACPI patch, but I'm sending it to you, Rafael, since it seems easier to just apply these all at once. But I'd be happy to split them up into individual patches if you'd rather.
drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 4 ++-- drivers/gpu/drm/radeon/radeon_bios.c | 4 ++-- drivers/hwmon/acpi_power_meter.c | 4 ++--
Quoted 140 lines
drivers/platform/x86/asus-laptop.c | 6 +++--- drivers/spi/spi.c | 2 +- sound/pci/hda/hda_intel.c | 4 ++-- 6 files changed, 12 insertions(+), 12 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c +2
-2@@ -291,7 +291,7 @@ static bool amdgpu_atrm_get_bios(struct amdgpu_device *adev)continue ; status =acpi_get_handle (dhandle,"ATRM" , &atrm_handle); -if (!ACPI_FAILURE (status)) { +if (ACPI_SUCCESS (status)) { found = true;break ; }@@ -304,7 +304,7 @@ static bool amdgpu_atrm_get_bios(struct amdgpu_device *adev)continue ; status =acpi_get_handle (dhandle,"ATRM" , &atrm_handle); -if (!ACPI_FAILURE (status)) { +if (ACPI_SUCCESS (status)) { found = true;break ; }drivers/gpu/drm/radeon/radeon_bios.c +2
-2@@ -205,7 +205,7 @@ static bool radeon_atrm_get_bios(struct radeon_device *rdev)continue ; status =acpi_get_handle (dhandle,"ATRM" , &atrm_handle); -if (!ACPI_FAILURE (status)) { +if (ACPI_SUCCESS (status)) { found = true;break ; }@@ -218,7 +218,7 @@ static bool radeon_atrm_get_bios(struct radeon_device *rdev)continue ; status =acpi_get_handle (dhandle,"ATRM" , &atrm_handle); -if (!ACPI_FAILURE (status)) { +if (ACPI_SUCCESS (status)) { found = true;break ; }drivers/hwmon/acpi_power_meter.c +2
-2@@ -161,7 +161,7 @@ static ssize_t set_avg_interval(struct device *dev,mutex_lock (&resource->lock); status =acpi_evaluate_integer (resource->acpi_dev->handle,"_PAI" , &args, &data); -if (!ACPI_FAILURE (status)) +if (ACPI_SUCCESS (status)) resource->avg_interval = temp;mutex_unlock (&resource->lock);@@ -232,7 +232,7 @@ static ssize_t set_cap(struct device *dev, struct device_attribute *devattr,mutex_lock (&resource->lock); status =acpi_evaluate_integer (resource->acpi_dev->handle,"_SHL" , &args, &data); -if (!ACPI_FAILURE (status)) +if (ACPI_SUCCESS (status)) resource->cap = temp;mutex_unlock (&resource->lock);drivers/platform/x86/asus-laptop.c +3
-3@@ -861,7 +861,7 @@ static ssize_t infos_show(struct device *dev, struct device_attribute *attr,* The significance of others is yet to be found. */ rv =acpi_evaluate_integer (asus->handle,"SFUN" ,NULL , &temp); -if (!ACPI_FAILURE (rv)) +if (ACPI_SUCCESS (rv)) len +=sprintf (page + len,"SFUN value : %#x\n" , (uint ) temp);/* @@ -873,7 +873,7 @@ static ssize_t infos_show(struct device *dev, struct device_attribute *attr,* takes several seconds to run on some systems. */ rv =acpi_evaluate_integer (asus->handle,"HWRS" ,NULL , &temp); -if (!ACPI_FAILURE (rv)) +if (ACPI_SUCCESS (rv)) len +=sprintf (page + len,"HWRS value : %#x\n" , (uint ) temp);/* @@ -884,7 +884,7 @@ static ssize_t infos_show(struct device *dev, struct device_attribute *attr,* silently ignored. */ rv =acpi_evaluate_integer (asus->handle,"ASYM" ,NULL , &temp); -if (!ACPI_FAILURE (rv)) +if (ACPI_SUCCESS (rv)) len +=sprintf (page + len,"ASYM value : %#x\n" , (uint ) temp);if (asus->dsdt_info) {drivers/spi/spi.c +1
-1@@ -2210,7 +2210,7 @@ static acpi_status acpi_register_spi_device(struct spi_controller *ctlr,return AE_OK ;if (!lookup.max_speed_hz && - !ACPI_FAILURE (acpi_get_parent (adev->handle, &parent_handle)) && +ACPI_SUCCESS (acpi_get_parent (adev->handle, &parent_handle)) &&ACPI_HANDLE (ctlr->dev.parent) == parent_handle) {/* Apple does not use _CRS but nested devices for SPI slaves */ acpi_spi_parse_apple_properties (adev, &lookup);sound/pci/hda/hda_intel.c +2
-2@@ -1444,7 +1444,7 @@ static bool atpx_present(void) dhandle =ACPI_HANDLE (&pdev->dev);if (dhandle) { status =acpi_get_handle (dhandle,"ATPX" , &atpx_handle); -if (!ACPI_FAILURE (status)) { +if (ACPI_SUCCESS (status)) {pci_dev_put (pdev);return true; }@@ -1454,7 +1454,7 @@ static bool atpx_present(void) dhandle =ACPI_HANDLE (&pdev->dev);if (dhandle) { status =acpi_get_handle (dhandle,"ATPX" , &atpx_handle); -if (!ACPI_FAILURE (status)) { +if (ACPI_SUCCESS (status)) {pci_dev_put (pdev);return true; }Signature · 1 line
2.25.1
[AMD Public Use]
Quoted 23 lines
-----Original Message-----
From: Bjorn Helgaas <[email protected]>
Sent: Tuesday, January 26, 2021 3:23 PM
To: Rafael J . Wysocki <[email protected]>; Len Brown <[email protected]>; Deucher, Alexander <[email protected]>; Koenig, Christian <[email protected]>; Jean Delvare <[email protected]>; Guenter Roeck <[email protected]>; Corentin Chary <[email protected]>; Mark Brown <[email protected]>; Jaroslav Kysela <[email protected]>; Takashi Iwai <[email protected]>
Cc: [email protected]; [email protected]; linux- [email protected]; [email protected]; alsa-devel@alsa- project.org; [email protected]; Bjorn Helgaas <[email protected]>
Subject: [PATCH] ACPI: Test forACPI_SUCCESSrather than !ACPI_FAILUREFrom: Bjorn Helgaas <[email protected]>
The double negative makes it hard to read "if (!ACPI_FAILURE(status))". Replace it with "if (
ACPI_SUCCESS(status))".Signed-off-by Bjorn Helgaas <[email protected]>---
Quoted 7 lines
This isn't really an ACPI patch, but I'm sending it to you, Rafael, since it seems easier to just apply these all at once. But I'd be happy to split them up into individual patches if you'd rather.
drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 4 ++-- drivers/gpu/drm/radeon/radeon_bios.c | 4 ++--
For radeon and amdgpu:
Quoted 158 lines
drivers/hwmon/acpi_power_meter.c | 4 ++-- drivers/platform/x86/asus-laptop.c | 6 +++--- drivers/spi/spi.c | 2 +- sound/pci/hda/hda_intel.c | 4 ++-- 6 files changed, 12 insertions(+), 12 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c +1
-1@@ -291,7 +291,7 @@ static bool amdgpu_atrm_get_bios(struct amdgpu_device *adev) continue; status =acpi_get_handle (dhandle,"ATRM" , &atrm_handle); -if (!ACPI_FAILURE (status)) { +if (ACPI_SUCCESS (status)) { found = true;break ;drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c +1
-1}@@ -304,7 +304,7 @@ static bool amdgpu_atrm_get_bios(struct amdgpu_device *adev) continue; status =acpi_get_handle (dhandle,"ATRM" , &atrm_handle); -if (!ACPI_FAILURE (status)) { +if (ACPI_SUCCESS (status)) { found = true;drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c +0
-0break ; }drivers/gpu/drm/radeon/radeon_bios.c +1
-1@@ -205,7 +205,7 @@ static bool radeon_atrm_get_bios(struct radeon_device *rdev) continue; status =acpi_get_handle (dhandle,"ATRM" , &atrm_handle); -if (!ACPI_FAILURE (status)) { +if (ACPI_SUCCESS (status)) { found = true;break ;drivers/gpu/drm/radeon/radeon_bios.c +1
-1}@@ -218,7 +218,7 @@ static bool radeon_atrm_get_bios(struct radeon_device *rdev) continue; status =acpi_get_handle (dhandle,"ATRM" , &atrm_handle); -if (!ACPI_FAILURE (status)) { +if (ACPI_SUCCESS (status)) { found = true;drivers/gpu/drm/radeon/radeon_bios.c +0
-0break ; }drivers/hwmon/acpi_power_meter.c +2
-2@@ -161,7 +161,7 @@ static ssize_t set_avg_interval(struct device *dev,mutex_lock (&resource->lock); status =acpi_evaluate_integer (resource->acpi_dev->handle,"_PAI" , &args, &data); -if (!ACPI_FAILURE (status)) +if (ACPI_SUCCESS (status)) resource->avg_interval = temp;mutex_unlock (&resource->lock);@@ -232,7 +232,7 @@ static ssize_t set_cap(struct device *dev, struct device_attribute *devattr,mutex_lock (&resource->lock); status =acpi_evaluate_integer (resource->acpi_dev->handle,"_SHL" , &args, &data); -if (!ACPI_FAILURE (status)) +if (ACPI_SUCCESS (status)) resource->cap = temp;drivers/hwmon/acpi_power_meter.c +0
-0mutex_unlock (&resource->lock);drivers/platform/x86/asus- renamed from drivers/platform/x86/asus-laptop.c +0
-0
laptop.c
index0edafe687fa9..bfea656e910c100644drivers/platform/x86/asus-laptop.c +1
-1@@ -861,7 +861,7 @@ static ssize_t infos_show(struct device *dev, structdevice_attribute *attr, * The significance of others is yet to be found. */ rv =acpi_evaluate_integer (asus->handle,"SFUN" ,NULL , &temp); -if (!ACPI_FAILURE (rv)) +if (ACPI_SUCCESS (rv)) len +=sprintf (page + len,"SFUN value : %#x\n" , (uint ) temp);drivers/platform/x86/asus-laptop.c +1
-1/* @@ -873,7 +873,7 @@ static ssize_t infos_show(struct device *dev, structdevice_attribute *attr, * takes several seconds to run on some systems. */ rv =acpi_evaluate_integer (asus->handle,"HWRS" ,NULL , &temp); -if (!ACPI_FAILURE (rv)) +if (ACPI_SUCCESS (rv)) len +=sprintf (page + len,"HWRS value : %#x\n" , (uint ) temp);drivers/platform/x86/asus-laptop.c +1
-1/* @@ -884,7 +884,7 @@ static ssize_t infos_show(struct device *dev, structdevice_attribute *attr, * silently ignored. */ rv =acpi_evaluate_integer (asus->handle,"ASYM" ,NULL , &temp); -if (!ACPI_FAILURE (rv)) +if (ACPI_SUCCESS (rv)) len +=sprintf (page + len,"ASYM value : %#x\n" , (uint ) temp);drivers/platform/x86/asus-laptop.c +0
-0if (asus->dsdt_info) {drivers/spi/spi.c index renamed from drivers/spi/spi.c +0
-0
720ab34784c1..801d8b499788100644drivers/spi/spi.c +0
-1@@ -2210,7 +2210,7 @@ static acpi_status acpi_register_spi_device(structspi_controller *ctlr, return AE_OK; if (!lookup.max_speed_hz && - !ACPI_FAILURE(acpi_get_parent(adev->handle, &parent_handle))&&
drivers/spi/spi.c +1
-0+ACPI_SUCCESS (acpi_get_parent (adev->handle, &parent_handle))&&
drivers/spi/spi.c +0
-0ACPI_HANDLE(ctlr->dev.parent) == parent_handle) {/* Apple does not use _CRS but nested devices for SPI slaves */
acpi_spi_parse_apple_properties(adev, &lookup); diff --gita/sound/pci/hda/hda_intel.cb/sound/pci/hda/hda_intel.cindex770ad25f1907..fe8049cd2765100644sound/pci/hda/hda_intel.c +1
-1@@ -1444,7 +1444,7 @@ static bool atpx_present(void) dhandle =ACPI_HANDLE (&pdev->dev);if (dhandle) { status =acpi_get_handle (dhandle,"ATPX" , &atpx_handle); -if (!ACPI_FAILURE (status)) { +if (ACPI_SUCCESS (status)) {pci_dev_put (pdev);return true;sound/pci/hda/hda_intel.c +1
-1}@@ -1454,7 +1454,7 @@ static bool atpx_present(void) dhandle =ACPI_HANDLE (&pdev->dev);if (dhandle) { status =acpi_get_handle (dhandle,"ATPX" , &atpx_handle); -if (!ACPI_FAILURE (status)) { +if (ACPI_SUCCESS (status)) {pci_dev_put (pdev);return true;
Quoted 3 lines
}
--
2.25.1
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 14 lines · Bjorn Helgaas
From: Bjorn Helgaas <[email protected]>
The double negative makes it hard to read "if (!ACPI_FAILURE(status))". Replace it with "if (
ACPI_SUCCESS(status))".Signed-off-by Bjorn Helgaas <[email protected]>---
This isn't really an ACPI patch, but I'm sending it to you, Rafael, since it seems easier to just apply these all at once. But I'd be happy to split them up into individual patches if you'd rather.
Quoted 6 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 4 ++-- drivers/gpu/drm/radeon/radeon_bios.c | 4 ++-- drivers/hwmon/acpi_power_meter.c | 4 ++-- drivers/platform/x86/asus-laptop.c | 6 +++--- drivers/spi/spi.c | 2 +- sound/pci/hda/hda_intel.c | 4 ++--
For the sound/*:
thanks,
Takashi
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 4 lines · Bjorn Helgaas
From: Bjorn Helgaas <[email protected]>
The double negative makes it hard to read "if (!ACPI_FAILURE(status))". Replace it with "if (
ACPI_SUCCESS(status))".
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 11 lines · Bjorn Helgaas
From: Bjorn Helgaas <[email protected]>
The double negative makes it hard to read "if (!ACPI_FAILURE(status))". Replace it with "if (
ACPI_SUCCESS(status))".Signed-off-by Bjorn Helgaas <[email protected]>---
This isn't really an ACPI patch, but I'm sending it to you, Rafael, since it seems easier to just apply these all at once. But I'd be happy to split them up into individual patches if you'd rather.
Thanks, everybody. Rafael, I'll just merge this via my tree to avoid burdening you.
Quoted 143 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 4 ++-- drivers/gpu/drm/radeon/radeon_bios.c | 4 ++-- drivers/hwmon/acpi_power_meter.c | 4 ++-- drivers/platform/x86/asus-laptop.c | 6 +++--- drivers/spi/spi.c | 2 +- sound/pci/hda/hda_intel.c | 4 ++-- 6 files changed, 12 insertions(+), 12 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c +2
-2@@ -291,7 +291,7 @@ static bool amdgpu_atrm_get_bios(struct amdgpu_device *adev)continue ; status =acpi_get_handle (dhandle,"ATRM" , &atrm_handle); -if (!ACPI_FAILURE (status)) { +if (ACPI_SUCCESS (status)) { found = true;break ; }@@ -304,7 +304,7 @@ static bool amdgpu_atrm_get_bios(struct amdgpu_device *adev)continue ; status =acpi_get_handle (dhandle,"ATRM" , &atrm_handle); -if (!ACPI_FAILURE (status)) { +if (ACPI_SUCCESS (status)) { found = true;break ; }drivers/gpu/drm/radeon/radeon_bios.c +2
-2@@ -205,7 +205,7 @@ static bool radeon_atrm_get_bios(struct radeon_device *rdev)continue ; status =acpi_get_handle (dhandle,"ATRM" , &atrm_handle); -if (!ACPI_FAILURE (status)) { +if (ACPI_SUCCESS (status)) { found = true;break ; }@@ -218,7 +218,7 @@ static bool radeon_atrm_get_bios(struct radeon_device *rdev)continue ; status =acpi_get_handle (dhandle,"ATRM" , &atrm_handle); -if (!ACPI_FAILURE (status)) { +if (ACPI_SUCCESS (status)) { found = true;break ; }drivers/hwmon/acpi_power_meter.c +2
-2@@ -161,7 +161,7 @@ static ssize_t set_avg_interval(struct device *dev,mutex_lock (&resource->lock); status =acpi_evaluate_integer (resource->acpi_dev->handle,"_PAI" , &args, &data); -if (!ACPI_FAILURE (status)) +if (ACPI_SUCCESS (status)) resource->avg_interval = temp;mutex_unlock (&resource->lock);@@ -232,7 +232,7 @@ static ssize_t set_cap(struct device *dev, struct device_attribute *devattr,mutex_lock (&resource->lock); status =acpi_evaluate_integer (resource->acpi_dev->handle,"_SHL" , &args, &data); -if (!ACPI_FAILURE (status)) +if (ACPI_SUCCESS (status)) resource->cap = temp;mutex_unlock (&resource->lock);drivers/platform/x86/asus-laptop.c +3
-3@@ -861,7 +861,7 @@ static ssize_t infos_show(struct device *dev, struct device_attribute *attr,* The significance of others is yet to be found. */ rv =acpi_evaluate_integer (asus->handle,"SFUN" ,NULL , &temp); -if (!ACPI_FAILURE (rv)) +if (ACPI_SUCCESS (rv)) len +=sprintf (page + len,"SFUN value : %#x\n" , (uint ) temp);/* @@ -873,7 +873,7 @@ static ssize_t infos_show(struct device *dev, struct device_attribute *attr,* takes several seconds to run on some systems. */ rv =acpi_evaluate_integer (asus->handle,"HWRS" ,NULL , &temp); -if (!ACPI_FAILURE (rv)) +if (ACPI_SUCCESS (rv)) len +=sprintf (page + len,"HWRS value : %#x\n" , (uint ) temp);/* @@ -884,7 +884,7 @@ static ssize_t infos_show(struct device *dev, struct device_attribute *attr,* silently ignored. */ rv =acpi_evaluate_integer (asus->handle,"ASYM" ,NULL , &temp); -if (!ACPI_FAILURE (rv)) +if (ACPI_SUCCESS (rv)) len +=sprintf (page + len,"ASYM value : %#x\n" , (uint ) temp);if (asus->dsdt_info) {drivers/spi/spi.c +1
-1@@ -2210,7 +2210,7 @@ static acpi_status acpi_register_spi_device(struct spi_controller *ctlr,return AE_OK ;if (!lookup.max_speed_hz && - !ACPI_FAILURE (acpi_get_parent (adev->handle, &parent_handle)) && +ACPI_SUCCESS (acpi_get_parent (adev->handle, &parent_handle)) &&ACPI_HANDLE (ctlr->dev.parent) == parent_handle) {/* Apple does not use _CRS but nested devices for SPI slaves */ acpi_spi_parse_apple_properties (adev, &lookup);sound/pci/hda/hda_intel.c +2
-2@@ -1444,7 +1444,7 @@ static bool atpx_present(void) dhandle =ACPI_HANDLE (&pdev->dev);if (dhandle) { status =acpi_get_handle (dhandle,"ATPX" , &atpx_handle); -if (!ACPI_FAILURE (status)) { +if (ACPI_SUCCESS (status)) {pci_dev_put (pdev);return true; }@@ -1454,7 +1454,7 @@ static bool atpx_present(void) dhandle =ACPI_HANDLE (&pdev->dev);if (dhandle) { status =acpi_get_handle (dhandle,"ATPX" , &atpx_handle); -if (!ACPI_FAILURE (status)) { +if (ACPI_SUCCESS (status)) {pci_dev_put (pdev);return true; }Signature · 1 line
2.25.1
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Rafael J. Wysocki
maintainerQuoted 10 lines · Bjorn Helgaas
Quoted 8 lines · Bjorn Helgaas
From: Bjorn Helgaas <[email protected]>
The double negative makes it hard to read "if (!ACPI_FAILURE(status))". Replace it with "if (
ACPI_SUCCESS(status))".Signed-off-by Bjorn Helgaas <[email protected]>---
Quoted 6 lines
Quoted 3 lines
This isn't really an ACPI patch, but I'm sending it to you, Rafael, since it seems easier to just apply these all at once. But I'd be happy to split them up into individual patches if you'd rather.
Thanks, everybody. Rafael, I'll just merge this via my tree to avoid burdening you.
It may conflict with some janitorial stuff I'm doing, though, so unless you've already applied it, I'd prefer to take it via the ACPI tree.
Cheers!
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 15 lines · Rafael J. Wysocki
Quoted 14 lines · Bjorn Helgaas
Quoted 11 lines · Bjorn Helgaas
From: Bjorn Helgaas <[email protected]>
The double negative makes it hard to read "if (!ACPI_FAILURE(status))". Replace it with "if (
ACPI_SUCCESS(status))".Signed-off-by Bjorn Helgaas <[email protected]>---
This isn't really an ACPI patch, but I'm sending it to you, Rafael, since it seems easier to just apply these all at once. But I'd be happy to split them up into individual patches if you'd rather.
Quoted 6 lines
Quoted 2 lines
Thanks, everybody. Rafael, I'll just merge this via my tree to avoid burdening you.
It may conflict with some janitorial stuff I'm doing, though, so unless you've already applied it, I'd prefer to take it via the ACPI tree.
No problem, it's all yours!
Bjorn
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Rafael J. Wysocki
maintainerQuoted 17 lines · Bjorn Helgaas
Quoted 15 lines · Rafael J. Wysocki
Quoted 14 lines · Bjorn Helgaas
Quoted 11 lines · Bjorn Helgaas
From: Bjorn Helgaas <[email protected]>
The double negative makes it hard to read "if (!ACPI_FAILURE(status))". Replace it with "if (
ACPI_SUCCESS(status))".Signed-off-by Bjorn Helgaas <[email protected]>---
This isn't really an ACPI patch, but I'm sending it to you, Rafael, since it seems easier to just apply these all at once. But I'd be happy to split them up into individual patches if you'd rather.
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
Thanks, everybody. Rafael, I'll just merge this via my tree to avoid burdening you.
It may conflict with some janitorial stuff I'm doing, though, so unless you've already applied it, I'd prefer to take it via the ACPI tree.
No problem, it's all yours!
Applied as 5.12 material with the ACKs, thanks!
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx