Skip to contentSkip to conversation

net/ice/base: don't set VLAN mode in DCF mode

PATCH Applied Haiyue Wang 3 participants 3 messages Jan 27, 2021 – Jan 28, 2021 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/ice/base: don't set VLAN mode in DCF mode

The PF will set the VLAN mode globally, DCF just needs to get the VLAN mode.

---
 drivers/net/ice/base/ice_vlan_mode.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/net/ice/base/ice_vlan_mode.c +6 -0
index 2e4c3f62c4..460c4f902b 100644
@@ -354,6 +354,12 @@ static enum ice_status ice_set_svm(struct ice_hw *hw)
  */
 enum ice_status ice_set_vlan_mode(struct ice_hw *hw)
 {
+	/* DCF only has the ability to query the VLAN mode. Setting the VLAN
+	 * mode is done by the PF.
+	 */
+	if (hw->dcf_enabled)
+		return ICE_SUCCESS;
+
 	if (!ice_is_dvm_supported(hw))
 		return ICE_SUCCESS;
 
Signature · 1 line
2.30.0
Acked-by on v1 1/1
#1 lore raw
Quoted 35 lines

-----Original Message-----
From: Wang, Haiyue <[email protected]>
Sent: Thursday, January 28, 2021 00:05
To: [email protected]
Cc: Yang, Qiming <[email protected]>; Zhang, Qi Z <[email protected]>; Wang, Haiyue <[email protected]>
Subject: [PATCH v1] net/ice/base: don't set VLAN mode in DCF mode

The PF will set the VLAN mode globally, DCF just needs to get the VLAN mode.

---
 drivers/net/ice/base/ice_vlan_mode.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/net/ice/base/ice_vlan_mode.c +6 -1
index 2e4c3f62c4..460c4f902b 100644
@@ -354,6 +354,12 @@ static enum ice_status ice_set_svm(struct ice_hw
 *hw)
  */
 enum ice_status ice_set_vlan_mode(struct ice_hw *hw)  {
+	/* DCF only has the ability to query the VLAN mode. Setting the VLAN
+	 * mode is done by the PF.
+	 */
+	if (hw->dcf_enabled)
+		return ICE_SUCCESS;
+
 	if (!ice_is_dvm_supported(hw))
 		return ICE_SUCCESS;
 
--

2.30.0

Applied
#2 lore raw
Quoted 19 lines

-----Original Message-----
From: Yang, Qiming <[email protected]>
Sent: Thursday, January 28, 2021 4:22 PM
To: Wang, Haiyue <[email protected]>; [email protected]
Cc: Zhang, Qi Z <[email protected]>
Subject: RE: [PATCH v1] net/ice/base: don't set VLAN mode in DCF mode

Quoted 8 lines

-----Original Message-----
From: Wang, Haiyue <[email protected]>
Sent: Thursday, January 28, 2021 00:05
To: [email protected]
Cc: Yang, Qiming <[email protected]>; Zhang, Qi Z <[email protected]>; Wang, Haiyue <[email protected]>
Subject: [PATCH v1] net/ice/base: don't set VLAN mode in DCF mode

Quoted 4 lines
Quoted 1 line

The PF will set the VLAN mode globally, DCF just needs to get the VLAN

mode.

Quoted 2 lines

Applied to dpdk-next-net-intel.

Thanks
Qi