Skip to contentSkip to conversation

hwmon: (aht10) Unlock on error in aht10_read_values()

PATCH Applied Dan Carpenter 2 participants 2 messages Jan 27, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hwmon: (aht10) Unlock on error in aht10_read_values()

This error path needs to drop the lock before returning.

Fixes afd018716398 ("hwmon: Add AHT10 Temperature and Humidity Sensor Driver")
---
 drivers/hwmon/aht10.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/hwmon/aht10.c +3 -1
index c70d8c2d0c1f..2d9770cb4401 100644
@@ -138,8 +138,10 @@ static int aht10_read_values(struct aht10_data *data)
 	mutex_lock(&data->lock);
 	if (aht10_polltime_expired(data)) {
 		res = i2c_master_send(client, cmd_meas, sizeof(cmd_meas));
-		if (res < 0)
+		if (res < 0) {
+			mutex_unlock(&data->lock);
 			return res;
+		}
 
 		usleep_range(AHT10_MEAS_DELAY,
 			     AHT10_MEAS_DELAY + AHT10_DELAY_EXTRA);
Signature · 1 line
2.29.2
maintainer Applied
#1 lore raw
Quoted 4 lines · Dan Carpenter

This error path needs to drop the lock before returning.

Fixes afd018716398 ("hwmon: Add AHT10 Temperature and Humidity Sensor Driver")

Applied.

Thanks,
Guenter