ARM: dts: sti: Introduce 4KOpen (stih418-b2264) board
PATCH 2/2 ARM: dts: sti: Introduce 4KOpen (stih418-b2264) board
4KOpen (B2264) is a board based on the STMicroelectronics STiH418 soc:
- 2GB DDR
- HDMI
- Ethernet 1000-BaseT
- PCIe (mini PCIe connector)
- MicroSD slot
- USB2 and USB3 connectors
- Sata
- 40 pins GPIO header
--- arch/arm/boot/dts/Makefile | 3 +- arch/arm/boot/dts/stih418-b2264.dts | 127 ++++++++++++++++++++++++++++ 2 files changed, 129 insertions(+), 1 deletion(-) create mode 100644 arch/arm/boot/dts/stih418-b2264.dts
arch/arm/boot/dts/Makefile +2 -1
@@ -1059,7 +1059,8 @@ dtb-$(CONFIG_ARCH_STI) += \ stih407-b2120.dtb \ stih410-b2120.dtb \ stih410-b2260.dtb \ - stih418-b2199.dtb + stih418-b2199.dtb \ + stih418-b2264.dtb dtb-$(CONFIG_ARCH_STM32) += \ stm32f429-disco.dtb \ stm32f469-disco.dtb \
arch/arm/boot/dts/stih418-b2264.dts new file +127 -0
127 lines not on this page · raw message
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 11 lines · Alain Volmat
4KOpen (B2264) is a board based on the STMicroelectronics STiH418 soc:
- 2GB DDR
- HDMI
- Ethernet 1000-BaseT
- PCIe (mini PCIe connector)
- MicroSD slot
- USB2 and USB3 connectors
- Sata
- 40 pins GPIO header
Quoted 1 line
Signed-off-by Alain Volmat <[email protected]>
The changelog text seems fine here.
Quoted 6 lines
arch/arm/boot/dts/stih418-b2264.dts new file +6
-0+// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (C) 2021 STMicroelectronics + * Author: Alain Volmat <[email protected]> + */ +/dts-v1/;
arch/arm/boot/dts/stih418-b2264.dts line 16
Quoted 10 lines
arch/arm/boot/dts/stih418-b2264.dts new file +10
-0+#include "stih418.dtsi" +#include <dt-bindings/gpio/gpio.h> +/ { + model = "STiH418 B2264"; + compatible = "st,stih418-b2264", "st,stih418"; + + chosen { + bootargs = "console=ttyAS0,115200 clk_ignore_unused"; + stdout-path = &sbc_serial0; + };
I don't think the bootargs should be there, both are just hacks when things don't work correctly. If they don't, then try to fix them first, by making sure that all clocks are properly listed, and that the stdou-path points the working console.
Review
Quoted 3 lines
+&rng11 {
(quoted diff) +2
-0+ status = "disabled"; +};
Why do you disable the random number generator?
Arnd
Hi Arnd,
thanks for the comments and sorry for the large 'To' list. In my v2 I'll limit to Patrice Chotard (STi maintainer).
Quoted 29 lines · Arnd Bergmann
Quoted 11 lines · Alain Volmat
4KOpen (B2264) is a board based on the STMicroelectronics STiH418 soc:
- 2GB DDR
- HDMI
- Ethernet 1000-BaseT
- PCIe (mini PCIe connector)
- MicroSD slot
- USB2 and USB3 connectors
- Sata
- 40 pins GPIO headerQuoted 1 line
Signed-off-by Alain Volmat <[email protected]>The changelog text seems fine here.
Quoted 13 lines
arch/arm/boot/dts/stih418-b2264.dts new file +13
-0+// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (C) 2021 STMicroelectronics + * Author: Alain Volmat <[email protected]> + */ +/dts-v1/; +#include "stih418.dtsi" +#include <dt-bindings/gpio/gpio.h> +/ { + model = "STiH418 B2264"; + compatible = "st,stih418-b2264", "st,stih418"; + + chosen {
Quoted 8 lines
arch/arm/boot/dts/stih418-b2264.dts line 16
Quoted 3 lines
arch/arm/boot/dts/stih418-b2264.dts new file +3
-0+ bootargs = "console=ttyAS0,115200 clk_ignore_unused"; + stdout-path = &sbc_serial0; + };I don't think the bootargs should be there, both are just hacks when things don't work correctly. If they don't, then try to fix them first, by making sure that all clocks are properly listed, and that the stdou-path points the working console.
Indeed, bootargs can be cleaned up. console is not necessary, however it's going to be hard to get rid of the clk_ignore_unused now and I'd prefer to keep it now, in the same way as for the other sti DTs.
Quoted 6 lines
Review
Quoted 4 lines
+&rng11 {
(quoted diff) +2
-0+ status = "disabled"; +};Why do you disable the random number generator?
I shouldn't have putted this within the board DT. This rng11 is not available on the STiH418.
In the v2 serie I'll had a separate commit to fix the stih418.dtsi instead.
Alain
Quoted 2 lines
Arnd