i2c: tegra: Use threaded interrupt
Dmitry Osipenko
reviewerPATCH 1/1 i2c: tegra: Use threaded interrupt
Switch to use threaded interrupt context in order to avoid checking of "are we in interrupt?" for the code that may sleep in the IRQ handler. I2C doesn't require a very low interrupt-handling latency, hence this change doesn't introduce any noticeable effects.
Signed-off-by Dmitry Osipenko <[email protected]>
--- drivers/i2c/busses/i2c-tegra.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/i2c/busses/i2c-tegra.c +5 -4
@@ -533,7 +533,7 @@ static int tegra_i2c_poll_register(struct tegra_i2c_dev *i2c_dev,void __iomem *addr = i2c_dev->base +tegra_i2c_reg_addr (i2c_dev, reg);u32 val; -if (!i2c_dev->atomic_mode && !in_irq ()) +if (!i2c_dev->atomic_mode)return readl_relaxed_poll_timeout (addr, val, !(val & mask), delay_us, timeout_us);
@@ -1719,9 +1719,10 @@ static int tegra_i2c_probe(struct platform_device *pdev)/* interrupt will be enabled during of transfer time */ irq_set_status_flags (i2c_dev->irq,IRQ_NOAUTOEN ); - err =devm_request_irq (i2c_dev->dev, i2c_dev->irq, tegra_i2c_isr, -IRQF_NO_SUSPEND ,dev_name (i2c_dev->dev), - i2c_dev); + err =devm_request_threaded_irq (i2c_dev->dev, i2c_dev->irq, +NULL , tegra_i2c_isr, +IRQF_NO_SUSPEND |IRQF_ONESHOT , +dev_name (i2c_dev->dev), i2c_dev);if (err)return err;
Signature · 1 line
2.29.2
Wolfram Sang
AppliedQuoted 6 lines · Dmitry Osipenko
Switch to use threaded interrupt context in order to avoid checking of "are we in interrupt?" for the code that may sleep in the IRQ handler. I2C doesn't require a very low interrupt-handling latency, hence this change doesn't introduce any noticeable effects.
Signed-off-by Dmitry Osipenko <[email protected]>
Applied to for-next, thanks!