Skip to contentSkip to conversation

MAINTAINERS: suggest myself as co-maintainer for Block Jobs

PATCH In review Vladimir Sementsov-Ogievskiy 7 participants 13 messages Jan 28, 2021 – Feb 3, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: suggest myself as co-maintainer for Block Jobs

I'm developing Qemu backup for several years, and finally new backup architecture, including block-copy generic engine and backup-top filter landed upstream, great thanks to reviewers and especially to Max Reitz!

I also have plans of moving other block-jobs onto block-copy, so that we finally have one generic block copying path, fast and well-formed.

So, now I suggest to bring all parts of backup architecture into "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and qemu-co-shared-resource can be reused somewhere else, but I'd keep an eye on them in context of block-jobs) and add myself as co-maintainer.

---
 MAINTAINERS | 9 +++++++++
 1 file changed, 9 insertions(+)
MAINTAINERS +9 -0
index 34359a99b8..9957f39eba 100644
@@ -2207,6 +2207,7 @@ F: scsi/*
 
 Block Jobs
 M: John Snow <[email protected]>
+M: Vladimir Sementsov-Ogievskiy <[email protected]>
 L: [email protected]
 S: Supported
 F: blockjob.c
@@ -2219,6 +2220,14 @@ F: block/commit.c
 F: block/stream.c
 F: block/mirror.c
 F: qapi/job.json
+F: block/block-copy.c
+F: include/block/block-copy.c
+F: block/backup-top.h
+F: block/backup-top.c
+F: include/block/aio_task.h
+F: block/aio_task.c
+F: util/qemu-co-shared-resource.c
+F: include/qemu/co-shared-resource.h
 T: git https://gitlab.com/jsnow/qemu.git jobs
 
 Block QAPI, monitor, command line
Signature · 1 line
2.29.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Vladimir Sementsov-Ogievskiy

I'm developing Qemu backup for several years, and finally new backup architecture, including block-copy generic engine and backup-top filter landed upstream, great thanks to reviewers and especially to Max Reitz!

I also have plans of moving other block-jobs onto block-copy, so that we finally have one generic block copying path, fast and well-formed.

Quoted 6 lines

So, now I suggest to bring all parts of backup architecture into "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and qemu-co-shared-resource can be reused somewhere else, but I'd keep an eye on them in context of block-jobs) and add myself as co-maintainer.

With pleasure:

Reviewed-by
#2 lore raw
Quoted 15 lines · Markus Armbruster
Quoted 13 lines · Vladimir Sementsov-Ogievskiy

I'm developing Qemu backup for several years, and finally new backup architecture, including block-copy generic engine and backup-top filter landed upstream, great thanks to reviewers and especially to Max Reitz!

I also have plans of moving other block-jobs onto block-copy, so that we finally have one generic block copying path, fast and well-formed.

So, now I suggest to bring all parts of backup architecture into "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and qemu-co-shared-resource can be reused somewhere else, but I'd keep an eye on them in context of block-jobs) and add myself as co-maintainer.

Quoted 5 lines
Quoted 1 line

With pleasure:

Absolutely! Glad to see it.

#3 lore raw
Quoted 26 lines · John Snow
Quoted 15 lines · Markus Armbruster
Quoted 13 lines · Vladimir Sementsov-Ogievskiy

I'm developing Qemu backup for several years, and finally new backup architecture, including block-copy generic engine and backup-top filter landed upstream, great thanks to reviewers and especially to Max Reitz!

I also have plans of moving other block-jobs onto block-copy, so that we finally have one generic block copying path, fast and well-formed.

So, now I suggest to bring all parts of backup architecture into "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and qemu-co-shared-resource can be reused somewhere else, but I'd keep an eye on them in context of block-jobs) and add myself as co-maintainer.

Quoted 5 lines
Quoted 1 line

With pleasure:

Absolutely! Glad to see it.

[..]

Quoted 3 lines

Great!

Thanks!

Could someone pull it?

I don't have any signed PGP key for now, to send pull requests :\ Interesting, could I get one while sitting in Moscow?

Signature · 2 lines
Best regards,
Vladimir
#4 lore raw
Quoted 8 lines · Vladimir Sementsov-Ogievskiy
Quoted 7 lines · John Snow
Quoted 6 lines · Markus Armbruster
Quoted 4 lines · Vladimir Sementsov-Ogievskiy

I'm developing Qemu backup for several years, and finally new backup architecture, including block-copy generic engine and backup-top filter landed upstream, great thanks to reviewers and especially to Max Reitz!

<snip>

Quoted 11 lines
Quoted 3 lines

Great!

Thanks!

Could someone pull it?

I don't have any signed PGP key for now, to send pull requests :\
Interesting, could I get one while sitting in Moscow?

Hmm this does point somewhat to a hole in our maintainer process that has previously relied on semi-regular physical meet-up for key signing purposes. It might be some time before we return to a new normal. Are there any other maintainers in Moscow that you could safely meet for a socially distanced key-signing?

Signature · 1 line
Alex Bennée
#5 lore raw
Quoted 21 lines · Alex Bennée
Quoted 8 lines · Vladimir Sementsov-Ogievskiy
Quoted 7 lines · John Snow
Quoted 6 lines · Markus Armbruster
Quoted 4 lines · Vladimir Sementsov-Ogievskiy

I'm developing Qemu backup for several years, and finally new backup architecture, including block-copy generic engine and backup-top filter landed upstream, great thanks to reviewers and especially to Max Reitz!

<snip>

Quoted 9 lines
Quoted 3 lines

Great!

Thanks!

Could someone pull it?

Quoted 8 lines
Quoted 2 lines

I don't have any signed PGP key for now, to send pull requests :\
Interesting, could I get one while sitting in Moscow?

Hmm this does point somewhat to a hole in our maintainer process that has previously relied on semi-regular physical meet-up for key signing purposes. It might be some time before we return to a new normal. Are there any other maintainers in Moscow that you could safely meet for a socially distanced key-signing?

AFAIK, we've never actually set expectations for what process a key signing must use. Merely that key should be signed by one or more people who are already QEMU maintainers. It is more or less up to the person signing the key what hoops they want to jump through before adding their signature.

So while physically meeting is a traditional standard, some might be fine to do key signing verification over a video conference system, especially if both sides already know each other by sight after previous physical meetings.

Regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
Acked-by
#6 lore raw
In reply to Vladimir Sementsov-Ogievskiy

Am 01.02.2021 um 12:03 hat Vladimir Sementsov-Ogievskiy geschrieben:

Quoted 30 lines
Quoted 26 lines · John Snow
Quoted 15 lines · Markus Armbruster
Quoted 13 lines · Vladimir Sementsov-Ogievskiy

I'm developing Qemu backup for several years, and finally new backup architecture, including block-copy generic engine and backup-top filter landed upstream, great thanks to reviewers and especially to Max Reitz!

I also have plans of moving other block-jobs onto block-copy, so that we finally have one generic block copying path, fast and well-formed.

So, now I suggest to bring all parts of backup architecture into "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and qemu-co-shared-resource can be reused somewhere else, but I'd keep an eye on them in context of block-jobs) and add myself as co-maintainer.

Quoted 5 lines
Quoted 1 line

With pleasure:

Absolutely! Glad to see it.

[..]

Quoted 7 lines
Quoted 3 lines

Great!

Thanks!

Could someone pull it?

I've put it in my block branch (with s/suggest myself/Add Vladimir/ in the subject line), but I don't know when I'll send the next pull request. If someone else sends one first, feel free to include it with:

Quoted 2 lines

I don't have any signed PGP key for now, to send pull requests :\
Interesting, could I get one while sitting in Moscow?

If you're planning to send pull requests, should a git tree of yours be added to the MAINTAINERS sections, too?

Kevin

#7 lore raw
Quoted 43 lines · Kevin Wolf

Am 01.02.2021 um 12:03 hat Vladimir Sementsov-Ogievskiy geschrieben:

Quoted 30 lines
Quoted 26 lines · John Snow
Quoted 15 lines · Markus Armbruster
Quoted 13 lines · Vladimir Sementsov-Ogievskiy

I'm developing Qemu backup for several years, and finally new backup architecture, including block-copy generic engine and backup-top filter landed upstream, great thanks to reviewers and especially to Max Reitz!

I also have plans of moving other block-jobs onto block-copy, so that we finally have one generic block copying path, fast and well-formed.

So, now I suggest to bring all parts of backup architecture into "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and qemu-co-shared-resource can be reused somewhere else, but I'd keep an eye on them in context of block-jobs) and add myself as co-maintainer.

Quoted 5 lines
Quoted 1 line

With pleasure:

Absolutely! Glad to see it.

[..]

Quoted 7 lines
Quoted 3 lines

Great!

Thanks!

Could someone pull it?

I've put it in my block branch (with s/suggest myself/Add Vladimir/ in the subject line), but I don't know when I'll send the next pull request. If someone else sends one first, feel free to include it with:

Quoted 8 lines
Quoted 2 lines

I don't have any signed PGP key for now, to send pull requests :\
Interesting, could I get one while sitting in Moscow?

If you're planning to send pull requests, should a git tree of yours be added to the MAINTAINERS sections, too?

I didn't add it because of signed key absence. As it turned out, Denis Lunev (my boss) already has a signed key, so it's not a problem.

I think it's appropriate to add

T: git https://src.openvz.org/scm/~vsementsov/qemu.git jobs

Signature · 2 lines
Best regards,
Vladimir
#8 lore raw

Am 01.02.2021 um 17:20 hat Vladimir Sementsov-Ogievskiy geschrieben:

Quoted 53 lines
Quoted 43 lines · Kevin Wolf

Am 01.02.2021 um 12:03 hat Vladimir Sementsov-Ogievskiy geschrieben:

Quoted 30 lines
Quoted 26 lines · John Snow
Quoted 15 lines · Markus Armbruster
Quoted 13 lines · Vladimir Sementsov-Ogievskiy

I'm developing Qemu backup for several years, and finally new backup architecture, including block-copy generic engine and backup-top filter landed upstream, great thanks to reviewers and especially to Max Reitz!

I also have plans of moving other block-jobs onto block-copy, so that we finally have one generic block copying path, fast and well-formed.

So, now I suggest to bring all parts of backup architecture into "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and qemu-co-shared-resource can be reused somewhere else, but I'd keep an eye on them in context of block-jobs) and add myself as co-maintainer.

Quoted 5 lines
Quoted 1 line

With pleasure:

Absolutely! Glad to see it.

[..]

Quoted 7 lines
Quoted 3 lines

Great!

Thanks!

Could someone pull it?

I've put it in my block branch (with s/suggest myself/Add Vladimir/ in the subject line), but I don't know when I'll send the next pull request. If someone else sends one first, feel free to include it with:

Quoted 8 lines
Quoted 2 lines

I don't have any signed PGP key for now, to send pull requests :\
Interesting, could I get one while sitting in Moscow?

If you're planning to send pull requests, should a git tree of yours be added to the MAINTAINERS sections, too?

Quoted 6 lines

I didn't add it because of signed key absence. As it turned out, Denis Lunev (my boss) already has a signed key, so it's not a problem.

I think it's appropriate to add

T: git https://src.openvz.org/scm/~vsementsov/qemu.git jobs

I've added it to the patch in my queue. Now you just need to actually create that branch. :-)

Kevin

#9 lore raw
Quoted 57 lines · Kevin Wolf

Am 01.02.2021 um 17:20 hat Vladimir Sementsov-Ogievskiy geschrieben:

Quoted 56 lines
Quoted 43 lines · Kevin Wolf

Am 01.02.2021 um 12:03 hat Vladimir Sementsov-Ogievskiy geschrieben:

Quoted 30 lines
Quoted 26 lines · John Snow
Quoted 15 lines · Markus Armbruster
Quoted 13 lines · Vladimir Sementsov-Ogievskiy

I'm developing Qemu backup for several years, and finally new backup architecture, including block-copy generic engine and backup-top filter landed upstream, great thanks to reviewers and especially to Max Reitz!

I also have plans of moving other block-jobs onto block-copy, so that we finally have one generic block copying path, fast and well-formed.

So, now I suggest to bring all parts of backup architecture into "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and qemu-co-shared-resource can be reused somewhere else, but I'd keep an eye on them in context of block-jobs) and add myself as co-maintainer.

Quoted 5 lines
Quoted 1 line

With pleasure:

Absolutely! Glad to see it.

[..]

Quoted 7 lines
Quoted 3 lines

Great!

Thanks!

Could someone pull it?

I've put it in my block branch (with s/suggest myself/Add Vladimir/ in the subject line), but I don't know when I'll send the next pull request. If someone else sends one first, feel free to include it with:

Quoted 8 lines
Quoted 2 lines

I don't have any signed PGP key for now, to send pull requests :\
Interesting, could I get one while sitting in Moscow?

If you're planning to send pull requests, should a git tree of yours be added to the MAINTAINERS sections, too?

I didn't add it because of signed key absence. As it turned out, Denis Lunev (my boss) already has a signed key, so it's not a problem.

Quoted 7 lines
Quoted 3 lines

I think it's appropriate to add

T: git https://src.openvz.org/scm/~vsementsov/qemu.git jobs

I've added it to the patch in my queue. Now you just need to actually create that branch. :-)

done :)

Signature · 2 lines
Best regards,
Vladimir
#10 lore raw
In reply to Vladimir Sementsov-Ogievskiy
Quoted 46 lines · Vladimir Sementsov-Ogievskiy
Quoted 45 lines · Kevin Wolf

Am 01.02.2021 um 12:03 hat Vladimir Sementsov-Ogievskiy geschrieben:

Quoted 30 lines
Quoted 26 lines · John Snow
Quoted 15 lines · Markus Armbruster
Quoted 13 lines · Vladimir Sementsov-Ogievskiy

I'm developing Qemu backup for several years, and finally new backup architecture, including block-copy generic engine and backup-top filter landed upstream, great thanks to reviewers and especially to Max Reitz!

I also have plans of moving other block-jobs onto block-copy, so that we finally have one generic block copying path, fast and well-formed.

So, now I suggest to bring all parts of backup architecture into "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and qemu-co-shared-resource can be reused somewhere else, but I'd keep an eye on them in context of block-jobs) and add myself as co-maintainer.

Quoted 5 lines
Quoted 1 line

With pleasure:

Absolutely! Glad to see it.

[..]

Quoted 7 lines
Quoted 3 lines

Great!

Thanks!

Could someone pull it?

I've put it in my block branch (with s/suggest myself/Add Vladimir/ in the subject line), but I don't know when I'll send the next pull request. If someone else sends one first, feel free to include it with:

Quoted 9 lines
Quoted 6 lines
Quoted 2 lines

I don't have any signed PGP key for now, to send pull requests :\
Interesting, could I get one while sitting in Moscow?

If you're planning to send pull requests, should a git tree of yours be added to the MAINTAINERS sections, too?

I didn't add it because of signed key absence. As it turned out, Denis Lunev (my boss) already has a signed key, so it's not a problem.

Unfortunately, Den doesn't have an access to his private key, so this variant doesn't work. So, probably someone could recognize me in a video call?

My key is here: http://keys.gnupg.net/pks/lookup?search=Vladimir+Sementsov-Ogievskiy&fingerprint=on&op=index (note that there is only one Vladimir Sementsov-Ogievskiy, so I can't imagine who can that be other than me :)

Signature · 2 lines
Best regards,
Vladimir
#11 lore raw
Quoted 54 lines · Vladimir Sementsov-Ogievskiy
Quoted 53 lines · Vladimir Sementsov-Ogievskiy
Quoted 51 lines · Kevin Wolf

Am 01.02.2021 um 12:03 hat Vladimir Sementsov-Ogievskiy geschrieben:

Quoted 30 lines
Quoted 26 lines · John Snow
Quoted 15 lines · Markus Armbruster
Quoted 13 lines · Vladimir Sementsov-Ogievskiy

I'm developing Qemu backup for several years, and finally new backup architecture, including block-copy generic engine and backup-top filter landed upstream, great thanks to reviewers and especially to Max Reitz!

I also have plans of moving other block-jobs onto block-copy, so that we finally have one generic block copying path, fast and well-formed.

So, now I suggest to bring all parts of backup architecture into "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and qemu-co-shared-resource can be reused somewhere else, but I'd keep an eye on them in context of block-jobs) and add myself as co-maintainer.

Quoted 5 lines
Quoted 1 line

With pleasure:

Absolutely! Glad to see it.

[..]

Quoted 7 lines
Quoted 3 lines

Great!

Thanks!

Could someone pull it?

I've put it in my block branch (with s/suggest myself/Add Vladimir/ in the subject line), but I don't know when I'll send the next pull request. If someone else sends one first, feel free to include it with:

Quoted 2 lines

I don't have any signed PGP key for now, to send pull requests :\
Interesting, could I get one while sitting in Moscow?

If you're planning to send pull requests, should a git tree of yours be added to the MAINTAINERS sections, too?

Quoted 7 lines
Quoted 2 lines

I didn't add it because of signed key absence. As it turned out, Denis Lunev (my boss) already has a signed key, so it's not a problem.

Unfortunately, Den doesn't have an access to his private key, so this variant doesn't work. So, probably someone could recognize me in a video call?

My key is here: http://keys.gnupg.net/pks/lookup?search=Vladimir+Sementsov-Ogievskiy&fingerprint=on&op=index (note that there is only one Vladimir Sementsov-Ogievskiy, so I can't imagine who can that be other than me :)

I'm not sure what protocol here is, but you and I and several others met face to face in edinburgh and could at least weakly identify you. Maybe we can sign with a low level of trust for now, and improve it when we get a chance to do a real key signing meetup later?

I think Peter needs to trust your key, ultimately, so I think it's up to him for what criteria he will personally trust.

--js

Reviewed-by on v1 1/1
#12 lore raw
In reply to Vladimir Sementsov-Ogievskiy
Quoted 13 lines · Vladimir Sementsov-Ogievskiy

I'm developing Qemu backup for several years, and finally new backup architecture, including block-copy generic engine and backup-top filter landed upstream, great thanks to reviewers and especially to Max Reitz!

I also have plans of moving other block-jobs onto block-copy, so that we finally have one generic block copying path, fast and well-formed.

So, now I suggest to bring all parts of backup architecture into "Block Jobs" subsystem (actually, aio_task is shared with qcow2 and qemu-co-shared-resource can be reused somewhere else, but I'd keep an eye on them in context of block-jobs) and add myself as co-maintainer.

Quoted 4 lines
---
  MAINTAINERS | 9 +++++++++
  1 file changed, 9 insertions(+)

Great! :)