Skip to contentSkip to conversation

glm: Fix packaging for header-only recipe

PATCH In review Tom Hochstein 3 participants 4 messages Jan 29, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 glm: Fix packaging for header-only recipe

Set ALLOW_EMPTY for the main package to "1" for this header-only recipe. This allows the SDK to be created properly when there is an RDEPENDS on glm.

---
 meta-oe/recipes-graphics/glm/glm_0.9.9.6.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta-oe/recipes-graphics/glm/glm_0.9.9.6.bb +2 -1
index e2f4dbebc..019e6257d 100644
@@ -34,6 +34,7 @@ do_install() {
 
 }
 
-RDEPENDS_${PN}-dev = ""
+# This is a header-only library, so the main package will be empty.
+ALLOW_EMPTY_${PN} = "1"
 
 BBCLASSEXTEND = "native"
Signature · 1 line
2.17.1
#1 lore raw
Quoted 3 lines · Tom Hochstein

Set ALLOW_EMPTY for the main package to "1" for this header-only recipe. This
allows the SDK to be created properly when there is an RDEPENDS on glm.

Runtime dependency on a header only package seems a bit iffy it’s perhaps better to depend on glm-dev perhaps ?

Quoted 28 lines
---
 meta-oe/recipes-graphics/glm/glm_0.9.9.6.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta-oe/recipes-graphics/glm/glm_0.9.9.6.bb +2 -2
index e2f4dbebc..019e6257d 100644
@@ -34,6 +34,7 @@ do_install() {
 
 }
 
-RDEPENDS_${PN}-dev = ""
+# This is a header-only library, so the main package will be empty.
+ALLOW_EMPTY_${PN} = "1"
 
 BBCLASSEXTEND = "native"
--

2.17.1

#2 lore raw
Quoted 6 lines · Khem Raj
Quoted 2 lines · Tom Hochstein

Set ALLOW_EMPTY for the main package to "1" for this header-only recipe. This allows the SDK to be created properly when there is an RDEPENDS on glm.

Runtime dependency on a header only package seems a bit iffy it's perhaps better to depend on glm-dev perhaps ?

Well, it's all iffy in my mind since these are just different workarounds for the root problem that header-only packages are not included in the SDK. If you think including the headers in the image is the better workaround, then I will switch to that.

Tom

#3 lore raw

Em sex., 29 de jan. de 2021 às 13:06, Tom Hochstein <[email protected]> escreveu:

Quoted 8 lines · Khem Raj
Quoted 5 lines · Tom Hochstein
Quoted 2 lines

Set ALLOW_EMPTY for the main package to "1" for this header-only recipe. This allows the SDK to be created properly when there is an RDEPENDS on glm.

Runtime dependency on a header only package seems a bit iffy it's perhaps better to depend on glm-dev perhaps ?

Well, it's all iffy in my mind since these are just different workarounds for the root problem that header-only packages are not included in the SDK. If you think including the headers in the image is the better workaround, then I will switch to that.

The allow empty seems to be the right workaround here as it allow people to consistently use the dev-pkgs filter to populate the SDK.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750