misc: bcm-vk: fix set_q_num API precedence issue
Subsystems (2)
Scott Branden
maintainerPATCH 1/1 misc: bcm-vk: fix set_q_num API precedence issue
From: Desmond Yan <[email protected]>
Change set_q_num API to use if-else to make it more explicit, and avoid a precedence rule issue.
Reported-by kernel test robot <[email protected]>
Signed-off-by Desmond Yan <[email protected]>
Signed-off-by Scott Branden <[email protected]>
--- drivers/misc/bcm-vk/bcm_vk_msg.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
drivers/misc/bcm-vk/bcm_vk_msg.c +8 -2
@@ -52,8 +52,14 @@ static u32 get_q_num(const struct vk_msg_blk *msg)static void set_q_num (struct vk_msg_blk *msg,u32 q_num) { - msg->trans_id = (msg->trans_id & ~BCM_VK_MSG_Q_MASK ) | - (q_num >=VK_MSGQ_PER_CHAN_MAX ) ?VK_MSGQ_NUM_DEFAULT : q_num; +u32 trans_q; + +if (q_num >=VK_MSGQ_PER_CHAN_MAX ) + trans_q =VK_MSGQ_NUM_DEFAULT ; +else + trans_q = q_num; + + msg->trans_id = (msg->trans_id & ~BCM_VK_MSG_Q_MASK ) | trans_q; }static u32 get_msg_id (const struct vk_msg_blk *msg)
Signature · 1 line
2.17.1