mmc: mediatek: add Inline Crypto Engine support
Subsystems (3)
PATCH v2 1/2 mmc: mediatek: add Inline Crypto Engine support
- add crypto clock control and ungate it before CQHCI init
- set MMC_CAP2_CRYPTO property of eMMC
--- drivers/mmc/host/mtk-sd.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-)
drivers/mmc/host/mtk-sd.c +15 -2
@@ -441,6 +441,7 @@ struct msdc_host {struct clk *bus_clk;/* bus clock which used to access register */ struct clk *src_clk_cg;/* msdc source clock control gate */ struct clk *sys_clk_cg;/* msdc subsys clock control gate */ +struct clk *crypto_clk;/* msdc crypto clock */ struct clk_bulk_data bulk_clks[MSDC_NR_CLOCKS ];u32 mclk;/* mmc subsystem clock frequency */ u32 src_clk_freq;/* source clock frequency */
@@ -802,6 +803,7 @@ static void msdc_set_busy_timeout(struct msdc_host *host, u64 ns, u64 clks)static void msdc_gate_clock (struct msdc_host *host) { +clk_disable_unprepare (host->crypto_clk);clk_bulk_disable_unprepare (MSDC_NR_CLOCKS , host->bulk_clks);clk_disable_unprepare (host->src_clk_cg);clk_disable_unprepare (host->src_clk);
@@ -822,7 +824,7 @@ static void msdc_ungate_clock(struct msdc_host *host)dev_err (host->dev,"Cannot enable pclk/axi/ahb clock gates\n" );return ; } - +clk_prepare_enable (host->crypto_clk);while (!(readl (host->base +MSDC_CFG ) &MSDC_CFG_CKSTB ))cpu_relax (); }
@@ -2510,6 +2512,16 @@ static int msdc_drv_probe(struct platform_device *pdev) goto host_free; } +/* only eMMC has crypto property */ +if ((mmc->caps2 &MMC_CAP2_NO_SD ) && (mmc->caps2 &MMC_CAP2_NO_SDIO )) + mmc->caps2 |=MMC_CAP2_CRYPTO ; + +if (mmc->caps2 &MMC_CAP2_CRYPTO ) { + host->crypto_clk =devm_clk_get (&pdev->dev,"crypto_clk" ); +if (IS_ERR (host->crypto_clk)) + host->crypto_clk =NULL ; + } + host->irq =platform_get_irq (pdev,0 );if (host->irq <0 ) { ret = -EINVAL ;
@@ -2580,6 +2592,8 @@ static int msdc_drv_probe(struct platform_device *pdev) host->dma_mask =DMA_BIT_MASK (32 );mmc_dev (mmc)->dma_mask = &host->dma_mask; +/* here ungate due to cqhci init will access registers */ +msdc_ungate_clock (host);if (mmc->caps2 &MMC_CAP2_CQE ) { host->cq_host = devm_kzalloc(mmc->parent, sizeof(*host->cq_host),
@@ -2616,7 +2630,6 @@ static int msdc_drv_probe(struct platform_device *pdev)spin_lock_init (&host->lock);platform_set_drvdata (pdev, mmc); -msdc_ungate_clock (host);msdc_init_hw (host); ret = devm_request_irq(&pdev->dev, host->irq, msdc_irq,
Signature · 1 line
2.18.0
Quoted 5 lines · Peng Zhou
- add crypto clock control and ungate it before CQHCI init
- setMMC_CAP2_CRYPTOproperty of eMMCChange-Id I3a28eaa3718eee73259b4d60867cce25525f9bbaSigned-off-by Peng Zhou <[email protected]>
Please run scripts/checkpatch.pl on this patch (and the next one) and address the warnings and errors.
drivers/mmc/host/mtk-sd.c static int msdc_drv_probe(struct platform_device *pdev) · line 2523
Quoted 9 lines
drivers/mmc/host/mtk-sd.c +9
-0+/* only eMMC has crypto property */ +if ((mmc->caps2 &MMC_CAP2_NO_SD ) && (mmc->caps2 &MMC_CAP2_NO_SDIO )) + mmc->caps2 |=MMC_CAP2_CRYPTO ; + +if (mmc->caps2 &MMC_CAP2_CRYPTO ) { + host->crypto_clk =devm_clk_get (&pdev->dev,"crypto_clk" ); +if (IS_ERR (host->crypto_clk)) + host->crypto_clk =NULL ; + }
Is this logic correct? I'm wondering whether you want something more like:
/* only eMMC has crypto property */ if ((mmc->caps2 & MMC_CAP2_NO_SD) && (mmc->caps2 & MMC_CAP2_NO_SDIO)) host->crypto_clk = devm_clk_get(&pdev->dev, "crypto_clk"); if (IS_ERR(host->crypto_clk)) host->crypto_clk = NULL; else mmc->caps2 |= MMC_CAP2_CRYPTO; }
I.e., is crypto only supported when crypto_clk is present? Or can crypto be supported without crypto_clk being present?
- Eric
One more comment:
drivers/mmc/host/mtk-sd.c static int msdc_drv_probe(struct platform_device *pdev) · line 2523
Quoted 5 lines · Peng Zhou
drivers/mmc/host/mtk-sd.c +5
-0+if (mmc->caps2 &MMC_CAP2_CRYPTO ) { + host->crypto_clk =devm_clk_get (&pdev->dev,"crypto_clk" ); +if (IS_ERR (host->crypto_clk)) + host->crypto_clk =NULL ; + }
I think that clock names aren't supposed to end in "_clk", as this is implied. Just call it "crypto".
- Eric